<div dir="ltr">You're missing a dependency on make in PN-ptest, but installing that results in about 20% of the tests failing. Should they all work?<div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 19 March 2018 at 06:49, Anuj Mittal <span dir="ltr"><<a href="mailto:anuj.mittal@intel.com" target="_blank">anuj.mittal@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Make sure that the tests are packaged and can be executed<br>
when ptest is enabled. Also, remove build host specific references<br>
from Makefile.<br>
<br>
Signed-off-by: Anuj Mittal <<a href="mailto:anuj.mittal@intel.com">anuj.mittal@intel.com</a>><br>
---<br>
</span> .../files/add-a-target-to-<wbr>compile-tests.patch | 46 ++++++++++++++++++++++<br>
meta/recipes-multimedia/<wbr>gstreamer/files/run-ptest | 3 ++<br>
meta/recipes-multimedia/<wbr>gstreamer/gstreamer1.0.inc | 25 +++++++++++-<br>
3 files changed, 72 insertions(+), 2 deletions(-)<br>
<span class=""> create mode 100644 meta/recipes-multimedia/<wbr>gstreamer/files/add-a-target-<wbr>to-compile-tests.patch<br>
create mode 100644 meta/recipes-multimedia/<wbr>gstreamer/files/run-ptest<br>
<br>
diff --git a/meta/recipes-multimedia/<wbr>gstreamer/files/add-a-target-<wbr>to-compile-tests.patch b/meta/recipes-multimedia/<wbr>gstreamer/files/add-a-target-<wbr>to-compile-tests.patch<br>
new file mode 100644<br>
</span>index 0000000..c918bbe<br>
--- /dev/null<br>
+++ b/meta/recipes-multimedia/<wbr>gstreamer/files/add-a-target-<wbr>to-compile-tests.patch<br>
@@ -0,0 +1,46 @@<br>
+From e69e5408f03a2f65045a418af66056<wbr>53c06ec28b Mon Sep 17 00:00:00 2001<br>
<span class="">+From: Anuj Mittal <<a href="mailto:anuj.mittal@intel.com">anuj.mittal@intel.com</a>><br>
+Date: Tue, 27 Feb 2018 09:27:01 +0800<br>
+Subject: [PATCH] add targets for test installation<br>
+<br>
+Targets to make sure tests can be installed and then run on<br>
+the target.<br>
+<br>
+Upstream-Status: Inappropriate [specific to oe setup]<br>
+<br>
+Signed-off-by: Anuj Mittal <<a href="mailto:anuj.mittal@intel.com">anuj.mittal@intel.com</a>><br>
+---<br>
</span>+ tests/check/Makefile.am | 17 +++++++++++++++++<br>
+ 1 file changed, 17 insertions(+)<br>
+<br>
+diff --git a/tests/check/Makefile.am b/tests/check/Makefile.am<br>
+index afc1591..fb5c1c9 100644<br>
+--- a/tests/check/Makefile.am<br>
++++ b/tests/check/Makefile.am<br>
+@@ -175,6 +175,23 @@ noinst_PROGRAMS =<br>
<span class="">+<br>
+ TESTS = $(check_PROGRAMS)<br>
+<br>
++install-ptest: $(TESTS)<br>
++ @$(INSTALL) -d $(DESTDIR)<br>
</span>++ @for dir in `find -maxdepth 1 -type d`; do \<br>
<div><div class="h5">++ if [ -x $$dir/.libs ]; then \<br>
++ $(INSTALL) -d $(DESTDIR)/$$dir; \<br>
++ $(INSTALL_PROGRAM) $$dir/.libs/* $(DESTDIR)/$$dir/; \<br>
++ fi \<br>
++ done<br>
++<br>
++runtests:<br>
++ @for b in $(TESTS); do \<br>
++ if [ -x $$b ]; then \<br>
++ $(AM_TESTS_ENVIRONMENT) $(SHELL) test-driver --test-name "$$b" \<br>
++ --log-file $$b.log --trs-file $$b.trs $$b; \<br>
++ fi \<br>
++ done<br>
++<br>
+ noinst_HEADERS = \<br>
+ gst/capslist.h \<br>
+ gst/struct_arm.h \<br>
+--<br>
+2.7.4<br>
+<br>
diff --git a/meta/recipes-multimedia/<wbr>gstreamer/files/run-ptest b/meta/recipes-multimedia/<wbr>gstreamer/files/run-ptest<br>
new file mode 100644<br>
index 0000000..473d0b6<br>
--- /dev/null<br>
+++ b/meta/recipes-multimedia/<wbr>gstreamer/files/run-ptest<br>
@@ -0,0 +1,3 @@<br>
+#!/bin/sh<br>
+<br>
+make -k runtests<br>
diff --git a/meta/recipes-multimedia/<wbr>gstreamer/gstreamer1.0.inc b/meta/recipes-multimedia/<wbr>gstreamer/gstreamer1.0.inc<br>
</div></div>index c2df1f3..91f5067 100644<br>
<span class="">--- a/meta/recipes-multimedia/<wbr>gstreamer/gstreamer1.0.inc<br>
+++ b/meta/recipes-multimedia/<wbr>gstreamer/gstreamer1.0.inc<br>
@@ -8,7 +8,7 @@ LICENSE = "LGPLv2+"<br>
<br>
DEPENDS = "glib-2.0 glib-2.0-native libcap libxml2 bison-native flex-native"<br>
<br>
-inherit autotools pkgconfig gettext upstream-version-is-even gobject-introspection gtk-doc<br>
+inherit autotools pkgconfig gettext upstream-version-is-even gobject-introspection gtk-doc ptest<br>
<br>
# This way common/m4/introspection.m4 will come first<br>
# (it has a custom INTROSPECTION_INIT macro, and so must be used instead of our common introspection.m4 file)<br>
@@ -18,9 +18,12 @@ SRC_URI_append = " \<br>
file://0001-introspection.m4-<wbr>prefix-pkgconfig-paths-with-<wbr>PKG_CON.patch \<br>
file://gtk-doc-tweaks.patch \<br>
file://0001-gst-<wbr>gstpluginloader.c-when-env-<wbr>var-is-set-do-not-fal.patch \<br>
+ file://add-a-target-to-<wbr>compile-tests.patch \<br>
+ file://run-ptest \<br>
"<br>
<br>
-PACKAGECONFIG ??= ""<br>
+PACKAGECONFIG ??= "${@bb.utils.contains('PTEST_<wbr>ENABLED', '1', 'tests', '', d)} \<br>
+ "<br>
<br>
PACKAGECONFIG[debug] = "--enable-debug,--disable-<wbr>debug"<br>
PACKAGECONFIG[tests] = "--enable-tests,--disable-<wbr>tests"<br>
</span>@@ -59,3 +62,21 @@ do_configure[prefuncs] += "delete_pkg_m4_file"<br>
<span class=""> do_compile_prepend() {<br>
export GIR_EXTRA_LIBS_PATH="${B}/gst/<wbr>.libs:${B}/libs/gst/base/.<wbr>libs"<br>
}<br>
+<br>
+do_compile_ptest() {<br>
+ oe_runmake build-checks<br>
+}<br>
+<br>
+do_install_ptest() {<br>
</span>+ oe_runmake -C tests/check DESTDIR=${D}${PTEST_PATH} install-ptest<br>
<div class="HOEnZb"><div class="h5">+ install -m 644 ${B}/tests/check/Makefile ${D}${PTEST_PATH}<br>
+ install -m 755 ${S}/test-driver ${D}${PTEST_PATH}<br>
+ sed -e 's,--sysroot=${STAGING_DIR_<wbr>TARGET},,g' \<br>
+ -e 's|${DEBUG_PREFIX_MAP}||g' \<br>
+ -e 's:${HOSTTOOLS_DIR}/::g' \<br>
+ -e 's:${RECIPE_SYSROOT_NATIVE}::<wbr>g' \<br>
+ -e 's:${BASE_WORKDIR}/${<wbr>MULTIMACH_TARGET_SYS}::g' \-e 's/^Makefile:/_Makefile:/' \<br>
+ -e 's/^srcdir = \(.*\)/srcdir = ./' -e 's/^top_srcdir = \(.*\)/top_srcdir = ./' \<br>
+ -e 's/^builddir = \(.*\)/builddir = ./' -e 's/^top_builddir = \(.*\)/top_builddir = ./' \<br>
+ -i ${D}${PTEST_PATH}/Makefile<br>
+}<br>
--<br>
2.7.4<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</div></div></blockquote></div><br></div>