<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Mar 20, 2018 18:33, "Martin Jansa" <<a href="mailto:martin.jansa@gmail.com">martin.jansa@gmail.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">see <a href="https://patchwork.openembedded.org/patch/147693/" target="_blank">https://patchwork.<wbr>openembedded.org/patch/147693/</a><div><br></div><div>and updated version (just rebased after other waf related changes were merged):</div><div><a href="http://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/master-submitted&id=3f70b555e3f6033b807e03247605f3fdad868646" target="_blank">http://git.openembedded.org/<wbr>openembedded-core-contrib/<wbr>commit/?h=jansa/master-<wbr>submitted&id=<wbr>3f70b555e3f6033b807e03247605f3<wbr>fdad868646</a><br></div><div><br></div><div>but it was rejected by Ross before, maybe now it won't be when it has Yocto bug number in commit message..</div></div></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Ah started my reply before I saw yours. I thought this looked familiar. IIRC, the other patch was before we changed waf-samba.bbclass to no longer inherit from waf.bbclass.</div><div dir="auto"><br></div><div dir="auto">I didn't remember exactly why the previous one was rejected.... But looking back I think Ross was right that inheriting waf.bbclass without actually having waf should be an error (at some point). I was (perhaps incorrectly) presuming that even if you got the FileNotFoundError, do_configure would still fail. Is that correct? If not I think something strange is going on.</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div></div><div class="elided-text"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 21, 2018 at 12:07 AM, Amanda Brindle <span dir="ltr"><<a href="mailto:amanda.r.brindle@intel.com" target="_blank">amanda.r.brindle@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Before, waf.bbclass would fail to catch FileNotFoundError. Now, it will<br>
catch this error and warn that waf doesn't exist.<br>
<br>
Fixes [YOCTO 12553]<br>
<br>
Signed-off-by: Amanda Brindle <<a href="mailto:amanda.r.brindle@intel.com" target="_blank">amanda.r.brindle@intel.com</a>><br>
---<br>
<span> meta/classes/waf.bbclass | 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
</span>diff --git a/meta/classes/waf.bbclass b/meta/classes/waf.bbclass<br>
index f9a851d..5bd5913 100644<br>
--- a/meta/classes/waf.bbclass<br>
+++ b/meta/classes/waf.bbclass<br>
@@ -15,6 +15,8 @@ python waf_preconfigure() {<br>
d.setVar("WAF_EXTRA_CONF", "--bindir=${bindir} --libdir=${libdir}")<br>
except subprocess.CalledProcessError as e:<br>
bb.warn("Unable to execute waf --version, exit code %d. Assuming waf version without bindir/libdir support." % e.returncode)<br>
+ except FileNotFoundError:<br>
+ bb.warn("waf does not exist in %s" % subsrcdir)<br>
}<br>
<br>
do_configure[prefuncs] += "waf_preconfigure"<br>
<div class="m_2265359007684635114HOEnZb"><div class="m_2265359007684635114h5">--<br>
2.7.4<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openem<wbr>bedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</div></div></blockquote></div><br></div>
</div><br>--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
<br></blockquote></div><br></div></div></div>