<div dir="ltr">And v1 just got merged to master, I'll send v2 with change of the default if other agree.<div><br></div><div>I don't have strong opinion, yes it might be broken, but it was enabled since the <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">update to 20161105 and nobody was complaining and adding PACKAGECONFIG usually shouldn't change the options currently used (I've meant to disable it by default, just because Khem's request).</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 20, 2018 at 12:32 AM, Andre McCurdy <span dir="ltr"><<a href="mailto:armccurdy@gmail.com" target="_blank">armccurdy@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Sat, Mar 17, 2018 at 4:26 AM, Martin Jansa <<a href="mailto:martin.jansa@gmail.com">martin.jansa@gmail.com</a>> wrote:<br>
> * it got enabled by default, but without the dependency on libidn in:<br>
> commit 5997981fa2c22609a88b8cbb595dbf<wbr>7758b2f7c2<br>
> Author: Alexander Kanavin <<a href="mailto:alexander.kanavin@linux.intel.com">alexander.kanavin@linux.<wbr>intel.com</a>><br>
> AuthorDate: Thu Feb 1 20:02:08 2018 +0200<br>
> Subject: iputils: update to 20161105<br>
><br>
> * <a href="https://github.com/iputils/iputils/blob/master/RELNOTES.old" rel="noreferrer" target="_blank">https://github.com/iputils/<wbr>iputils/blob/master/RELNOTES.<wbr>old</a><br>
> mentiones that IDN was enabled by default in:<br>
> [s20160308] and surprisingly the same in [s20150815]<br>
> but there are no release notes for s20151218 version we were using until<br>
> now, don't know how it really relates to [s20150815].<br>
><br>
> * but there are some issues with libidn as described in:<br>
> <a href="https://github.com/iputils/iputils/commit/f3a461603ef4fb7512ade3bdb73fe1824e294547" rel="noreferrer" target="_blank">https://github.com/iputils/<wbr>iputils/commit/<wbr>f3a461603ef4fb7512ade3bdb73fe1<wbr>824e294547</a><br>
> so disable it by default.<br>
><br>
> * fails with:<br>
> | In file included from ping_common.c:1:0:<br>
> | ping.h:39:10: fatal error: idna.h: No such file or directory<br>
> | #include <idna.h><br>
> | ^~~~~~~~<br>
><br>
> * Easiest way to reproduce this failure is to remove libidn from gnutls<br>
> PACKAGECONFIG or to use gnutls which doesn't have libidn PACKAGECONFIG<br>
> at all (like the one in meta-gplv2).<br>
><br>
> * First it leads to following QA issue:<br>
> <a href="http://errors.yoctoproject.org/Errors/Build/53212/" rel="noreferrer" target="_blank">http://errors.yoctoproject.<wbr>org/Errors/Build/53212/</a><br>
> ERROR: iputils-s20161105-r0 do_package_qa: QA Issue: iputils-ping rdepends on libidn, but it isn't a build dependency, missing libidn in DEPENDS or PACKAGECONFIG? [build-deps]<br>
> ERROR: iputils-s20161105-r0 do_package_qa: QA Issue: iputils-traceroute6 rdepends on libidn, but it isn't a build dependency, missing libidn in DEPENDS or PACKAGECONFIG? [build-deps]<br>
> ERROR: iputils-s20161105-r0 do_package_qa: QA run found fatal errors.<br>
> Please consider fixing them.<br>
> ERROR: iputils-s20161105-r0 do_package_qa: Function failed:<br>
> do_package_qa<br>
> ERROR: Logfile of failure stored in: /OE/build/oe-core/tmp-glibc/<wbr>work/core2-64-oe-linux/<wbr>iputils/s20161105-r0/temp/log.<wbr>do_package_qa.7627<br>
> ERROR: Task (/OE/build/oe-core/<wbr>openembedded-core/meta/<wbr>recipes-extended/iputils/<wbr>iputils_s20161105.bb:do_<wbr>package_qa) failed with exit code '1'<br>
><br>
> * But if you cleansstate iputils as well (after removing libidn from<br>
> gnutls PACKAGECONFIG) to empty iputils RSS, then you get the error about<br>
> missing idna.h:<br>
> <a href="http://errors.yoctoproject.org/Errors/Build/53213/" rel="noreferrer" target="_blank">http://errors.yoctoproject.<wbr>org/Errors/Build/53213/</a><br>
><br>
> * Adding the libidn dependency explicitly in iputils recipe fixes the<br>
> issue.<br>
><br>
> Signed-off-by: Martin Jansa <<a href="mailto:Martin.Jansa@gmail.com">Martin.Jansa@gmail.com</a>><br>
> ---<br>
> meta/recipes-extended/iputils/<a href="http://iputils_s20161105.bb" rel="noreferrer" target="_blank"><wbr>iputils_s20161105.bb</a> | 5 ++++-<br>
> 1 file changed, 4 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/meta/recipes-extended/<wbr>iputils/<a href="http://iputils_s20161105.bb" rel="noreferrer" target="_blank">iputils_s20161105.bb</a> b/meta/recipes-extended/<wbr>iputils/<a href="http://iputils_s20161105.bb" rel="noreferrer" target="_blank">iputils_s20161105.bb</a><br>
> index ad7dbc4d4a..0125739b03 100644<br>
> --- a/meta/recipes-extended/<wbr>iputils/<a href="http://iputils_s20161105.bb" rel="noreferrer" target="_blank">iputils_s20161105.bb</a><br>
> +++ b/meta/recipes-extended/<wbr>iputils/<a href="http://iputils_s20161105.bb" rel="noreferrer" target="_blank">iputils_s20161105.bb</a><br>
> @@ -23,8 +23,11 @@ UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>s\d+)"<br>
><br>
> EXTRA_OEMAKE = "-e MAKEFLAGS="<br>
><br>
> +PACKAGECONFIG ?= ""<br>
<br>
</div></div>It looks like mut (and now master-next) have picked up v1 of this<br>
patch, where libidn is enabled by default.<br>
<div class="HOEnZb"><div class="h5"><br>
> +PACKAGECONFIG[libidn] = "USE_IDN=yes,USE_IDN=no,<wbr>libidn"<br>
> +<br>
> do_compile () {<br>
> - oe_runmake 'CC=${CC} -D_GNU_SOURCE' VPATH="${STAGING_LIBDIR}:${<wbr>STAGING_DIR_HOST}/${base_<wbr>libdir}" all<br>
> + oe_runmake 'CC=${CC} -D_GNU_SOURCE' VPATH="${STAGING_LIBDIR}:${<wbr>STAGING_DIR_HOST}/${base_<wbr>libdir}" ${PACKAGECONFIG_CONFARGS} all<br>
> }<br>
><br>
> do_install () {<br>
> --<br>
> 2.15.1<br>
><br>
</div></div><span class="HOEnZb"><font color="#888888">> --<br>
> ______________________________<wbr>_________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></blockquote></div><br></div>