<div dir="ltr">This item doesn't appear to have a follow-up.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 4, 2017 at 11:10 AM, Burton, Ross <span dir="ltr"><<a href="mailto:ross.burton@intel.com" target="_blank">ross.burton@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class="">On 3 October 2017 at 19:17, Peter Kjellerstedt <span dir="ltr"><<a href="mailto:peter.kjellerstedt@axis.com" target="_blank">peter.kjellerstedt@axis.com</a>></span> wrote:<br></span><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><span class="">> + # Take shared lock since we're only reading, not writing<br>
> lf = bb.utils.lockfile(bb.data.expa<wbr>nd("${PACKAGELOCK}", d))<br>
<br>
Here, however, it is not changed, even though a comment is added to<br>
say that it is. Was this intentional, or just an oversight?<br>
<br></span><span class="">> + # Take shared lock since we're only reading, not writing<br>
> lf = bb.utils.lockfile(bb.data.expa<wbr>nd("${PACKAGELOCK}", d))<br>
<br>
Here again a comment is added, but the code is not changed to match.</span></blockquote><div><br></div><div>I'm no expert on this piece of code but that definitely looks like an oversight.</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Also, what is the ${PACKAGELOCK} lock file actually protecting? With<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
the exception of the two questionable cases above, I cannot see that<br>
the lock is taken privately anywhere else. And since it looks as the<br>
code in package_do_shlibs() and package_do_pkgconfig() is not what<br>
needs protection (based on the added comments above), what is?<br></blockquote><div><br></div></span><div>Good point. The sstate locks are also shared.</div><div><br></div><div>Richard was involved in all of these changes so lets wait for him to return from his holiday...</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Ross</div><div> </div></font></span></div></div></div>
<br>--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
<br></blockquote></div><br></div>