<div dir="ltr">The anonymous python bellow this chunk limits this whole recipe only for nativesdk (I don't know why it uses BBCLASSEXTEND + anonymous python instead of just inheritting nativesdk directly from nativesdk-libxcrypt recipe to make it more obvious ...).</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 9, 2018 at 11:59 PM, Khem Raj <span dir="ltr"><<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 4/9/18 12:51 AM, Martin Jansa wrote:<br>
> * add it to allow older distributions e.g. Ubuntu 14.04 with gcc 4.8<br>
> to build this, otherwise it fails with:<br>
> ../git/gen-des-tables.c: In function 'write_table_u8':<br>
> ../git/gen-des-tables.c:307:3: error: 'for' loop initial declarations are only allowed in C99 mode<br>
> for (size_t i = 0; i < m; i++)<br>
> ^<br>
><br>
> Signed-off-by: Martin Jansa <<a href="mailto:Martin.Jansa@gmail.com">Martin.Jansa@gmail.com</a>><br>
> ---<br>
> meta/recipes-core/libxcrypt/<a href="http://libxcrypt_4.0.0.bb" rel="noreferrer" target="_blank">li<wbr>bxcrypt_4.0.0.bb</a> | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/meta/recipes-core/libxcrypt/<a href="http://libxcrypt_4.0.0.bb" rel="noreferrer" target="_blank"><wbr>libxcrypt_4.0.0.bb</a> b/meta/recipes-core/libxcrypt/<a href="http://libxcrypt_4.0.0.bb" rel="noreferrer" target="_blank"><wbr>libxcrypt_4.0.0.bb</a><br>
> index b1982c1991..a1be4be7ef 100644<br>
> --- a/meta/recipes-core/libxcrypt/<a href="http://libxcrypt_4.0.0.bb" rel="noreferrer" target="_blank"><wbr>libxcrypt_4.0.0.bb</a><br>
> +++ b/meta/recipes-core/libxcrypt/<a href="http://libxcrypt_4.0.0.bb" rel="noreferrer" target="_blank"><wbr>libxcrypt_4.0.0.bb</a><br>
> @@ -20,7 +20,7 @@ FILES_${PN} = "${libdir}/libcrypt*.so.* ${libdir}/libcrypt-*.so ${libdir}/libowc<br>
><br>
> S = "${WORKDIR}/git"<br>
><br>
> -BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE}"<br>
> +BUILD_CPPFLAGS = "-I${STAGING_INCDIR_NATIVE} -std=gnu99"<br>
<br>
</span>This might change behaviour with gcc5+ e.g. where default is gnu11<br>
in anycase, I think if we could limit this to native version can limit<br>
the impact.<br>
<div class="HOEnZb"><div class="h5"><br>
> TARGET_CPPFLAGS = "-I${STAGING_DIR_TARGET}${<wbr>includedir}"<br>
><br>
> python () {<br>
><br>
<br>
</div></div></blockquote></div><br></div>