<div dir="ltr">Hi Martin,<div><br></div><div>all meta-oe patches need to go to openembedded-devel ML.</div><div><br></div><div>Thanks</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 8, 2018 at 8:49 PM, Martin Kelly <span dir="ltr">&lt;<a href="mailto:mkelly@xevo.com" target="_blank">mkelly@xevo.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This version has a ublox plugin for expanded modem support. The underlying issue<br>
that enum-conversion.patch fixes appears to already have been fixed upstream, so<br>
we can drop the patch.<br>
<br>
Signed-off-by: Martin Kelly &lt;<a href="mailto:mkelly@xevo.com">mkelly@xevo.com</a>&gt;<br>
---<br>
 .../modemmanager/modemmanager/<wbr>enum-conversion.patch | 21 ---------------------<br>
 ...<a href="http://odemmanager_1.6.4.bb" rel="noreferrer" target="_blank">odemmanager_1.6.4.bb</a> =&gt; <a href="http://modemmanager_1.7.991.bb" rel="noreferrer" target="_blank">modemmanager_1.7.991.bb</a>} |  9 ++++-----<br>
 2 files changed, 4 insertions(+), 26 deletions(-)<br>
 delete mode 100644 meta-oe/recipes-connectivity/<wbr>modemmanager/modemmanager/<wbr>enum-conversion.patch<br>
 rename meta-oe/recipes-connectivity/<wbr>modemmanager/{<a href="http://modemmanager_1.6.4.bb" rel="noreferrer" target="_blank">modemmanager_1.<wbr>6.4.bb</a> =&gt; <a href="http://modemmanager_1.7.991.bb" rel="noreferrer" target="_blank">modemmanager_1.7.991.bb</a>} (88%)<br>
<br>
diff --git a/meta-oe/recipes-<wbr>connectivity/modemmanager/<wbr>modemmanager/enum-conversion.<wbr>patch b/meta-oe/recipes-<wbr>connectivity/modemmanager/<wbr>modemmanager/enum-conversion.<wbr>patch<br>
deleted file mode 100644<br>
index a3fb0f3eb..000000000<br>
--- a/meta-oe/recipes-<wbr>connectivity/modemmanager/<wbr>modemmanager/enum-conversion.<wbr>patch<br>
+++ /dev/null<br>
@@ -1,21 +0,0 @@<br>
-Fixes errors found bt Clang<br>
-<br>
-| ../../ModemManager-1.6.4/src/<wbr>mm-bearer-qmi.c:774:50: error: implicit conversion from enumeration type &#39;MMBearerStatus&#39; to different enumeration type &#39;MMBearerConnectionStatus&#39; [-Werror,-Wenum-conversion]<br>
-|         MMBearerConnectionStatus bearer_status = mm_base_bearer_get_status (MM_BASE_BEARER (self));<br>
-|                                  ~~~~~~~~~~~~~   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<wbr>~~~~~~~~~~~~~~~~~~~<br>
-| 1 error generated.<br>
-<br>
-<br>
-Index: ModemManager-1.6.4/src/mm-<wbr>bearer-qmi.c<br>
-=============================<wbr>==============================<wbr>========<br>
---- ModemManager-1.6.4.orig/src/<wbr>mm-bearer-qmi.c<br>
-+++ ModemManager-1.6.4/src/mm-<wbr>bearer-qmi.c<br>
-@@ -771,7 +771,7 @@ packet_service_status_<wbr>indication_cb (Qmi<br>
-             &amp;connection_status,<br>
-             NULL,<br>
-             NULL)) {<br>
--        MMBearerConnectionStatus bearer_status = mm_base_bearer_get_status (MM_BASE_BEARER (self));<br>
-+        MMBearerConnectionStatus bearer_status = (MMBearerConnectionStatus)mm_<wbr>base_bearer_get_status (MM_BASE_BEARER (self));<br>
- <br>
-         if (connection_status == QMI_WDS_CONNECTION_STATUS_<wbr>DISCONNECTED &amp;&amp;<br>
-             bearer_status != MM_BEARER_CONNECTION_STATUS_<wbr>DISCONNECTED &amp;&amp;<br>
diff --git a/meta-oe/recipes-<wbr>connectivity/modemmanager/<a href="http://modemmanager_1.6.4.bb" rel="noreferrer" target="_blank">mode<wbr>mmanager_1.6.4.bb</a> b/meta-oe/recipes-<wbr>connectivity/modemmanager/<a href="http://modemmanager_1.7.991.bb" rel="noreferrer" target="_blank">mode<wbr>mmanager_1.7.991.bb</a><br>
similarity index 88%<br>
rename from meta-oe/recipes-connectivity/<wbr>modemmanager/<a href="http://modemmanager_1.6.4.bb" rel="noreferrer" target="_blank">modemmanager_1.6.<wbr>4.bb</a><br>
rename to meta-oe/recipes-connectivity/<wbr>modemmanager/<a href="http://modemmanager_1.7.991.bb" rel="noreferrer" target="_blank">modemmanager_1.7.<wbr>991.bb</a><br>
index e60cd4b74..4f9400169 100644<br>
--- a/meta-oe/recipes-<wbr>connectivity/modemmanager/<a href="http://modemmanager_1.6.4.bb" rel="noreferrer" target="_blank">mode<wbr>mmanager_1.6.4.bb</a><br>
+++ b/meta-oe/recipes-<wbr>connectivity/modemmanager/<a href="http://modemmanager_1.7.991.bb" rel="noreferrer" target="_blank">mode<wbr>mmanager_1.7.991.bb</a><br>
@@ -11,11 +11,10 @@ inherit gnomebase gettext systemd vala gobject-introspection bash-completion<br>
<br>
 DEPENDS = &quot;glib-2.0 libgudev dbus-glib intltool-native&quot;<br>
<br>
-SRC_URI = &quot;<a href="http://www.freedesktop.org/software/ModemManager/ModemManager-${PV}.tar.xz" rel="noreferrer" target="_blank">http://www.freedesktop.org/<wbr>software/ModemManager/<wbr>ModemManager-${PV}.tar.xz</a> \<br>
-           file://enum-conversion.patch \<br>
-&quot;<br>
-SRC_URI[md5sum] = &quot;<wbr>06488186c7dd53f8104183b86f7a15<wbr>68&quot;<br>
-SRC_URI[sha256sum] = &quot;<wbr>cdd5b4cb1e4d7643643a28ccbfc4bb<wbr>354bfa9cb89a77ea160ebdf7926171<wbr>c668&quot;<br>
+SRC_URI = &quot;<a href="http://www.freedesktop.org/software/ModemManager/ModemManager-${PV}.tar.xz" rel="noreferrer" target="_blank">http://www.freedesktop.org/<wbr>software/ModemManager/<wbr>ModemManager-${PV}.tar.xz</a>&quot;<br>
+<br>
+SRC_URI[md5sum] = &quot;<wbr>4efe6a240cef212bf8855c95424e7c<wbr>7f&quot;<br>
+SRC_URI[sha256sum] = &quot;<wbr>4e366243bd4983f2e6efe35cb901cf<wbr>5da51939307b5d6299fe622a9fcf41<wbr>1745&quot;<br>
<br>
 S = &quot;${WORKDIR}/ModemManager-${PV}<wbr>&quot;<br>
<span class="HOEnZb"><font color="#888888"> <br>
-- <br>
2.11.0<br>
<br>
-- <br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></blockquote></div><br></div>