<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoPlainText">Hi OE-Core members,<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">As per the wiki notes, This is a reminder and re-submission again the same patch posted some weeks before.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<div style="mso-element:para-border-div;border:none;border-left:solid windowtext 1.0pt;padding:0in 0in 0in 4.0pt">
<p class="MsoPlainText" style="border:none;padding:0in"><a href="https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded">https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded</a> <o:p></o:p></p>
<p class="MsoPlainText" style="border:none;padding:0in">If your patch has not had any feedback after a few days it may have been missed or the appropriate reviewers may not currently be around; it is perfectly fine to reply to it yourself with a "ping" / reminder
request for feedback. NOTE: patch review for feature / recipe upgrade patches will likely be delayed during a feature freeze because these types of patches aren't merged during this time - you may have to wait until after the freeze is lifted.<o:p></o:p></p>
</div>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">I have noted that the patch not available in master and may have been missed.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Mit freundlichen Grüßen / Best regards<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Rajendran Vignesh<o:p></o:p></p>
<p class="MsoPlainText">RBEI/ECF33 <o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Tel. +91 422 67-65103 <o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">-----Original Message-----<br>
From: Vignesh Rajendran (RBEI/ECF3) <br>
Sent: Thursday, May 17, 2018 11:20 AM<br>
To: openembedded-core@lists.openembedded.org<br>
Cc: Vignesh Rajendran (RBEI/ECF3) <Vignesh.Rajendran@in.bosch.com><br>
Subject: [meta-oe][PATCH] package.bbclass: provide debug sources in externalsrc -dbg packages</p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">The recipes which are using externalsrc method doesn't contain the<o:p></o:p></p>
<p class="MsoPlainText">debug sources in their -dbg packages.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Add a handling in copydebugsources function to copy the debugsources for<o:p></o:p></p>
<p class="MsoPlainText">externalsrc -dbg packages.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Signed-off-by: Vignesh Rajendran <<a href="mailto:vignesh.rajendran@in.bosch.com"><span style="color:windowtext;text-decoration:none">vignesh.rajendran@in.bosch.com</span></a>><o:p></o:p></p>
<p class="MsoPlainText">---<o:p></o:p></p>
<p class="MsoPlainText">meta/classes/externalsrc.bbclass | 3 +++<o:p></o:p></p>
<p class="MsoPlainText">meta/classes/package.bbclass | 12 ++++++++++--<o:p></o:p></p>
<p class="MsoPlainText">2 files changed, 13 insertions(+), 2 deletions(-)<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass<o:p></o:p></p>
<p class="MsoPlainText">index c9f5cf7..135670d 100644<o:p></o:p></p>
<p class="MsoPlainText">--- a/meta/classes/externalsrc.bbclass<o:p></o:p></p>
<p class="MsoPlainText">+++ b/meta/classes/externalsrc.bbclass<o:p></o:p></p>
<p class="MsoPlainText">@@ -129,6 +129,9 @@ python () {<o:p></o:p></p>
<p class="MsoPlainText"> d.setVar('CONFIGURESTAMPFILE', configstamp)<o:p></o:p></p>
<p class="MsoPlainText"> d.setVar('STAMP', '${STAMPS_DIR}/work-shared/${PN}/${EXTENDPE}${PV}-${PR}')<o:p></o:p></p>
<p class="MsoPlainText"> d.setVar('STAMPCLEAN', '${STAMPS_DIR}/work-shared/${PN}/*-*')<o:p></o:p></p>
<p class="MsoPlainText">+<o:p></o:p></p>
<p class="MsoPlainText">+ # set DEBUG_PREFIX_MAP to external source path<o:p></o:p></p>
<p class="MsoPlainText">+ d.appendVar("DEBUG_PREFIX_MAP", "-fdebug-prefix-map=${EXTERNALSRC}=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}")<o:p></o:p></p>
<p class="MsoPlainText">}<o:p></o:p></p>
<p class="MsoPlainText"><o:p></o:p></p>
<p class="MsoPlainText"> python externalsrc_configure_prefunc() {<o:p></o:p></p>
<p class="MsoPlainText">diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass<o:p></o:p></p>
<p class="MsoPlainText">index edeffa9..f071a2e 100644<o:p></o:p></p>
<p class="MsoPlainText">--- a/meta/classes/package.bbclass<o:p></o:p></p>
<p class="MsoPlainText">+++ b/meta/classes/package.bbclass<o:p></o:p></p>
<p class="MsoPlainText">@@ -420,6 +420,7 @@ def copydebugsources(debugsrcdir, d):<o:p></o:p></p>
<p class="MsoPlainText"> workdir = d.getVar("WORKDIR")<o:p></o:p></p>
<p class="MsoPlainText"> workparentdir = os.path.dirname(os.path.dirname(workdir))<o:p></o:p></p>
<p class="MsoPlainText"> workbasedir = os.path.basename(os.path.dirname(workdir)) + "/" + os.path.basename(workdir)<o:p></o:p></p>
<p class="MsoPlainText">+ externalsrc = d.getVar('EXTERNALSRC', True)<o:p></o:p></p>
<p class="MsoPlainText"><o:p></o:p></p>
<p class="MsoPlainText"> # If build path exists in sourcefile, it means toolchain did not use<o:p></o:p></p>
<p class="MsoPlainText"> # -fdebug-prefix-map to compile<o:p></o:p></p>
<p class="MsoPlainText">@@ -444,9 +445,16 @@ def copydebugsources(debugsrcdir, d):<o:p></o:p></p>
<p class="MsoPlainText"> processdebugsrc += "fgrep -zw '%s' | "<o:p></o:p></p>
<p class="MsoPlainText"> # Remove prefix in the source paths<o:p></o:p></p>
<p class="MsoPlainText"> processdebugsrc += "sed 's#%s##g' | "<o:p></o:p></p>
<p class="MsoPlainText">- processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s' 2>/dev/null)"<o:p></o:p></p>
<p class="MsoPlainText">+ # handle external sources to provide sources in -dbg packages<o:p></o:p></p>
<p class="MsoPlainText">+ if externalsrc:<o:p></o:p></p>
<p class="MsoPlainText">+ localsrc_prefix = "/usr/src/debug/"<o:p></o:p></p>
<p class="MsoPlainText">+ processdebugsrc += "sed 's#%s/##g' | "<o:p></o:p></p>
<p class="MsoPlainText">+ processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s/%s' 2>/dev/null)"<o:p></o:p></p>
<p class="MsoPlainText">+ cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workbasedir, externalsrc, dvar, debugsrcdir, workbasedir)<o:p></o:p></p>
<p class="MsoPlainText">+ else:<o:p></o:p></p>
<p class="MsoPlainText">+ processdebugsrc += "(cd '%s' ; cpio -pd0mlL --no-preserve-owner '%s%s' 2>/dev/null)"<o:p></o:p></p>
<p class="MsoPlainText">+ cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workparentdir, dvar, debugsrcdir)<o:p></o:p></p>
<p class="MsoPlainText"><o:p></o:p></p>
<p class="MsoPlainText">- cmd = processdebugsrc % (sourcefile, workbasedir, localsrc_prefix, workparentdir, dvar, debugsrcdir)<o:p></o:p></p>
<p class="MsoPlainText"> (retval, output) = oe.utils.getstatusoutput(cmd)<o:p></o:p></p>
<p class="MsoPlainText"> # Can "fail" if internal headers/transient sources are attempted<o:p></o:p></p>
<p class="MsoPlainText"> #if retval:<o:p></o:p></p>
<p class="MsoPlainText">-- <o:p></o:p></p>
<p class="MsoPlainText">2.7.4<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
</div>
</body>
</html>