<div><div dir="auto">Thanks, I'll check it out once I am near a computer </div></div><div><br><div class="gmail_quote"><div>On Mon, May 21, 2018 at 7:55 AM Burton, Ross <<a href="mailto:ross.burton@intel.com">ross.burton@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">My patch metrics[1] will love you if you can replace that patch with a<br>
backport...<br>
<br>
Ross<br>
[1] <a href="http://www.burtonini.com/temp/status/" rel="noreferrer" target="_blank">http://www.burtonini.com/temp/status/</a><br>
<br>
On 21 May 2018 at 14:37, Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>> wrote:<br>
> Patch it to build with clang<br>
><br>
> clang 6.0+ driver can correclty detect corss gold linker now<br>
><br>
> Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br>
> ---<br>
> V2:<br>
> - Remove code to disabel gold with clang instead of commenting, and descrive the removal<br>
><br>
> .../0012-soup-Forward-declare-URL-class.patch | 31 +++++++++++++++++++<br>
> ...<a href="http://ebkitgtk_2.20.1.bb" rel="noreferrer" target="_blank">ebkitgtk_2.20.1.bb</a> => <a href="http://webkitgtk_2.20.2.bb" rel="noreferrer" target="_blank">webkitgtk_2.20.2.bb</a>} | 6 ++--<br>
> 2 files changed, 34 insertions(+), 3 deletions(-)<br>
> create mode 100644 meta/recipes-sato/webkit/webkitgtk/0012-soup-Forward-declare-URL-class.patch<br>
> rename meta/recipes-sato/webkit/{<a href="http://webkitgtk_2.20.1.bb" rel="noreferrer" target="_blank">webkitgtk_2.20.1.bb</a> => <a href="http://webkitgtk_2.20.2.bb" rel="noreferrer" target="_blank">webkitgtk_2.20.2.bb</a>} (96%)<br>
><br>
> diff --git a/meta/recipes-sato/webkit/webkitgtk/0012-soup-Forward-declare-URL-class.patch b/meta/recipes-sato/webkit/webkitgtk/0012-soup-Forward-declare-URL-class.patch<br>
> new file mode 100644<br>
> index 0000000000..c689117650<br>
> --- /dev/null<br>
> +++ b/meta/recipes-sato/webkit/webkitgtk/0012-soup-Forward-declare-URL-class.patch<br>
> @@ -0,0 +1,31 @@<br>
> +From 59f6903ad96f3213f248b672d5fd526cc0d666ce Mon Sep 17 00:00:00 2001<br>
> +From: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br>
> +Date: Sun, 20 May 2018 14:28:27 -0700<br>
> +Subject: [PATCH] soup: Forward declare URL class<br>
> +<br>
> +This helps getting away with compiler errors seen with clang<br>
> +<br>
> +/mnt/a/oe/workspace/sources/webkitgtk/Source/WebCore/platform/network/soup/SoupNetworkSession.h:68:62:<br>
> +error: unknown type name 'URL'<br>
> + static std::optional<ResourceError> checkTLSErrors(const URL&,<br>
> +GTlsCertificate*, GTlsCertificateFlags);<br>
> + ^<br>
> +Upstream-Status: Pending<br>
> +<br>
> +Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br>
> +---<br>
> + Source/WebCore/platform/network/soup/SoupNetworkSession.h | 1 +<br>
> + 1 file changed, 1 insertion(+)<br>
> +<br>
> +diff --git a/Source/WebCore/platform/network/soup/SoupNetworkSession.h b/Source/WebCore/platform/network/soup/SoupNetworkSession.h<br>
> +index 03bd72ba..7ca8792d 100644<br>
> +--- a/Source/WebCore/platform/network/soup/SoupNetworkSession.h<br>
> ++++ b/Source/WebCore/platform/network/soup/SoupNetworkSession.h<br>
> +@@ -43,6 +43,7 @@ namespace WebCore {<br>
> +<br>
> + class CertificateInfo;<br>
> + class ResourceError;<br>
> ++class URL;<br>
> + struct SoupNetworkProxySettings;<br>
> +<br>
> + class SoupNetworkSession {<br>
> diff --git a/meta/recipes-sato/webkit/<a href="http://webkitgtk_2.20.1.bb" rel="noreferrer" target="_blank">webkitgtk_2.20.1.bb</a> b/meta/recipes-sato/webkit/<a href="http://webkitgtk_2.20.2.bb" rel="noreferrer" target="_blank">webkitgtk_2.20.2.bb</a><br>
> similarity index 96%<br>
> rename from meta/recipes-sato/webkit/<a href="http://webkitgtk_2.20.1.bb" rel="noreferrer" target="_blank">webkitgtk_2.20.1.bb</a><br>
> rename to meta/recipes-sato/webkit/<a href="http://webkitgtk_2.20.2.bb" rel="noreferrer" target="_blank">webkitgtk_2.20.2.bb</a><br>
> index 360ab8e69b..a68a69f43c 100644<br>
> --- a/meta/recipes-sato/webkit/<a href="http://webkitgtk_2.20.1.bb" rel="noreferrer" target="_blank">webkitgtk_2.20.1.bb</a><br>
> +++ b/meta/recipes-sato/webkit/<a href="http://webkitgtk_2.20.2.bb" rel="noreferrer" target="_blank">webkitgtk_2.20.2.bb</a><br>
> @@ -21,10 +21,11 @@ SRC_URI = "<a href="http://www.webkitgtk.org/releases/$%7BBPN%7D-$%7BPV%7D.tar.xz" rel="noreferrer" target="_blank">http://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz</a> \<br>
> file://0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch \<br>
> file://0001-Fix-build-with-musl.patch \<br>
> file://detect-gstreamer-gl.patch \<br>
> + file://0012-soup-Forward-declare-URL-class.patch \<br>
> "<br>
><br>
> -SRC_URI[md5sum] = "0cd9b9ae1f48c04de5314f77806eceb4"<br>
> -SRC_URI[sha256sum] = "43e43285fa4e393080cc4fbd5ad8644749a75b1e0b811b230b63ae56806c8959"<br>
> +SRC_URI[md5sum] = "3fdda40dc10eb2a00d5fba4219b83967"<br>
> +SRC_URI[sha256sum] = "dffe93a241f03f1c73b369f4e323e4d8f12e39d33d5515948cbf454ca4b526e2"<br>
><br>
> inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc<br>
><br>
> @@ -85,7 +86,6 @@ EXTRA_OECMAKE_append_armv4 = " -DENABLE_JIT=OFF "<br>
> EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "<br>
> EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF "<br>
> EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF "<br>
> -EXTRA_OECMAKE_append_toolchain-clang = " -DUSE_LD_GOLD=OFF "<br>
><br>
> EXTRA_OECMAKE_append_aarch64 = " -DWTF_CPU_ARM64_CORTEXA53=ON"<br>
><br>
> --<br>
> 2.17.0<br>
><br>
> --<br>
> _______________________________________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div></div>