<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 24, 2018 at 8:20 PM, Alistair Francis <span dir="ltr"><<a href="mailto:alistair23@gmail.com" target="_blank">alistair23@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, May 24, 2018 at 4:30 PM, Alistair Francis <<a href="mailto:alistair23@gmail.com">alistair23@gmail.com</a>> wrote:<br>
> On Thu, May 24, 2018 at 5:27 AM, Bruce Ashfield<br>
> <<a href="mailto:bruce.ashfield@gmail.com">bruce.ashfield@gmail.com</a>> wrote:<br>
>><br>
>><br>
>> On Thu, May 24, 2018 at 5:45 AM, Anuj Mittal <<a href="mailto:anuj.mittal@intel.com">anuj.mittal@intel.com</a>> wrote:<br>
>>><br>
>>> On 05/03/2018 04:49 AM, Alistair Francis wrote:<br>
>>> > +KERNEL_FEATURES_append = " ${@bb.utils.contains('MACHINE_<wbr>FEATURES',<br>
>>> > 'numa', 'features/numa/numa.scc', '', d)}"<br>
>>><br>
>>> Isn't this enough to pull in the required configuration from<br>
>>><br>
>>><br>
>>> <a href="https://git.yoctoproject.org/cgit/cgit.cgi/yocto-kernel-cache/tree/features/numa/numa.cfg" rel="noreferrer" target="_blank">https://git.yoctoproject.org/<wbr>cgit/cgit.cgi/yocto-kernel-<wbr>cache/tree/features/numa/numa.<wbr>cfg</a><br>
>>><br>
>>> If numa.cfg is missing something in yocto-kernel-cache that should be<br>
>>> applied to all machines, perhaps these configurations should be added<br>
>>> there?<br>
>><br>
>><br>
>> Correct.<br>
>><br>
>> I wanted to run with this patch myself before sending feedback. In fact, I<br>
>> think that the kernel-cache<br>
>> numa config fragments are being used anyway. But since I'm traveling, I<br>
>> haven't gotten to that yet.<br>
>><br>
>> Alistair: if you drop your fragment, are you actually getting a failure<br>
>> during the kernel meta data task ?<br>
><br>
> From memory I didn't see a failure, but I didn't see the NUMA support<br>
> in the kernel.<br>
><br>
> I'll run a test now.<br>
<br>
</span>It looks like the fragment isn't required.<br>
<br>
Do you want me to resend the patch with the config fragment removed or<br>
is something for this already in the works?<br></blockquote><div><br></div><div>Go ahead and send the v2. You can add my Acked-by: Bruce Ashfield <<a href="mailto:bruce.ashfield@windriver.com">bruce.ashfield@windriver.com</a>></div><div>on v2 to show that I've reviewed it.<br></div><div><br></div><div>Cheers,</div><div><br></div><div>Bruce</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
Alistair<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
><br>
> Alistair<br>
><br>
>><br>
>> I will resubmit my patches shortly that allow any kernel to leverage the<br>
>> shared config frags, so<br>
>> using the ones in the kernel cache definitely makes sense.<br>
>><br>
>> Bruce<br>
>><br>
>><br>
>>><br>
>>> --<br>
>>> ______________________________<wbr>_________________<br>
>>> Openembedded-core mailing list<br>
>>> <a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
>>> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
>><br>
>><br>
>><br>
>><br>
>> --<br>
>> "Thou shalt not follow the NULL pointer, for chaos and madness await thee at<br>
>> its end"<br>
>><br>
>> --<br>
>> ______________________________<wbr>_________________<br>
>> Openembedded-core mailing list<br>
>> <a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
>> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
>><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</div>
</div></div>