<div dir="ltr">Hi, Andre:<div><br></div><div>Thanks for the review, will do that.</div><div><br></div><div>//Ming Liu</div></div><div class="gmail_extra"><br><div class="gmail_quote">2018-05-31 20:00 GMT+02:00 Andre McCurdy <span dir="ltr"><<a href="mailto:armccurdy@gmail.com" target="_blank">armccurdy@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, May 31, 2018 at 1:55 AM, <<a href="mailto:liu.ming50@gmail.com">liu.ming50@gmail.com</a>> wrote:<br>
> From: Ming Liu <<a href="mailto:liu.ming50@gmail.com">liu.ming50@gmail.com</a>><br>
><br>
> It should be KERNEL_IMAGETYPE rather than KERNEL_IMAGETYPE_FOR_MAKE to<br>
<br>
</span>KERNEL_IMAGETYPE is a legacy variable, in the process of being<br>
replaced by KERNEL_IMAGETYPES. You should probably use the new<br>
variable if possible.<br>
<div class="HOEnZb"><div class="h5"><br>
> be handled in do_install and do_deploy tasks, since we are having some<br>
> special logic in kernel-uimage.bbclass and kernel-fitimage.bbclass to<br>
> replace the real kernel image types during do_compile, like:<br>
> in kernel-uimage.bbclass: uImage -> vmlinux<br>
> in kernel-fitimage.bbclass: fitImage -> Image/bzImage/zImage...<br>
><br>
> but the final images to be installed/deployed should still be uImage or<br>
> fitImage.<br>
><br>
> Signed-off-by: Ming Liu <<a href="mailto:liu.ming50@gmail.com">liu.ming50@gmail.com</a>><br>
> ---<br>
> meta/classes/kernel-<wbr>devicetree.bbclass | 4 ++--<br>
> 1 file changed, 2 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/meta/classes/kernel-<wbr>devicetree.bbclass b/meta/classes/kernel-<wbr>devicetree.bbclass<br>
> index 4f80cc6..04e6321 100644<br>
> --- a/meta/classes/kernel-<wbr>devicetree.bbclass<br>
> +++ b/meta/classes/kernel-<wbr>devicetree.bbclass<br>
> @@ -63,7 +63,7 @@ do_install_append() {<br>
> DTB_PATH=`get_real_dtb_path_<wbr>in_kernel "${DTB}"`<br>
> DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`<br>
> install -m 0644 ${DTB_PATH} ${D}/${KERNEL_IMAGEDEST}/${<wbr>DTB_BASE_NAME}.${DTB_EXT}<br>
> - for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do<br>
> + for type in ${KERNEL_IMAGETYPE}; do<br>
> symlink_name=${type}"-"${<wbr>KERNEL_IMAGE_SYMLINK_NAME}<br>
> DTB_SYMLINK_NAME=`echo ${symlink_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}<wbr>/g"`<br>
> ln -sf ${DTB_BASE_NAME}.${DTB_EXT} ${D}/${KERNEL_IMAGEDEST}/<wbr>devicetree-${DTB_SYMLINK_NAME}<wbr>.${DTB_EXT}<br>
> @@ -82,7 +82,7 @@ do_deploy_append() {<br>
> DTB=`normalize_dtb "${DTB}"`<br>
> DTB_EXT=${DTB##*.}<br>
> DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`<br>
> - for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do<br>
> + for type in ${KERNEL_IMAGETYPE}; do<br>
> base_name=${type}"-"${KERNEL_<wbr>IMAGE_BASE_NAME}<br>
> symlink_name=${type}"-"${<wbr>KERNEL_IMAGE_SYMLINK_NAME}<br>
> DTB_NAME=`echo ${base_name} | sed "s/${MACHINE}/${DTB_BASE_NAME}<wbr>/g"`<br>
> --<br>
> 2.7.4<br>
><br>
</div></div><span class="HOEnZb"><font color="#888888">> --<br>
> ______________________________<wbr>_________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></blockquote></div><br></div>