<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Done.<br>
V2 will be sent out soon.<br>
<br>
Thanks,<br>
Chen Qi<br>
<br>
On 05/31/2018 10:57 PM, Christopher Larson wrote:<br>
</div>
<blockquote
cite="mid:CABcZANmig7C5KK_+voznmgSPF9k49VQ0Esknc8p9HUX=pMz-FA@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">While you're at it, I'd suggest fixing this to stop
using the horrible indexing a list with a boolean hack and use a
proper inline conditional. 'foo' if bar else 'baz'.<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Thu, May 31, 2018 at 1:43 AM Chen Qi <<a
moz-do-not-send="true" href="mailto:Qi.Chen@windriver.com">Qi.Chen@windriver.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">A list of
tools are added to HOSTTOOLS depending on if we inherit<br>
testimage or not. Unfortunately, if we use TEST_IMAGE variable
to<br>
automate the test, these tools are not added to HOSTTOOLS.<br>
<br>
Modify the condition to also check TEST_IMAGE to fix the above
problem.<br>
<br>
Signed-off-by: Chen Qi <<a moz-do-not-send="true"
href="mailto:Qi.Chen@windriver.com" target="_blank">Qi.Chen@windriver.com</a>><br>
---<br>
meta/conf/bitbake.conf | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf<br>
index 6ecf78b..7b7472c 100644<br>
--- a/meta/conf/bitbake.conf<br>
+++ b/meta/conf/bitbake.conf<br>
@@ -487,7 +487,7 @@ HOSTTOOLS += " \<br>
"<br>
<br>
# Tools needed to run testimage runtime image testing<br>
-HOSTTOOLS += <a class="moz-txt-link-rfc2396E" href="mailto:${@['','ippingpsscpsshstty'][bb.data.inherits_class('testimage',d)]}">"${@['', 'ip ping ps scp ssh
stty'][bb.data.inherits_class('testimage', d)]}"</a><br>
+HOSTTOOLS += <a class="moz-txt-link-rfc2396E" href="mailto:${@['','ippingpsscpsshstty'][bb.data.inherits_class('testimage',d)ord.getVar('TEST_IMAGE')=='1']}">"${@['', 'ip ping ps scp ssh
stty'][bb.data.inherits_class('testimage', d) or
d.getVar('TEST_IMAGE') == '1']}"</a><br>
<br>
# Link to these if present<br>
HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold
nc sftp socat ssh sudo"<br>
-- <br>
1.9.1<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a moz-do-not-send="true"
href="mailto:Openembedded-core@lists.openembedded.org"
target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a moz-do-not-send="true"
href="http://lists.openembedded.org/mailman/listinfo/openembedded-core"
rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote>
</div>
<br clear="all">
<br>
-- <br>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">Christopher Larson<br>
kergoth at gmail dot com<br>
Founder - BitBake, OpenEmbedded, OpenZaurus<br>
Senior Software Engineer, Mentor Graphics</div>
</div>
</div>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>