<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 25, 2018 at 1:50 PM, Jon Szymaniak <span dir="ltr"><<a href="mailto:jon.szymaniak.foss@gmail.com" target="_blank">jon.szymaniak.foss@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">An optional dependency upon the capstone disassembler was introduced<br>
in QEMU v2.11.0-rc0. The necessary version of capstone is included<br>
in the QEMU repository as a git submodule.<br>
<br>
The QEMU configure script uses pkg-config to determine if an<br>
installation of capstone already exists on the system, and defaults to<br>
this, if found. However, there does not appear to be any capstone<br>
version or API compatibility checks.<br>
<br>
To avoid any potential version conflicts or API incompatibility issues<br>
in the future, use the `--enable-capstone=git` argument to force the use<br>
of the capstone version included by QEMU as a git submodule.<br></blockquote><div><br></div><div>How exactly does that work when the default qemu recipe is a tar.bz2 download ?</div><div><br></div><div>We can't have the recipe going out to the 'net and fetching / downloading source code .. and looking at the option, that appears to be what it would do. Or maybe I'm missing where the code is being fetched into place.</div><div><br></div><div>This is something that looks like it could be controlled via packageconfig, or similar mechanism, versus being hard coded into the configure line.</div><div><br></div><div>Also, the patch is missing your Signed-off-by:</div><div><br></div><div>Cheers,</div><div><br></div><div>Bruce</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
meta/recipes-devtools/qemu/<wbr>qemu.inc | 1 +<br>
1 file changed, 1 insertion(+)<br>
<br>
diff --git a/meta/recipes-devtools/qemu/<wbr>qemu.inc b/meta/recipes-devtools/qemu/<wbr>qemu.inc<br>
index 094a975177..37f8398967 100644<br>
--- a/meta/recipes-devtools/qemu/<wbr>qemu.inc<br>
+++ b/meta/recipes-devtools/qemu/<wbr>qemu.inc<br>
@@ -23,6 +23,7 @@ EXTRA_OECONF = " \<br>
--libexecdir=${libexecdir} \<br>
--localstatedir=${<wbr>localstatedir} \<br>
--with-confsuffix=/${BPN} \<br>
+ --enable-capstone=git \<br>
--disable-strip \<br>
--disable-werror \<br>
--target-list=${@get_qemu_<wbr>target_list(d)} \<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.14.1<br>
<br>
-- <br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"</div>
</div></div>