<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 28, 2018 at 8:29 AM Richard Purdie <<a href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@linuxfoundation.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, 2018-06-28 at 15:18 +0000, Peter Kjellerstedt wrote:<br>
> There is no guarantee that ${COREBASE} refers to a path that is<br>
> under Git control. E.g., in our case it refers to a directory that is<br>
> under repo control. "${COREBASE}/meta" is probably a better option.<br>
<br>
You could make that argument about /meta too.<br>
<br>
I'd suggest the code checks for ${COREBASE}/.git and if that doesn't<br>
exist, fall back to the timestamp of the<br>
${COREBASE}/meta/conf/bitbake.conf file.<br></blockquote><div><br></div><div>That's a good idea, but I'd suggest using bb.utils.which() to locate conf/bibake.conf rather than hardcoding that path.<br></div></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Christopher Larson<br>kergoth at gmail dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Senior Software Engineer, Mentor Graphics</div></div></div></div></div>