<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Jul 3, 2018 at 5:55 PM Andre McCurdy <<a href="mailto:armccurdy@gmail.com">armccurdy@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">An over-ride replaces the original value regardless of whether or<br>
not it's set up with +=. As replacing the original value seems to be<br>
the intention here, drop the += to make it more explicit. Also some<br>
minor recipe formatting tweaks.<br>
<br>
Signed-off-by: Andre McCurdy <<a href="mailto:armccurdy@gmail.com" target="_blank">armccurdy@gmail.com</a>><br></blockquote><div><br></div><div class="">Technically this is not the case, not precisely. += is appending to any existing DEPENDS_class-native value, and only *then* is the override applied to replace DEPENDS. So it's not appending to DEPENDS, it's appending to DEPENDS_class-native. In this case, it's most likely doing it this way in the .inc so it's possible for the recipe including it to define DEPENDS_class-native alongside DEPENDS before the inclusion, but this is largely pointless, since they can always += to it *after* the inclusion instead. So I think you're good, most likely it's still fine to remove it, but I wanted to clarify, as there *are* times when this is a useful thing to do.<br clear="all"></div></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Christopher Larson<br>kergoth at gmail dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Senior Software Engineer, Mentor Graphics</div></div></div></div></div>