<div dir="ltr">Confirmed.<div><br></div><div>I was seeing the same today when testing my rebased changes for kernel*bbclasses.</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jul 4, 2018 at 6:09 PM Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
On 7/2/18 8:03 AM, Paulo Neves wrote:<br>
> The normalize_dtb function was buggy because<br>
> it only converted from .dts suffix to .dtb<br>
> suffix if the user passed a full source path to<br>
> KERNEL_DEVICETREE containing the /dts/ path.<br>
> The problem is that if the user did that there<br>
> would be a warning.<br>
> <br>
> On the othet hand if user just set the variable<br>
> KERNEL_DEVICETREE="file.dts" the bbclass translation<br>
> to the respective .dtb target did not occur and<br>
> make would fail saying it has no rule to make target<br>
> file.dts<br>
> <br>
> This patch decouples the logic of having /dts/ in the<br>
> path from the target translation.<br>
> <br>
<br>
This breaks a case where relative paths are used e.g. for rpi<br>
kernel we use DTB=overlay/xxx.dtbo and DTB=xxx.dtb and so on<br>
with this change its going to strip leading directory name and<br>
break that assumption.<br>
<br>
See<br>
<a href="http://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/tree/conf/machine/include/rpi-base.inc#n17" rel="noreferrer" target="_blank">http://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/tree/conf/machine/include/rpi-base.inc#n17</a><br>
<br>
> Signed-off-by: Paulo Neves <<a href="mailto:ptsneves@gmail.com" target="_blank">ptsneves@gmail.com</a>><br>
> ---<br>
> meta/classes/kernel-devicetree.bbclass | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> <br>
> diff --git a/meta/classes/kernel-devicetree.bbclass b/meta/classes/kernel-devicetree.bbclass<br>
> index 4f80cc62eb..9866d844ab 100644<br>
> --- a/meta/classes/kernel-devicetree.bbclass<br>
> +++ b/meta/classes/kernel-devicetree.bbclass<br>
> @@ -13,8 +13,8 @@ normalize_dtb () {<br>
> DTB="$1"<br>
> if echo ${DTB} | grep -q '/dts/'; then<br>
> bbwarn "${DTB} contains the full path to the the dts file, but only the dtb name should be used."<br>
> - DTB=`basename ${DTB} | sed 's,\.dts$,.dtb,g'`<br>
> fi<br>
> + DTB=`basename ${DTB} | sed 's,\.dts$,.dtb,g'`<br>
> echo "${DTB}"<br>
> }<br>
> <br>
> <br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>