<div dir="ltr">The PACKAGECONFIG for them is already there, why do you need to remove the option for someone to disable the support if they want?</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jul 17, 2018 at 11:54 AM Carlos Rafael Giani <<a href="mailto:dv@pseudoterminal.org">dv@pseudoterminal.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>The zlib and bz2 switches enable zlib and bzip2 support in the
qtdemux and matroska plugins. They do not enable some sort of
standalone bz2/zlib plugins. Is there any reason why these
shouldn't be enabled always?<br>
</p>
<br>
<div class="m_-4186692926023383277moz-cite-prefix">On 2018-07-17 11:50, Martin Jansa
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Why do you remove bz2 and zlib PACKAGECONFIGs
instead of just enabling them by default?</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Tue, Jul 17, 2018 at 11:45 AM Carlos Rafael
Giani <<a href="mailto:dv@pseudoterminal.org" target="_blank">dv@pseudoterminal.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">* Always
enable bz2 and zlib, since these are part of oe-core, and<br>
dependencies that are in oe-core can be always enabled<br>
* There is no twolame recipe in oe-core or in
meta-openembedded, so<br>
disable it<br>
* Reorder the packageconfigs alphabetically<br>
<br>
Signed-off-by: Carlos Rafael Giani <<a href="mailto:dv@pseudoterminal.org" target="_blank">dv@pseudoterminal.org</a>><br>
---<br>
.../<a href="http://gstreamer1.0-plugins-good_1.14.1.bb" rel="noreferrer" target="_blank">gstreamer1.0-plugins-good_1.14.1.bb</a>
| 17 +++++++++--------<br>
1 file changed, 9 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/meta/recipes-multimedia/gstreamer/<a href="http://gstreamer1.0-plugins-good_1.14.1.bb" rel="noreferrer" target="_blank">gstreamer1.0-plugins-good_1.14.1.bb</a>
b/meta/recipes-multimedia/gstreamer/<a href="http://gstreamer1.0-plugins-good_1.14.1.bb" rel="noreferrer" target="_blank">gstreamer1.0-plugins-good_1.14.1.bb</a><br>
index 36eb3107ae..baeb19ddfe 100644<br>
--- a/meta/recipes-multimedia/gstreamer/<a href="http://gstreamer1.0-plugins-good_1.14.1.bb" rel="noreferrer" target="_blank">gstreamer1.0-plugins-good_1.14.1.bb</a><br>
+++ b/meta/recipes-multimedia/gstreamer/<a href="http://gstreamer1.0-plugins-good_1.14.1.bb" rel="noreferrer" target="_blank">gstreamer1.0-plugins-good_1.14.1.bb</a><br>
@@ -18,7 +18,7 @@ LIC_FILES_CHKSUM =
"<a class="m_-4186692926023383277moz-txt-link-freetext">file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343</a> \<br>
<a class="m_-4186692926023383277moz-txt-link-freetext">file://common/coverage/</a><a href="http://coverage-report.pl" rel="noreferrer" target="_blank">coverage-report.pl</a>;beginline=2;endline=17;md5=a4e1830fce078028c8f0974161272607
\<br>
<a class="m_-4186692926023383277moz-txt-link-freetext">file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe</a>"<br>
<br>
-DEPENDS += "gstreamer1.0-plugins-base libcap"<br>
+DEPENDS += "gstreamer1.0-plugins-base libcap zlib bzip2"<br>
RPROVIDES_${PN}-pulseaudio += "${PN}-pulse"<br>
RPROVIDES_${PN}-soup += "${PN}-souphttpsrc"<br>
<br>
@@ -28,7 +28,7 @@ PACKAGECONFIG ??= " \<br>
${GSTREAMER_ORC} \<br>
${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio x11',
d)} \<br>
${@bb.utils.contains_any('DISTRO_FEATURES',
d.getVar('GTK3DISTROFEATURES'), 'gtk', '', d)} \<br>
- cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib
v4l2 bz2 zlib mpg123 lame \<br>
+ cairo flac gdk-pixbuf gudev jpeg lame libpng mpg123 soup
speex taglib v4l2 \<br>
"<br>
<br>
X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes
libxdamage"<br>
@@ -37,11 +37,14 @@ PACKAGECONFIG[cairo] =
"--enable-cairo,--disable-cairo,cairo"<br>
PACKAGECONFIG[dv1394] =
"--enable-dv1394,--disable-dv1394,libiec61883 libavc1394
libraw1394"<br>
PACKAGECONFIG[flac] =
"--enable-flac,--disable-flac,flac"<br>
PACKAGECONFIG[gdk-pixbuf] =
"--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"<br>
+PACKAGECONFIG[gtk] =
"--enable-gtk3,--disable-gtk3,gtk+3"<br>
PACKAGECONFIG[gudev] =
"--with-gudev,--without-gudev,libgudev"<br>
PACKAGECONFIG[jack] =
"--enable-jack,--disable-jack,jack"<br>
PACKAGECONFIG[jpeg] =
"--enable-jpeg,--disable-jpeg,jpeg"<br>
+PACKAGECONFIG[lame] =
"--enable-lame,--disable-lame,lame"<br>
PACKAGECONFIG[libpng] =
"--enable-libpng,--disable-libpng,libpng"<br>
PACKAGECONFIG[libv4l2] =
"--with-libv4l2,--without-libv4l2,v4l-utils"<br>
+PACKAGECONFIG[mpg123] =
"--enable-mpg123,--disable-mpg123,mpg123"<br>
PACKAGECONFIG[pulseaudio] =
"--enable-pulse,--disable-pulse,pulseaudio"<br>
PACKAGECONFIG[soup] =
"--enable-soup,--disable-soup,libsoup-2.4"<br>
PACKAGECONFIG[speex] =
"--enable-speex,--disable-speex,speex"<br>
@@ -50,11 +53,6 @@ PACKAGECONFIG[v4l2] =
"--enable-gst_v4l2 --enable-v4l2-probe,--disable-gst<br>
PACKAGECONFIG[vpx] =
"--enable-vpx,--disable-vpx,libvpx"<br>
PACKAGECONFIG[wavpack] =
"--enable-wavpack,--disable-wavpack,wavpack"<br>
PACKAGECONFIG[x11] =
"--enable-x,--disable-x,${X11DEPENDS}"<br>
-PACKAGECONFIG[bz2] =
"--enable-bz2,--disable-bz2,bzip2"<br>
-PACKAGECONFIG[zlib] =
"--enable-zlib,--disable-zlib,zlib"<br>
-PACKAGECONFIG[lame] =
"--enable-lame,--disable-lame,lame"<br>
-PACKAGECONFIG[mpg123] =
"--enable-mpg123,--disable-mpg123,mpg123"<br>
-PACKAGECONFIG[gtk] =
"--enable-gtk3,--disable-gtk3,gtk+3"<br>
<br>
# qt5 support is disabled, because it is not present in OE
core, and requires more work than<br>
# just adding a packageconfig (it requires access to moc,
uic, rcc, and qmake paths).<br>
@@ -62,7 +60,9 @@ PACKAGECONFIG[gtk] =
"--enable-gtk3,--disable-gtk3,gtk+3"<br>
# in a gstreamer1.0-plugins-good bbappend).<br>
<br>
EXTRA_OECONF += " \<br>
+ --enable-bz2 \<br>
--enable-oss \<br>
+ --enable-zlib \<br>
--disable-aalib \<br>
--disable-aalibtest \<br>
--disable-directsound \<br>
@@ -71,9 +71,10 @@ EXTRA_OECONF += " \<br>
--disable-oss4 \<br>
--disable-osx_audio \<br>
--disable-osx_video \<br>
+ --disable-qt \<br>
--disable-shout2 \<br>
+ --disable-twolame \<br>
--disable-waveform \<br>
- --disable-qt \<br>
"<br>
<br>
FILES_${PN}-equalizer +=
"${datadir}/gstreamer-1.0/presets/*.prs"<br>
-- <br>
2.17.1<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote>
</div>
</blockquote>
<br>
</div>
</blockquote></div>