<div dir="ltr"><div>Change was already merged:<br><a href="http://cgit.openembedded.org/openembedded-core/commit/meta/recipes-devtools?id=7dd9772eca6df52db09b65537fdf689f1aa3fd8f">http://cgit.openembedded.org/openembedded-core/commit/meta/recipes-devtools?id=7dd9772eca6df52db09b65537fdf689f1aa3fd8f</a><br><br></div>Is your request still valid?<br></div><div class="gmail_extra"><br><div class="gmail_quote">2018-07-09 21:40 GMT+02:00 Andre McCurdy <span dir="ltr"><<a href="mailto:armccurdy@gmail.com" target="_blank">armccurdy@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, May 9, 2018 at 7:16 AM, taborskikrzysztof<br>
<<a href="mailto:taborskikrzysztof@gmail.com">taborskikrzysztof@gmail.com</a>> wrote:<br>
> Can I request review?<br>
<span class="">> -------- Oryginalna wiadomość --------<br>
> Od: Krzysztof Taborski <<a href="mailto:taborskikrzysztof@gmail.com">taborskikrzysztof@gmail.com</a>><br>
> Data: 08.05.2018 18:46 (GMT+01:00)<br>
> Do: <a href="mailto:openembedded-core@lists.openembedded.org">openembedded-core@lists.<wbr>openembedded.org</a><br>
> DW: Krzysztof Taborski <<a href="mailto:taborskikrzysztof@gmail.com">taborskikrzysztof@gmail.com</a>><br>
> Temat: [meta-oe][PATCH] perl: native modules will not trigger build perl for<br>
> target.<br>
><br>
> Currently building perl-native modules triggers<br>
> build perl for target due to PACKAGES_DYNAMIC regex.<br>
><br>
> This commit will cause, that perl native modules will<br>
> trigger perl-native build.<br>
<br>
</span>Can you give an example of how to reproduce the problem?<br>
<span class=""><br>
> Signed-off-by: Krzysztof Taborski <<a href="mailto:taborskikrzysztof@gmail.com">taborskikrzysztof@gmail.com</a>><br>
> ---<br>
> meta/recipes-devtools/perl/<a href="http://perl-native_5.24.1.bb" rel="noreferrer" target="_blank">per<wbr>l-native_5.24.1.bb</a> | 2 ++<br>
> meta/recipes-devtools/perl/<a href="http://perl_5.24.1.bb" rel="noreferrer" target="_blank">per<wbr>l_5.24.1.bb</a> | 2 +-<br>
> 2 files changed, 3 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/meta/recipes-devtools/perl/<a href="http://perl-native_5.24.1.bb" rel="noreferrer" target="_blank">p<wbr>erl-native_5.24.1.bb</a><br>
> b/meta/recipes-devtools/perl/<a href="http://perl-native_5.24.1.bb" rel="noreferrer" target="_blank">p<wbr>erl-native_5.24.1.bb</a><br>
> index a9ab17d16c..71f45890b0 100644<br>
> --- a/meta/recipes-devtools/perl/<a href="http://perl-native_5.24.1.bb" rel="noreferrer" target="_blank">p<wbr>erl-native_5.24.1.bb</a><br>
> +++ b/meta/recipes-devtools/perl/<a href="http://perl-native_5.24.1.bb" rel="noreferrer" target="_blank">p<wbr>erl-native_5.24.1.bb</a><br>
> @@ -135,3 +135,5 @@ EOF<br>
><br>
> # Fix the path in sstate<br>
> SSTATE_SCAN_FILES += "*.pm *.pod *.h *.pl *.sh"<br>
> +PACKAGES_DYNAMIC_class-native += "^perl-module-.*native$"<br>
<br>
</span>This usage of += with an over-ride is not correct.<br>
<br>
However, regardless of that, was this change actually needed?<br>
<br>
If you know of a -native recipe which depends on a<br>
perl-module-XXX-native package then it's probably a bug in the -native<br>
recipe. Having perl-native pretend to provide perl-module packages<br>
probably isn't the right solution.<br>
<span class=""><br>
> diff --git a/meta/recipes-devtools/perl/<a href="http://perl_5.24.1.bb" rel="noreferrer" target="_blank">p<wbr>erl_5.24.1.bb</a><br>
> b/meta/recipes-devtools/perl/<a href="http://perl_5.24.1.bb" rel="noreferrer" target="_blank">p<wbr>erl_5.24.1.bb</a><br>
> index 53a426289a..4c6a71082f 100644<br>
> --- a/meta/recipes-devtools/perl/<a href="http://perl_5.24.1.bb" rel="noreferrer" target="_blank">p<wbr>erl_5.24.1.bb</a><br>
> +++ b/meta/recipes-devtools/perl/<a href="http://perl_5.24.1.bb" rel="noreferrer" target="_blank">p<wbr>erl_5.24.1.bb</a><br>
> @@ -339,7 +339,7 @@ python split_perl_packages () {<br>
> d.setVar(d.expand("<wbr>RRECOMMENDS_${PN}-modules"), ' '.join(packages))<br>
> }<br>
><br>
> -PACKAGES_DYNAMIC += "^perl-module-.*"<br>
> +PACKAGES_DYNAMIC += "^perl-module-.*(?<!\-native)$<wbr>"<br>
> PACKAGES_DYNAMIC_class-<wbr>nativesdk += "^nativesdk-perl-module-.*"<br>
<br>
</span>This usage of += with an over-ride is not correct.<br>
<div class="HOEnZb"><div class="h5"><br>
> RPROVIDES_perl-lib = "perl-lib"<br>
> --<br>
> 2.13.6<br>
><br>
><br>
</div></div><span class="HOEnZb"><font color="#888888">> --<br>
> ______________________________<wbr>_________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Pozdrawiam,<div>Krzysiek Taborski</div></div></div>
</div>