<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 08/02/2018 01:53 AM, Richard Purdie
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:92e7e92ca488e452bfa185d1f9b4747f3dcb5a94.camel@linuxfoundation.org">
<pre wrap="">On Thu, 2018-08-02 at 10:55 +0800, Anuj Mittal wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 08/02/2018 07:30 AM, Alejandro Enedino Hernandez Samaniego wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hey Anuj,
On 08/01/2018 04:25 AM, Anuj Mittal wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 07/31/2018 05:21 AM, Jaewon Lee wrote:
</pre>
<blockquote type="cite">
<pre wrap="">When using a recipe space kernel-meta, scc files are added
through
SRC_URI, but they may include corresponding kernel fragments
that are
not necessarily in SRC_URI.
For bitbake, this is not a problem because the kernel-yocto
class adds
the path where the .scc file was found to includes which
consequentially
makes the .cfg file available to the kernel build.
However, when using devtool, only files specified in SRC_URI
are copied
to oe-local-files in devtool's workspace. So if the cfg file is
not in
SRC_URI, it won't be copied, causing a kernel build failure
when trying
to find it.
This fix parses local .scc files in SRC_URI, copies the
corresponding .cfg
file to devtool's workdir, and also adds it to local_files so
it is
available when doing a devtool build for the kernel.
[YOCTO #12858]
Signed-off-by: Jaewon Lee <a class="moz-txt-link-rfc2396E" href="mailto:jaewon.lee@xilinx.com"><jaewon.lee@xilinx.com></a>
Signed-off-by: Alejandro Enedino Hernandez Samaniego <a class="moz-txt-link-rfc2396E" href="mailto:alejandr@xilinx.com"><alejandr@
xilinx.com></a>
---
meta/classes/devtool-source.bbclass | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/meta/classes/devtool-source.bbclass
b/meta/classes/devtool-source.bbclass
index 56882a4..c70fea2 100644
--- a/meta/classes/devtool-source.bbclass
+++ b/meta/classes/devtool-source.bbclass
@@ -90,11 +90,23 @@ python devtool_post_unpack() {
fname in files])
return ret
+ is_kernel_yocto = bb.data.inherits_class('kernel-yocto',
d)
# Move local source files into separate subdir
recipe_patches = [os.path.basename(patch) for patch in
oe.recipeutils.get_recipe_patches(d)]
local_files = oe.recipeutils.get_recipe_local_files(d)
+ if is_kernel_yocto:
+ for key in local_files.copy():
+ if key.endswith('scc'):
+ sccfile = open(local_files[key], 'r')
+ for l in sccfile:
+ line = l.split()
+ if line and line[0] == 'kconf' and line[-
1].endswith('.cfg'):
+ local_files[line[-1]] =
os.path.join(os.path.dirname(local_files[key]), line[-1])
+ shutil.copy2(os.path.join(os.path.dirname(local_
files[key]), line[-1]), workdir)
+ sccfile.close()
+
</pre>
</blockquote>
<pre wrap="">
Would the patches included in these .scc files also need to be
handled
in the same way? Would this also work if there are other scc
files
included in a scc file?
</pre>
</blockquote>
<pre wrap="">
Yes, I believe that the same mechanism should be used for patch
files as
well,
basically anything that may be needed to build but that its not
necessarily
explicitly listed on SRC_URI.
I believe it will work for other scc files and it doesnt have to
be
recursive,
because while cfg files arent required to be in SRC_URI , scc files
ARE
required
to be SRC_URI, which means that this will eventually find the other
scc
file on the list
</pre>
</blockquote>
<pre wrap="">
I don't think they are required to be specified except for the top
level
one. At least, when I test it, I see problems. kernel-tools spp
script
parses them recursively and looks for a nested scc even if it is not
specified as part of SRC_URI. That is how the top level sccs from
kernel-cache are parsed too. Can you give it a try please?</pre>
</blockquote>
</blockquote>
Hey Anuj,<br>
We can give it a try but do you have a specific example of how it
fails for you?<br>
Because I know theres lots of nested sccs on the yocto kernel cache,
but in that case<br>
it wouldn't be a problem since this bug is specifically introduced
by devtool when it<br>
copies local files from SRC_URI to a oe-local-files directory, it
misses the corresponding cfg files (or patch files)<br>
since they're not listed in SRC_URI and it fails to build, in the
case of the yocto kernel cache, it<br>
does not contain local files, so they wont be moved hence why it
wouldn't be an issue.<br>
<br>
From the kernel dev manual:<br>
<a class="moz-txt-link-freetext" href="https://www.yoctoproject.org/docs/latest/kernel-dev/kernel-dev.html#recipe-space-metadata">https://www.yoctoproject.org/docs/latest/kernel-dev/kernel-dev.html#recipe-space-metadata</a>
:<br>
<span style="color: rgb(51, 51, 51); font-family: Verdana, Sans,
sans-serif; font-size: medium; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); text-decoration-style:
initial; text-decoration-color: initial; display: inline
!important; float: none;">It is only necessary to specify the<span> </span></span><code
class="filename" style="font-size: medium; font-family: Courier,
monospace; color: rgb(51, 51, 51); font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); text-decoration-style:
initial; text-decoration-color: initial;">.scc</code><span
style="color: rgb(51, 51, 51); font-family: Verdana, Sans,
sans-serif; font-size: medium; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); text-decoration-style:
initial; text-decoration-color: initial; display: inline
!important; float: none;"><span> </span>files on the<span> </span></span><a
class="ulink"
href="http://www.yoctoproject.org/docs/2.5/ref-manual/ref-manual.html#var-SRC_URI"
target="_top" style="text-decoration: underline; color: rgb(68,
68, 68); background: rgb(255, 255, 255); font-family: Verdana,
Sans, sans-serif; font-size: medium; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width:
0px;"><code class="filename" style="font-size: medium;
font-family: Courier, monospace;">SRC_URI</code></a><span
style="color: rgb(51, 51, 51); font-family: Verdana, Sans,
sans-serif; font-size: medium; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); text-decoration-style:
initial; text-decoration-color: initial; display: inline
!important; float: none;">.<span> <br>
<br>
</span></span>It specifies that only the scc files need to be on
SRC_URI, which is why I'm saying the script<br>
will eventually run into them from the list.<br>
<br>
I want to be clear that I'm not against doing this recursively, I
just want to understand your testcase better.<br>
<span style="color: rgb(51, 51, 51); font-family: Verdana, Sans,
sans-serif; font-size: medium; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255); text-decoration-style:
initial; text-decoration-color: initial; display: inline
!important; float: none;"><span></span></span>
<blockquote type="cite"
cite="mid:92e7e92ca488e452bfa185d1f9b4747f3dcb5a94.camel@linuxfoundation.org">
<blockquote type="cite">
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">
What would be really great here would be some test cases in the qa
framework! It'd be a good way to both illustrate the problems and then
test we've fixed it and that it stays fixed.</pre>
</blockquote>
Hey Richard,<br>
Sure that sounds like a good idea, well work on adding a testcase
(or adding to the existing one) for devtool when<br>
it is using a recipe-space kernel -meta.<br>
<br>
Alejandro<br>
<blockquote type="cite"
cite="mid:92e7e92ca488e452bfa185d1f9b4747f3dcb5a94.camel@linuxfoundation.org">
<pre wrap="">
Cheers,
Richard
</pre>
</blockquote>
<br>
</body>
</html>