<div dir="ltr"><div>I think this will break support for older kernels added in:</div><div><a href="http://git.openembedded.org/openembedded-core/commit/?id=19fb2d11a8bb3c6dfdd5edc1b9155d642dc0f5e0">http://git.openembedded.org/openembedded-core/commit/?id=19fb2d11a8bb3c6dfdd5edc1b9155d642dc0f5e0</a><br></div><div><br></div>kernel-source/tools/arch and kernel-source/tools/build are missing in 3.16 kernel even when it's not completely broken.<br><div><br></div><div>I'm not completely against this change, maybe just add to commit message that for older kernels you need to add .bbappend which removes the directories which really doesn't exist in your kernel version from PERF_SRC.</div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 10, 2018 at 4:55 PM Mikko Rapeli <<a href="mailto:mikko.rapeli@bmw.de">mikko.rapeli@bmw.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">A missing src directory from a broken kernel recipe resulted<br>
only in a warning:<br>
<br>
WARNING: copyfile: stat of /home/builder/src/tmp-glibc/work-shared/target/kernel-source/tools/arch failed ([Errno 2] No such file or directory: '/home/builder/src/tmp-glibc/work-shared/target/kernel-source/tools/arch')<br>
<br>
With this change it's an error which can not be missed:<br>
<br>
ERROR: perf-1.0-r9 do_configure: Path does not exist: /home/builder/src/tmp-glibc/work-shared/target/kernel-source/tools/arch<br>
ERROR: perf-1.0-r9 do_configure: Function failed: copy_perf_source_from_kernel<br>
ERROR: Logfile of failure stored in: /home/builder/src/tmp-glibc/work/target-linux/perf/1.0-r9/temp/log.do_configure.21083<br>
NOTE: recipe perf-1.0-r9: task do_configure: Failed<br>
ERROR: Task (/home/builder/src/poky/meta/recipes-kernel/perf/perf.bb:do_configure) failed with exit code '1'<br>
<br>
Signed-off-by: Mikko Rapeli <<a href="mailto:mikko.rapeli@bmw.de" target="_blank">mikko.rapeli@bmw.de</a>><br>
---<br>
meta/recipes-kernel/perf/<a href="http://perf.bb" rel="noreferrer" target="_blank">perf.bb</a> | 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
diff --git a/meta/recipes-kernel/perf/<a href="http://perf.bb" rel="noreferrer" target="_blank">perf.bb</a> b/meta/recipes-kernel/perf/<a href="http://perf.bb" rel="noreferrer" target="_blank">perf.bb</a><br>
index 2c6bbb4..c07afeb 100644<br>
--- a/meta/recipes-kernel/perf/<a href="http://perf.bb" rel="noreferrer" target="_blank">perf.bb</a><br>
+++ b/meta/recipes-kernel/perf/<a href="http://perf.bb" rel="noreferrer" target="_blank">perf.bb</a><br>
@@ -147,6 +147,8 @@ python copy_perf_source_from_kernel() {<br>
for s in sources:<br>
src = oe.path.join(src_dir, s)<br>
dest = oe.path.join(dest_dir, s)<br>
+ if not os.path.exists(src):<br>
+ bb.fatal("Path does not exist: %s" % src)<br>
if os.path.isdir(src):<br>
oe.path.copyhardlinktree(src, dest)<br>
else:<br>
-- <br>
1.9.1<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>