<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr">On Wed, 22 Aug 2018, 21:36 Khem Raj, <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I wonder how it work with meta-raspverrypi now that it has its own<br>
packing for firmware<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Sorry Them, I don't understand your question.</div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Wed, Aug 22, 2018 at 1:10 PM Ryan Harkin <<a href="mailto:ryan.harkin@linaro.org" target="_blank" rel="noreferrer">ryan.harkin@linaro.org</a>> wrote:<br>
><br>
><br>
><br>
> On Wed, 22 Aug 2018, 20:02 Martin Jansa, <<a href="mailto:martin.jansa@gmail.com" target="_blank" rel="noreferrer">martin.jansa@gmail.com</a>> wrote:<br>
>><br>
>> Your 1st parameter is wrong, compare again with the example I gave you (don't include "brcm/" path in 1st param, because you want the symlink to point to just brcmfmac43430-sdio.AP6212.txt like you did in the version after cd).<br>
><br>
><br>
> That doesn't work either. I tried it with the same result, but didn't send a log of it. That works for you?<br>
><br>
><br>
>> On Wed, Aug 22, 2018 at 7:11 PM Ryan Harkin <<a href="mailto:ryan.harkin@linaro.org" target="_blank" rel="noreferrer">ryan.harkin@linaro.org</a>> wrote:<br>
>>><br>
>>> This is curious!<br>
>>><br>
>>> On 22 August 2018 at 17:56, Martin Jansa <<a href="mailto:martin.jansa@gmail.com" target="_blank" rel="noreferrer">martin.jansa@gmail.com</a>> wrote:<br>
>>>><br>
>>>> cd ${D}${nonarch_base_libdir}/firmware/brcm/ ; ln -sf brcmfmac43430-sdio.AP6212.txt brcmfmac43430-sdio.txt<br>
>>>><br>
>>>> is the same as<br>
>>>><br>
>>>> ln -sf brcmfmac43430-sdio.AP6212.txt ${D}${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.txt<br>
>>><br>
>>><br>
>>> On my system, this is what happens when I'm in the root of the linux-firmware repo:<br>
>>><br>
>>> $ ls -al brcm/*.txt<br>
>>> -rw-rw-r-- 1 ryan ryan 875 Aug 22 18:08 brcm/brcmfmac43430-sdio.AP6212.txt<br>
>>> -rw-rw-r-- 1 ryan ryan 831 Aug 21 14:48 brcm/brcmfmac43430-sdio.MUR1DX.txt<br>
>>><br>
>>> $ ln -sf brcm/brcmfmac43430-sdio.AP6212.txt brcm/brcmfmac43430-sdio.txt<br>
>>><br>
>>> $ ls -al brcm/*.txt<br>
>>> -rw-rw-r-- 1 ryan ryan 875 Aug 22 18:08 brcm/brcmfmac43430-sdio.AP6212.txt<br>
>>> -rw-rw-r-- 1 ryan ryan 831 Aug 21 14:48 brcm/brcmfmac43430-sdio.MUR1DX.txt<br>
>>> lrwxrwxrwx 1 ryan ryan 34 Aug 22 18:08 brcm/brcmfmac43430-sdio.txt -> brcm/brcmfmac43430-sdio.AP6212.txt<br>
>>><br>
>>> And the file is not valid.<br>
>>><br>
>>> $ cat brcm/brcmfmac43430-sdio.txt<br>
>>> cat: brcm/brcmfmac43430-sdio.txt: No such file or directory<br>
>>><br>
>>> So perhaps I'm doing something wrong. I tried your suggestion originally and it didn't work for me. Maybe I made a typo or something?<br>
>>><br>
>>><br>
>>>><br>
>>>> On Wed, Aug 22, 2018 at 6:47 PM Ryan Harkin <<a href="mailto:ryan.harkin@linaro.org" target="_blank" rel="noreferrer">ryan.harkin@linaro.org</a>> wrote:<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> On 22 August 2018 at 17:41, Martin Jansa <<a href="mailto:martin.jansa@gmail.com" target="_blank" rel="noreferrer">martin.jansa@gmail.com</a>> wrote:<br>
>>>>>><br>
>>>>>> The "cd ${D}${nonarch_base_libdir}/firmware/brcm/" doesn't seem to be needed, just include the path in 2nd ln parameter.<br>
>>>>><br>
>>>>><br>
>>>>> I don't think that works, or at least, it doesn't work for me, so I may be doing something wrong. I'm also copying the example used in the do_install() a few lines up as I figured that would be the preferred style for this recipe.<br>
>>>>><br>
>>>>>><br>
>>>>>> On Wed, Aug 22, 2018 at 6:30 PM Ryan Harkin <<a href="mailto:ryan.harkin@linaro.org" target="_blank" rel="noreferrer">ryan.harkin@linaro.org</a>> wrote:<br>
>>>>>>><br>
>>>>>>> The Linux kernel currently expects a single NVRAM file for BCM43430<br>
>>>>>>> named brcmfmac43430-sdio.txt.<br>
>>>>>>><br>
>>>>>>> Allow the machine to specify an override to link its module specific<br>
>>>>>>> NVRAM to the filename expected by the kernel.<br>
>>>>>>><br>
>>>>>>> Signed-off-by: Ryan Harkin <<a href="mailto:ryan.harkin@linaro.org" target="_blank" rel="noreferrer">ryan.harkin@linaro.org</a>><br>
>>>>>>> ---<br>
>>>>>>> meta/recipes-kernel/linux-firmware/<a href="http://linux-firmware_git.bb" rel="noreferrer noreferrer" target="_blank">linux-firmware_git.bb</a> | 12 ++++++++++++<br>
>>>>>>> 1 file changed, 12 insertions(+)<br>
>>>>>>><br>
>>>>>>> diff --git a/meta/recipes-kernel/linux-firmware/<a href="http://linux-firmware_git.bb" rel="noreferrer noreferrer" target="_blank">linux-firmware_git.bb</a> b/meta/recipes-kernel/linux-firmware/<a href="http://linux-firmware_git.bb" rel="noreferrer noreferrer" target="_blank">linux-firmware_git.bb</a><br>
>>>>>>> index 8c54f28..b647abc 100644<br>
>>>>>>> --- a/meta/recipes-kernel/linux-firmware/<a href="http://linux-firmware_git.bb" rel="noreferrer noreferrer" target="_blank">linux-firmware_git.bb</a><br>
>>>>>>> +++ b/meta/recipes-kernel/linux-firmware/<a href="http://linux-firmware_git.bb" rel="noreferrer noreferrer" target="_blank">linux-firmware_git.bb</a><br>
>>>>>>> @@ -226,6 +226,18 @@ do_install() {<br>
>>>>>>> ( cd ${D}${nonarch_base_libdir}/firmware ; ln -sf ti-connectivity/* . )<br>
>>>>>>> }<br>
>>>>>>><br>
>>>>>>> +# Adding bcm43430-nvram-{module type} to MACHINEOVERRIDES will create a<br>
>>>>>>> +# softlink for the module specific NVRAM file to the filename expected<br>
>>>>>>> +# by the Linux kernel<br>
>>>>>>> +FILES_${PN}-bcm43430-nvram_append_bcm43430-nvram-mur1dx = " ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.txt"<br>
>>>>>>> +do_install_append_bcm43430-nvram-mur1dx() {<br>
>>>>>>> + ( cd ${D}${nonarch_base_libdir}/firmware/brcm/ ; ln -sf brcmfmac43430-sdio.MUR1DX.txt brcmfmac43430-sdio.txt)<br>
>>>>>>> +}<br>
>>>>>>> +FILES_${PN}-bcm43430-nvram_append_bcm43430-nvram-ap6212 = "${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.txt"<br>
>>>>>>> +do_install_append_bcm43430-nvram-ap6212() {<br>
>>>>>>> + ( cd ${D}${nonarch_base_libdir}/firmware/brcm/ ; ln -sf brcmfmac43430-sdio.AP6212.txt brcmfmac43430-sdio.txt)<br>
>>>>>>> +}<br>
>>>>>>> +<br>
>>>>>>><br>
>>>>>>> PACKAGES =+ "${PN}-ralink-license ${PN}-ralink \<br>
>>>>>>> ${PN}-mt7601u-license ${PN}-mt7601u \<br>
>>>>>>> --<br>
>>>>>>> 2.7.4<br>
>>>>>>><br>
>>>>><br>
>>><br>
> --<br>
> _______________________________________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank" rel="noreferrer">Openembedded-core@lists.openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div></div></div>