<div dir="ltr">Got it.<br><div>I will tweak it and resubmit a PATCHv2 once I got it right.</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Sep 6, 2018 at 12:07 AM Tom Rini <<a href="mailto:trini@konsulko.com">trini@konsulko.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Sep 05, 2018 at 09:53:25PM +0200, Emmanuel Roullit wrote:<br>
<br>
> wic allows the user to create disk image and reference each created<br>
> partitions via its partition UUID.<br>
> <br>
> squashfs does not support filesystem UUID but it does offer support for<br>
> partition UUID.<br>
> <br>
> $ lsblk -o NAME,FSTYPE,UUID,PARTUUID<br>
> NAME FSTYPE UUID PARTUUID<br>
> sda<br>
> |-sda1 vfat 6078-ACD0 95aa4ffb-741d-4d99-adf6-0358bc890046<br>
> |-sda2 squashfs 7d46da2d-29cc-4d5a-9e39-d0381c4abb0c<br>
> |-sda3 squashfs d4a3e24e-410a-4f2c-8ad5-8f8321de177b<br>
> |-sda4 ext4 d72ec529-78e4-4cd3-b39b-781b6b1cb47c f3edc990-f4f6-4536-9587-44dae4ceb99f<br>
> `-sda5 ext4 a0b265aa-e935-40b8-9c6b-e9e58ad3890f 6e72ebaa-29ed-41cd-844c-3f76976cf41d<br>
> <br>
> Removing this constrain allows a user to create squashfs-based rootfs and boot<br>
> from it with such kernel argument 'root=PARTUUID=7d46da2d-29cc-4d5a-9e39-d0381c4abb0c'<br>
> <br>
> Signed-off-by: Emmanuel Roullit <<a href="mailto:emmanuel.roullit@gmail.com" target="_blank">emmanuel.roullit@gmail.com</a>><br>
<br>
Please add in:<br>
Fixes: 2fbdcf4e59c8 ("wic: kparser.py: Check for SquashFS and use-uuid")<br>
<br>
> ---<br>
> scripts/lib/wic/ksparser.py | 5 -----<br>
> 1 file changed, 5 deletions(-)<br>
> <br>
> diff --git a/scripts/lib/wic/ksparser.py b/scripts/lib/wic/ksparser.py<br>
> index e590b2f..92f0b6d 100644<br>
> --- a/scripts/lib/wic/ksparser.py<br>
> +++ b/scripts/lib/wic/ksparser.py<br>
> @@ -196,11 +196,6 @@ class KickStart():<br>
> raise KickStartError('%s:%d: %s' % \<br>
> (confpath, lineno, err))<br>
> if line.startswith('part'):<br>
> - # SquashFS does not support UUID<br>
> - if parsed.fstype == 'squashfs' and parsed.use_uuid:<br>
> - err = "%s:%d: SquashFS does not support UUID" \<br>
> - % (confpath, lineno)<br>
> - raise KickStartError(err)<br>
> # using ArgumentParser one cannot easily tell if option<br>
> # was passed as argument, if said option has a default<br>
> # value; --overhead-factor/--extra-space cannot be used<br>
<br>
So I got this logic slightly wrong then. We should correct the check<br>
that we don't have parsed.fsuuid rather than use_uuid. Thanks!<br>
<br>
-- <br>
Tom<br>
</blockquote></div>