<div dir="ltr"><div>Thanks for the review,</div><div><br></div><div>I will resend patch with changes according your comments.<br></div></div><br><div class="gmail_quote"><div dir="ltr">Le lun. 10 sept. 2018 à 19:04, Martin Jansa <<a href="mailto:martin.jansa@gmail.com">martin.jansa@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">And don't use tag name in SRCREV, use git SHA, so that bitbake fetcher doesn't need to access the git repository every time it parses the recipe.</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Sep 10, 2018 at 5:49 PM Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">this should be in meta-multmedia layer.<br>
On Mon, Sep 10, 2018 at 8:15 AM Baptiste Durand<br>
<<a href="mailto:baptiste.durand@gmail.com" target="_blank">baptiste.durand@gmail.com</a>> wrote:<br>
><br>
> Restore minidlna recipe and bump it to v1.2.1<br>
><br>
> Signed-off-by: Baptiste Durand <<a href="mailto:baptiste.durand@gmail.com" target="_blank">baptiste.durand@gmail.com</a>><br>
> ---<br>
> .../recipes-multimedia/minidlna/minidlna.inc | 41 +++++++++++++++++++<br>
> .../0001-Update-Gettext-version.patch | 34 +++++++++++++++<br>
> .../minidlna/<a href="http://minidlna_1.2.1.bb" rel="noreferrer" target="_blank">minidlna_1.2.1.bb</a> | 4 ++<br>
> 3 files changed, 79 insertions(+)<br>
> create mode 100644 meta-oe/recipes-multimedia/minidlna/minidlna.inc<br>
> create mode 100644 meta-oe/recipes-multimedia/minidlna/minidlna/0001-Update-Gettext-version.patch<br>
> create mode 100644 meta-oe/recipes-multimedia/minidlna/<a href="http://minidlna_1.2.1.bb" rel="noreferrer" target="_blank">minidlna_1.2.1.bb</a><br>
><br>
> diff --git a/meta-oe/recipes-multimedia/minidlna/minidlna.inc b/meta-oe/recipes-multimedia/minidlna/minidlna.inc<br>
> new file mode 100644<br>
> index 000000000..187ff536a<br>
> --- /dev/null<br>
> +++ b/meta-oe/recipes-multimedia/minidlna/minidlna.inc<br>
> @@ -0,0 +1,41 @@<br>
> +DESCRIPTION = "MiniDLNA (aka ReadyDLNA) is server software with the aim of \<br>
> +being fully compliant with DLNA/UPnP-AV clients."<br>
> +LICENSE = "GPL-2.0|BSD"<br>
> +DEPENDS = "ffmpeg flac libav jpeg sqlite3 libexif libogg libid3tag libvorbis"<br>
> +<br>
> +# because it depends on libav which has commercial flag<br>
> +LICENSE_FLAGS = "commercial"<br>
> +<br>
> +inherit gettext autotools-brokensep update-rc.d systemd<br>
> +<br>
> +SRC_URI = "git://<a href="http://git.code.sf.net/p/minidlna/git;branch=master;module=git" rel="noreferrer" target="_blank">git.code.sf.net/p/minidlna/git;branch=master;module=git</a> \<br>
> + file://minidlna-daemon.init.d \<br>
> + file://minidlna.service \<br>
> + file://0001-Update-Gettext-version.patch \<br>
> + "<br>
> +<br>
> +S = "${WORKDIR}/git"<br>
> +<br>
> +# This remove "--exclude=autopoint" option from autoreconf argument to avoid<br>
> +# <a href="http://configure.ac:30" rel="noreferrer" target="_blank">configure.ac:30</a>: error: required file './ABOUT-NLS' not found<br>
> +EXTRA_AUTORECONF = ""<br>
> +<br>
> +do_install_append(){<br>
> + install -d ${D}${sysconfdir}<br>
> + install -m 0755 minidlna.conf ${D}${sysconfdir}<br>
> +<br>
> +# Systemd script<br>
> + install -d ${D}${nonarch_base_libdir}/systemd/system<br>
> + install -m 0755 ${WORKDIR}/minidlna.service ${D}${nonarch_base_libdir}/systemd/system<br>
> +<br>
> +# Sysvinit script<br>
> + install -d ${D}${sysconfdir}/init.d<br>
> + install -m 0755 ${WORKDIR}/minidlna-daemon.init.d ${D}${sysconfdir}/init.d/minidlna<br>
> +<br>
> +}<br>
> +<br>
> +SYSTEMD_SERVICE_${PN} = "minidlna.service"<br>
> +<br>
> +INITSCRIPT_NAME = "minidlna"<br>
> +INITSCRIPT_PARAMS = "defaults 90"<br>
> +<br>
> diff --git a/meta-oe/recipes-multimedia/minidlna/minidlna/0001-Update-Gettext-version.patch b/meta-oe/recipes-multimedia/minidlna/minidlna/0001-Update-Gettext-version.patch<br>
> new file mode 100644<br>
> index 000000000..c18095d42<br>
> --- /dev/null<br>
> +++ b/meta-oe/recipes-multimedia/minidlna/minidlna/0001-Update-Gettext-version.patch<br>
> @@ -0,0 +1,34 @@<br>
> +From a4290bf1887f9203288858ca76bdd20b2edf337a Mon Sep 17 00:00:00 2001<br>
> +From: Baptiste Durand <<a href="mailto:baptiste.durand@gmail.com" target="_blank">baptiste.durand@gmail.com</a>><br>
> +Date: Sun, 9 Sep 2018 20:50:41 +0200<br>
> +Subject: [PATCH] Update Gettext version<br>
> +<br>
> +Upstream-Status: Inappropriate [oe-core specific]<br>
> +<br>
> +Signed-off-by: Baptiste Durand <<a href="mailto:baptiste.durand@gmail.com" target="_blank">baptiste.durand@gmail.com</a>><br>
> +---<br>
> + <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 4 ++--<br>
> + 1 file changed, 2 insertions(+), 2 deletions(-)<br>
> +<br>
> +diff --git a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
> +index f343d21..a556b33 100644<br>
> +--- a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
> ++++ b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
> +@@ -14,7 +14,7 @@<br>
> + # License along with MiniDLNA; if not, write to the Free Software<br>
> + # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307<br>
> + # USA.<br>
> +-AC_INIT(MiniDLNA,1.1.3,,minidlna)<br>
> ++AC_INIT(MiniDLNA,1.2.1,,minidlna)<br>
> + #LT_INIT<br>
> +<br>
> + AC_CANONICAL_TARGET<br>
> +@@ -28,7 +28,7 @@ m4_ifdef([AC_USE_SYSTEM_EXTENSIONS], [AC_USE_SYSTEM_EXTENSIONS])<br>
> +<br>
> + AM_ICONV<br>
> + AM_GNU_GETTEXT([external])<br>
> +-AM_GNU_GETTEXT_VERSION(0.18)<br>
> ++AM_GNU_GETTEXT_VERSION(0.19)<br>
> +<br>
> + # Checks for programs.<br>
> + AC_PROG_AWK<br>
> diff --git a/meta-oe/recipes-multimedia/minidlna/<a href="http://minidlna_1.2.1.bb" rel="noreferrer" target="_blank">minidlna_1.2.1.bb</a> b/meta-oe/recipes-multimedia/minidlna/<a href="http://minidlna_1.2.1.bb" rel="noreferrer" target="_blank">minidlna_1.2.1.bb</a><br>
> new file mode 100644<br>
> index 000000000..fe6bebce2<br>
> --- /dev/null<br>
> +++ b/meta-oe/recipes-multimedia/minidlna/<a href="http://minidlna_1.2.1.bb" rel="noreferrer" target="_blank">minidlna_1.2.1.bb</a><br>
> @@ -0,0 +1,4 @@<br>
> +require ${BPN}.inc<br>
> +<br>
> +SRCREV = "v1_2_1"<br>
> +LIC_FILES_CHKSUM = "file://LICENCE.miniupnpd;md5=b0dabf9d8e0f871554e309d62ead8d2b"<br>
> --<br>
> 2.17.1<br>
><br>
> --<br>
> _______________________________________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div><span><font color="#888888">Baptiste DURAND<br></font></span></div><div><span><font color="#888888"><br></font></span></div></div></div></div>