<div dir="ltr"><div dir="ltr">Was this one ever sent to ML? I haven't found it in the archives.<div><br></div><div>With security flags enabled it fails on older hosts (e.g. Ubuntu 14.04 with gcc-4.8) now with:</div><div><br></div><div><div>DEBUG: Executing shell function do_compile</div><div>[1/63] gcc -Igen.tab/gen.tab@@gen-unicode-version@exe -Igen.tab -I../fribidi-1.0.5/gen.tab -I. -I../fribidi-1.0.5/ -Ilib -I../fribidi-1.0.5/lib -pipe -D_FILE_OFFSET_BITS=64 -ansi -fvisibility=hidden -O2 -g -feliminate-unused-debug-types -fdebug-prefix-map=TOPDIR/BUILD/work/raspberrypi3-webos-linux-gnueabi/fribidi/1.0.5-r0=/usr/src/debug/fribidi/1.0.5-r0 -fdebug-prefix-map=TOPDIR/BUILD/work/raspberrypi3-webos-linux-gnueabi/fribidi/1.0.5-r0/recipe-sysroot= -fdebug-prefix-map=TOPDIR/BUILD/work/raspberrypi3-webos-linux-gnueabi/fribidi/1.0.5-r0/recipe-sysroot-native= -UHAVE_CONFIG_H -DHAVE_STRINGIZE -DDONT_HAVE_FRIBIDI_CONFIG_H -DHAVE_STDLIB_H -DHAVE_STRING_H -DHAVE_STRINGS_H -DSTDC_HEADERS=1 -MD -MQ 'gen.tab/gen.tab@@gen-unicode-version@exe/gen-unicode-version.c.o' -MF 'gen.tab/gen.tab@@gen-unicode-version@exe/gen-unicode-version.c.o.d' -o 'gen.tab/gen.tab@@gen-unicode-version@exe/gen-unicode-version.c.o' -c ../fribidi-1.0.5/gen.tab/gen-unicode-version.c</div><div>[2/63] gcc -o gen.tab/gen-unicode-version 'gen.tab/gen.tab@@gen-unicode-version@exe/gen-unicode-version.c.o' -Wl,--no-undefined -Wl,--as-needed -O2 -pipe -g -feliminate-unused-debug-types -fdebug-prefix-map=TOPDIR/BUILD/work/raspberrypi3-webos-linux-gnueabi/fribidi/1.0.5-r0=/usr/src/debug/fribidi/1.0.5-r0 -fdebug-prefix-map=TOPDIR/BUILD/work/raspberrypi3-webos-linux-gnueabi/fribidi/1.0.5-r0/recipe-sysroot= -fdebug-prefix-map=TOPDIR/BUILD/work/raspberrypi3-webos-linux-gnueabi/fribidi/1.0.5-r0/recipe-sysroot-native= -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fstack-protector-strong -Wl,-z,relro,-z,now </div><div>FAILED: gen.tab/gen-unicode-version </div><div>gcc -o gen.tab/gen-unicode-version 'gen.tab/gen.tab@@gen-unicode-version@exe/gen-unicode-version.c.o' -Wl,--no-undefined -Wl,--as-needed -O2 -pipe -g -feliminate-unused-debug-types -fdebug-prefix-map=TOPDIR/BUILD/work/raspberrypi3-webos-linux-gnueabi/fribidi/1.0.5-r0=/usr/src/debug/fribidi/1.0.5-r0 -fdebug-prefix-map=TOPDIR/BUILD/work/raspberrypi3-webos-linux-gnueabi/fribidi/1.0.5-r0/recipe-sysroot= -fdebug-prefix-map=TOPDIR/BUILD/work/raspberrypi3-webos-linux-gnueabi/fribidi/1.0.5-r0/recipe-sysroot-native= -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -fstack-protector-strong -Wl,-z,relro,-z,now </div><div>gcc: error: unrecognized command line option ‘-fstack-protector-strong’</div><div>ninja: build stopped: subcommand failed.</div><div>WARNING: exit code 1 from a shell command.</div></div><div><br></div><div>Is meson too active in adding SECURITY_FLAGS even to native part of the build or should we just just remove -fstack-protector-strong completely for fribidi?</div><div><br></div><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 21, 2018 at 5:24 PM <<a href="mailto:git@git.openembedded.org">git@git.openembedded.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is an automated email from the git hooks/post-receive script.<br>
<br>
rpurdie pushed a commit to branch master-next<br>
in repository openembedded-core.<br>
<br>
commit d297f7ebf3f62528d055e1938a9693d6f3a61935<br>
Author: Ross Burton <<a href="mailto:ross.burton@intel.com" target="_blank">ross.burton@intel.com</a>><br>
AuthorDate: Fri Sep 14 00:28:39 2018 +0100<br>
<br>
fribidi: use Meson instead of autotools<br>
<br>
Upstream is moving to Meson, so backport a patch to use that instead of<br>
autotools.<br>
<br>
Signed-off-by: Ross Burton <<a href="mailto:ross.burton@intel.com" target="_blank">ross.burton@intel.com</a>><br>
---<br>
meta/recipes-support/fribidi/fribidi/meson.patch | 44 ++++++++++++++++++++++++<br>
meta/recipes-support/fribidi/<a href="http://fribidi_1.0.5.bb" rel="noreferrer" target="_blank">fribidi_1.0.5.bb</a> | 8 ++---<br>
2 files changed, 47 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/meta/recipes-support/fribidi/fribidi/meson.patch b/meta/recipes-support/fribidi/fribidi/meson.patch<br>
new file mode 100644<br>
index 0000000..8b3c4a9<br>
--- /dev/null<br>
+++ b/meta/recipes-support/fribidi/fribidi/meson.patch<br>
@@ -0,0 +1,44 @@<br>
+Upstream-Status: Backport<br>
+Signed-off-by: Ross Burton <<a href="mailto:ross.burton@intel.com" target="_blank">ross.burton@intel.com</a>><br>
+<br>
+From f5feb6c599adb52f24656f8589868039b0d14272 Mon Sep 17 00:00:00 2001<br>
+From: Heiko Becker <<a href="mailto:heirecka@exherbo.org" target="_blank">heirecka@exherbo.org</a>><br>
+Date: Fri, 7 Sep 2018 20:57:11 +0200<br>
+Subject: [PATCH] Build generator executables natively<br>
+<br>
+They are run during the build and not installed in the end. Without<br>
+this one gets the following error from meson: "ERROR: Can not use<br>
+target gen-unicode-version as a generator because it is cross-built<br>
+and no exe wrapper is defined. You might want to set it to native<br>
+instead."<br>
+<br>
+Closes #87.<br>
+<br>
+---<br>
+ gen.tab/meson.build | 6 ++++--<br>
+ 1 file changed, 4 insertions(+), 2 deletions(-)<br>
+<br>
+diff --git a/gen.tab/meson.build b/gen.tab/meson.build<br>
+index 6006d98..8c21e98 100644<br>
+--- a/gen.tab/meson.build<br>
++++ b/gen.tab/meson.build<br>
+@@ -33,7 +33,8 @@ gen_unicode_version = executable('gen-unicode-version',<br>
+ 'gen-unicode-version.c',<br>
+ include_directories: incs,<br>
+ c_args: native_args,<br>
+- install: false)<br>
++ install: false,<br>
++ native: true)<br>
+ <br>
+ fribidi_unicode_version_h = custom_target('fribidi-unicode-version.h',<br>
+ input: files('unidata/ReadMe.txt', 'unidata/BidiMirroring.txt'),<br>
+@@ -67,7 +68,8 @@ foreach tab : tabs<br>
+ gen_prog_src, 'packtab.c',<br>
+ include_directories: incs,<br>
+ c_args: native_args,<br>
+- install: false)<br>
++ install: false,<br>
++ native: true)<br>
+ <br>
+ tab_inc_file = custom_target(gen_prog_name,<br>
+ input: gen_prog_inputs,<br>
diff --git a/meta/recipes-support/fribidi/<a href="http://fribidi_1.0.5.bb" rel="noreferrer" target="_blank">fribidi_1.0.5.bb</a> b/meta/recipes-support/fribidi/<a href="http://fribidi_1.0.5.bb" rel="noreferrer" target="_blank">fribidi_1.0.5.bb</a><br>
index 303ccb7..63b2da6 100644<br>
--- a/meta/recipes-support/fribidi/<a href="http://fribidi_1.0.5.bb" rel="noreferrer" target="_blank">fribidi_1.0.5.bb</a><br>
+++ b/meta/recipes-support/fribidi/<a href="http://fribidi_1.0.5.bb" rel="noreferrer" target="_blank">fribidi_1.0.5.bb</a><br>
@@ -3,16 +3,14 @@ SECTION = "libs"<br>
LICENSE = "LGPLv2.1+"<br>
LIC_FILES_CHKSUM = "file://COPYING;md5=a916467b91076e631dd8edb7424769c7"<br>
<br>
-SRC_URI = "<a href="https://github.com/$%7BBPN%7D/$%7BBPN%7D/releases/download/v$%7BPV%7D/$%7BBP%7D.tar.bz2" rel="noreferrer" target="_blank">https://github.com/${BPN}/${BPN}/releases/download/v${PV}/${BP}.tar.bz2</a>"<br>
+SRC_URI = "<a href="https://github.com/$%7BBPN%7D/$%7BBPN%7D/releases/download/v$%7BPV%7D/$%7BBP%7D.tar.bz2" rel="noreferrer" target="_blank">https://github.com/${BPN}/${BPN}/releases/download/v${PV}/${BP}.tar.bz2</a> \<br>
+ file://meson.patch"<br>
SRC_URI[md5sum] = "0f97f65038545340316ec0f4bd53df0b"<br>
SRC_URI[sha256sum] = "6a64f2a687f5c4f203a46fa659f43dd43d1f8b845df8d723107e8a7e6158e4ce"<br>
<br>
UPSTREAM_CHECK_URI = "<a href="https://github.com/$%7BBPN%7D/$%7BBPN%7D/releases" rel="noreferrer" target="_blank">https://github.com/${BPN}/${BPN}/releases</a>"<br>
<br>
-inherit autotools lib_package pkgconfig<br>
-<br>
-# TODO use Meson instead of autotools when<br>
-# <a href="https://github.com/fribidi/fribidi/issues/87" rel="noreferrer" target="_blank">https://github.com/fribidi/fribidi/issues/87</a> is solved<br>
+inherit meson lib_package pkgconfig<br>
<br>
CVE_PRODUCT = "gnu_fribidi"<br>
<br>
<br>
-- <br>
To stop receiving notification emails like this one, please contact<br>
the administrator of this repository.<br>
-- <br>
_______________________________________________<br>
Openembedded-commits mailing list<br>
<a href="mailto:Openembedded-commits@lists.openembedded.org" target="_blank">Openembedded-commits@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-commits" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-commits</a><br>
</blockquote></div>