<div dir="ltr">BTW, patchwork made me resend the patch to openembedded-devel, which list would be right for this ?<br></div><br><div class="gmail_quote"><div dir="ltr">Le mer. 17 oct. 2018 à 17:54, Martin Jansa <<a href="mailto:martin.jansa@gmail.com">martin.jansa@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr">Hmm, you're right 5397ae5 would be better with just DISTRO_FEATURES replaced with BLUEZ variable in</div><div dir="ltr"><div dir="ltr"><br></div><div dir="ltr">RDEPENDS_${PN} = " \</div><div dir="ltr"> ${@bb.utils.contains('DISTRO_FEATURES', 'bluez5', '${BLUEZ5_INSTALL}', "", d)} \</div><div dir="ltr"> ${@bb.utils.contains('DISTRO_FEATURES', 'bluez4', '${BLUEZ4_INSTALL}', "", d)} \</div><div dir="ltr">"</div><div dir="ltr"><br></div><div>Then it would work fine for both use cases and empty BLUEZ as well.</div></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Oct 17, 2018 at 5:47 PM Yann Dirson <<a href="mailto:yann.dirson@blade-group.com" target="_blank">yann.dirson@blade-group.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Well, inline python was what was originally used before 5397ae5.<br></div><br><div class="gmail_quote"><div dir="ltr">Le mer. 17 oct. 2018 à 17:46, Martin Jansa <<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">well, I realized that this won't work with the BLUEZ intentionally set to empty value and setting BLUEZ to no-bluetooth globally also probably won't work for cases where it might be used in e.g. RDEPENDS_${PN} :/. Maybe inline python appending only either bluez4 or bluez5 alternative here?</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Oct 17, 2018 at 5:43 PM Yann Dirson <<a href="mailto:yann.dirson@blade-group.com" target="_blank">yann.dirson@blade-group.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yeah, that looks like a better idea. <br></div><br><div class="gmail_quote"><div dir="ltr">Le mer. 17 oct. 2018 à 17:27, Martin Jansa <<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">What about using some less confusing default BLUEZ value? RDEPENDS_ looks wrong.<div><br></div><div>BLUEZ ??= "no-bluetooth"</div><div>RDEPENDS_no-bluetooth = ""</div><div><br></div><div>Might be a bit more clear.</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Oct 17, 2018 at 5:08 PM <<a href="mailto:yann.dirson@blade-group.com" target="_blank">yann.dirson@blade-group.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Yann Dirson <<a href="mailto:yann@blade-group.com" target="_blank">yann@blade-group.com</a>><br>
<br>
Otherwise the build fails with:<br>
<br>
NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...<br>
Missing or unbuildable dependency chain was: ['${RDEPENDS_}']<br>
<br>
This restores some truth in the "Otherwise install nothing" comment in the recipe.<br>
<br>
Signed-off-by: Yann Dirson <<a href="mailto:yann@blade-group.com" target="_blank">yann@blade-group.com</a>><br>
---<br>
.../packagegroups/<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">packagegroup-tools-bluetooth.bb</a> | 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
diff --git a/meta-oe/recipes-connectivity/packagegroups/<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">packagegroup-tools-bluetooth.bb</a> b/meta-oe/recipes-connectivity/packagegroups/<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">packagegroup-tools-bluetooth.bb</a><br>
index 0ede5e57b..e81516fef 100644<br>
--- a/meta-oe/recipes-connectivity/packagegroups/<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">packagegroup-tools-bluetooth.bb</a><br>
+++ b/meta-oe/recipes-connectivity/packagegroups/<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">packagegroup-tools-bluetooth.bb</a><br>
@@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \<br>
'', d)} \<br>
"<br>
<br>
+RDEPENDS_ = ""<br>
+<br>
# Install bluez4 tools or bluez5 tools depending on what is specified in the distro.<br>
# Otherwise install nothing.<br>
RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"<br>
-- <br>
2.19.1<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="m_1571655446455322552m_-7798490518947502568m_-2074142617775729286m_-5484289321282644411gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Yann Dirson <<a href="mailto:yann@blade-group.com" target="_blank">yann@blade-group.com</a>><br>Blade -- 38 rue du Sentier, 75002 Paris<br></div></div></div>
</blockquote></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="m_1571655446455322552m_-7798490518947502568gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Yann Dirson <<a href="mailto:yann@blade-group.com" target="_blank">yann@blade-group.com</a>><br>Blade -- 38 rue du Sentier, 75002 Paris<br></div></div></div>
</blockquote></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Yann Dirson <<a href="mailto:yann@blade-group.com" target="_blank">yann@blade-group.com</a>><br>Blade -- 38 rue du Sentier, 75002 Paris<br></div></div></div>