<div dir="ltr">Sent v3 to -devel - that does not supercede the original series on patwork, though.<br></div><br><div class="gmail_quote"><div dir="ltr">Le mer. 17 oct. 2018 à 20:52, Martin Jansa <<a href="mailto:martin.jansa@gmail.com">martin.jansa@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Oct 17, 2018 at 10:58:49AM -0500, Mark Hatle wrote:<br>
> On 10/17/18 10:46 AM, Martin Jansa wrote:<br>
> > well, I realized that this won't work with the BLUEZ intentionally set to empty<br>
> > value and setting BLUEZ to no-bluetooth globally also probably won't work for<br>
> > cases where it might be used in e.g. RDEPENDS_${PN} :/. Maybe inline python<br>
> > appending only either bluez4 or bluez5 alternative here?<br>
> <br>
> I'm slightly confused. In the suggestion you made below, ??= within the<br>
> specific package, why would 'no-bluetooth' cause a problem. For all other<br>
> recipes it will remain blank as expected.<br>
<br>
Because if you set it to empty, then ??= won't be used and we'll be back<br>
to RDEPENDS_.<br>
<br>
And if you set BLUEZ to no-bluetooth e.g. in your DISTRO config than it<br>
will break other recipes, e.g.:<br>
<br>
meta/recipes-connectivity/ofono/ofono.inc:PACKAGECONFIG[bluez] = "--enable-bluetooth, --disable-bluetooth, ${BLUEZ}"<br>
meta/recipes-core/packagegroups/<a href="http://packagegroup-base.bb" rel="noreferrer" target="_blank">packagegroup-base.bb</a>: ${BLUEZ} \<br>
meta/recipes-devtools/python/python3.inc:PACKAGECONFIG[bluetooth] = ",ac_cv_header_bluetooth_bluetooth_h=no ac_cv_header_bluetooth_h=no,${BLUEZ}"<br>
meta/recipes-devtools/qemu/qemu.inc:PACKAGECONFIG[bluez] = "--enable-bluez,--disable-bluez,${BLUEZ}"<br>
meta/recipes-devtools/strace/strace_4.24.bb:PACKAGECONFIG[bluez] = "ac_cv_header_bluetooth_bluetooth_h=yes,ac_cv_header_bluetooth_bluetooth_h=no,${BLUEZ}"<br>
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.2.bb:PACKAGECONFIG[bluez] = "--enable-bluez,--disable-bluez,${BLUEZ}"<br>
<br>
> --Mark<br>
> <br>
> > On Wed, Oct 17, 2018 at 5:43 PM Yann Dirson <<a href="mailto:yann.dirson@blade-group.com" target="_blank">yann.dirson@blade-group.com</a><br>
> > <mailto:<a href="mailto:yann.dirson@blade-group.com" target="_blank">yann.dirson@blade-group.com</a>>> wrote:<br>
> > <br>
> > Yeah, that looks like a better idea.<br>
> > <br>
> > Le mer. 17 oct. 2018 à 17:27, Martin Jansa <<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a><br>
> > <mailto:<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a>>> a écrit :<br>
> > <br>
> > What about using some less confusing default BLUEZ value? RDEPENDS_<br>
> > looks wrong.<br>
> > <br>
> > BLUEZ ??= "no-bluetooth"<br>
> > RDEPENDS_no-bluetooth = ""<br>
> > <br>
> > Might be a bit more clear.<br>
> > <br>
> > On Wed, Oct 17, 2018 at 5:08 PM <<a href="mailto:yann.dirson@blade-group.com" target="_blank">yann.dirson@blade-group.com</a><br>
> > <mailto:<a href="mailto:yann.dirson@blade-group.com" target="_blank">yann.dirson@blade-group.com</a>>> wrote:<br>
> > <br>
> > From: Yann Dirson <<a href="mailto:yann@blade-group.com" target="_blank">yann@blade-group.com</a> <mailto:<a href="mailto:yann@blade-group.com" target="_blank">yann@blade-group.com</a>>><br>
> > <br>
> > Otherwise the build fails with:<br>
> > <br>
> > NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...<br>
> > Missing or unbuildable dependency chain was: ['${RDEPENDS_}']<br>
> > <br>
> > This restores some truth in the "Otherwise install nothing" comment<br>
> > in the recipe.<br>
> > <br>
> > Signed-off-by: Yann Dirson <<a href="mailto:yann@blade-group.com" target="_blank">yann@blade-group.com</a><br>
> > <mailto:<a href="mailto:yann@blade-group.com" target="_blank">yann@blade-group.com</a>>><br>
> > ---<br>
> > .../packagegroups/<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">packagegroup-tools-bluetooth.bb</a><br>
> > <<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">http://packagegroup-tools-bluetooth.bb</a>> | 2 ++<br>
> > 1 file changed, 2 insertions(+)<br>
> > <br>
> > diff --git<br>
> > a/meta-oe/recipes-connectivity/packagegroups/<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">packagegroup-tools-bluetooth.bb</a><br>
> > <<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">http://packagegroup-tools-bluetooth.bb</a>><br>
> > b/meta-oe/recipes-connectivity/packagegroups/<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">packagegroup-tools-bluetooth.bb</a><br>
> > <<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">http://packagegroup-tools-bluetooth.bb</a>><br>
> > index 0ede5e57b..e81516fef 100644<br>
> > ---<br>
> > a/meta-oe/recipes-connectivity/packagegroups/<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">packagegroup-tools-bluetooth.bb</a><br>
> > <<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">http://packagegroup-tools-bluetooth.bb</a>><br>
> > +++<br>
> > b/meta-oe/recipes-connectivity/packagegroups/<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">packagegroup-tools-bluetooth.bb</a><br>
> > <<a href="http://packagegroup-tools-bluetooth.bb" rel="noreferrer" target="_blank">http://packagegroup-tools-bluetooth.bb</a>><br>
> > @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \<br>
> > '', d)} \<br>
> > "<br>
> > <br>
> > +RDEPENDS_ = ""<br>
> > +<br>
> > # Install bluez4 tools or bluez5 tools depending on what is<br>
> > specified in the distro.<br>
> > # Otherwise install nothing.<br>
> > RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"<br>
> > -- <br>
> > 2.19.1<br>
> > <br>
> > -- <br>
> > _______________________________________________<br>
> > Openembedded-core mailing list<br>
> > <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> > <mailto:<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a>><br>
> > <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
> > <br>
> > <br>
> > <br>
> > -- <br>
> > Yann Dirson <<a href="mailto:yann@blade-group.com" target="_blank">yann@blade-group.com</a> <mailto:<a href="mailto:yann@blade-group.com" target="_blank">yann@blade-group.com</a>>><br>
> > Blade -- 38 rue du Sentier, 75002 Paris<br>
> > <br>
> > <br>
> > <br>
> <br>
> -- <br>
> _______________________________________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
<br>
-- <br>
Martin 'JaMa' Jansa jabber: <a href="mailto:Martin.Jansa@gmail.com" target="_blank">Martin.Jansa@gmail.com</a><br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Yann Dirson <<a href="mailto:yann@blade-group.com" target="_blank">yann@blade-group.com</a>><br>Blade -- 38 rue du Sentier, 75002 Paris<br></div></div></div>