<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Hi Alejandro,<br>
<br>
I submitted the patch using git send-email since that email.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">pyvenv and venv are not the same. pyvenv depends on venv to run.<br>
</p>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="3" color="black"><span style="font-size: 12pt;">See the entire content of pyvenv:</span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="2" color="black"><span style="font-size: 10pt;"><i>---------------------------------------------------</i></span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="2" color="black"><span style="font-size: 10pt;"><i>#! /usr/bin/python3.5 </i></span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="2" color="black"><span style="font-size: 10pt;"><i>if __name__ == '__main__': </i></span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="2" color="black"><span style="font-size: 10pt;"><i> import sys </i></span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="2" color="black"><span style="font-size: 10pt;"><i> rc = 1 </i></span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="2" color="black"><span style="font-size: 10pt;"><i> try: </i></span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="2" color="black"><span style="font-size: 10pt;"><i> import venv </i></span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="2" color="black"><span style="font-size: 10pt;"><i> venv.main() </i></span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="2" color="black"><span style="font-size: 10pt;"><i> rc = 0 </i></span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="2" color="black"><span style="font-size: 10pt;"><i> except Exception as e: </i></span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="2" color="black"><span style="font-size: 10pt;"><i> print('Error: %s' % e, file=sys.stderr) </i></span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="2" color="black"><span style="font-size: 10pt;"><i> sys.exit(rc) </i></span></font><font face="Calibri,sans-serif" size="3" color="black"><span style="font-size: 12pt;"> </span></font></div>
<div style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
<font face="Calibri,sans-serif" size="3" color="black"><span style="font-size: 12pt;">----------------------------------------------------</span></font></div>
As you can see, pyvenv depends on venv to run. <span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">Because it is confusing
to have both pyvenv and venv; pyvenv has been deprecated in python 3.6.</span>
<p></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">They should be two seperate
packages not a single because they are different things. Read here for more information: <a href="https://docs.python.org/3/library/venv.html" class="OWAAutoLink">https://docs.python.org/3/library/venv.html</a></span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"><br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">I do not understand what
you mean by the cached files as I did not add it. After modifying the JSON I ran create_manifest3.py which added that, the rdepends content on venv was also added automatically after runny that script. My changes are only adding pyvenv and venv in the JSON.</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"><br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">I will submit another patch
which removes pyvenv in the python3 recipe.</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"><br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">Regards,</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"><br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">Hugues</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"><br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"><br>
</span></p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<p></p>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Alejandro Hernandez <alejandro.enedino.hernandez-samaniego@xilinx.com><br>
<b>Sent:</b> 22 October 2018 23:17:26<br>
<b>To:</b> Hugues Kamba; openembedded-core@lists.openembedded.org<br>
<b>Cc:</b> Diego Russo; Jeremy Johnson; aehs29@gmail.com<br>
<b>Subject:</b> Re: [OE-core] PATCH: Fixing python3-pyvenv and adding python3-venv</font>
<div> </div>
</div>
<meta content="text/html; charset=Windows-1252">
<div style="background-color:#FFFFFF">
<p>Hello Huges,</p>
<p><br>
</p>
<p>I cannot reply inline because you sent the patch as an attachment, please send it using git send-email next time.</p>
<p><br>
</p>
<p>Also, something doesnt add up here:</p>
<p><br>
</p>
<p><br>
</p>
<pre class="x_moz-quote-pre">+ "pyvenv": {
+ "summary": "Allow you to create virtual environments so we can isolate our project dependencies. Deprecated in Python 3.6",
+ "rdepends": [
+ "core",
+ "venv"
This doesnt make sense, since you are saying that the python3-pyvenv package depends on python3-venv?, shouldnt they be the same package?
+ ],
+ "files": [
+ "${bindir}/pyvenv*"
Again, this should probably on one single package.
+ ],
+ "cached": []
+ },
"resource": {
"summary": "Python resource control interface",
"rdepends": [
@@ -1107,6 +1118,21 @@
"${libdir}/python${PYTHON_MAJMIN}/__pycache__/getpass.*.pyc"
]
This is wrong because, cached files shouldnt be on rdepends.
Everything from there to the bottom is probably ok.
},
+ "venv": {
+ "summary": "Provides support for creating lightweight virtual environments with their own site directories, optionally isolated from system site directories",
+ "rdepends": [
+ "compression",
+ "core",
+ "logging",
+ "shell",
+ "stringold",
+ "unixadmin"
+ ],
+ "files": [
+ "${libdir}/python${PYTHON_MAJMIN}/venv"
+ ],
+ "cached": []
+ },
"xml": {
"summary": "Python basic XML support",
"rdepends": [</pre>
<p><br>
</p>
<p><br>
</p>
<p><br>
</p>
<p>Also, this patch is missing the changes to the python3 recipe file where the python3-pyvenv package was being previously created, if were now doing it through the manifest, then we dont need it in the recipe.</p>
<p><br>
</p>
<p>Thanks!</p>
<p><br>
</p>
<p>Alejandro<br>
</p>
<p><br>
</p>
<p><br>
</p>
<p><br>
</p>
<div class="x_moz-cite-prefix">On 10/22/2018 11:48 AM, Hugues Kamba wrote:<br>
</div>
<blockquote type="cite"><style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div id="x_divtagdefaultwrapper" dir="ltr" style="">
<p style="margin-top:0; margin-bottom:0">Dear All,</p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0">As it currently is, python3-pyvenv is broken because it is missing the venv module run-time dependency.</p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0">The patch I am submitting is to add the venv module dependency to python3-pyvenv. </p>
<p style="margin-top:0; margin-bottom:0">The dependency has been <span style="font-size:12pt">added </span><span style="font-size:12pt">using the newly added venv package (python3-venv).</span></p>
<p style="margin-top:0; margin-bottom:0"><span style="font-size:12pt">The python3-venv package has been added for future proofing since pyvenv has been deprecated in Python 3.6 and creation of virtual environment is done using the venv module directly (i.e
python3 -m venv my_venv).</span></p>
<p style="margin-top:0; margin-bottom:0"><span style="font-size:12pt"><br>
</span></p>
<p style="margin-top:0; margin-bottom:0"><span style="font-size:12pt">Regards,</span></p>
<p style="margin-top:0; margin-bottom:0"><span style="font-size:12pt"><br>
</span></p>
<p style="margin-top:0; margin-bottom:0"><span style="font-size:12pt">Hugues Kamba</span></p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr" style="">
<p style=""></p>
</div>
</div>
</div>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose,
or store or copy the information in any medium. Thank you. <br>
<fieldset class="x_mimeAttachmentHeader"></fieldset> </blockquote>
</div>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose,
or store or copy the information in any medium. Thank you.
</body>
</html>