<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Sat, 20 Oct 2018 at 02:11, <<a href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@linuxfoundation.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, 2018-10-16 at 18:21 -0500, Aníbal Limón wrote:<br>
> When use simpleremote target the flash/boot process is executed<br>
> manually, the IMAGE_FSTYPES validation is only needed when execute<br>
> testimage against qemu.<br>
> <br>
> The supported_fstypes comes from oeqa.core.target.qemu module.<br>
> <br>
> Signed-off-by: Aníbal Limón <<a href="mailto:anibal.limon@linaro.org" target="_blank">anibal.limon@linaro.org</a>><br>
> ---<br>
> meta/classes/testimage.bbclass | 13 +++++++------<br>
> 1 file changed, 7 insertions(+), 6 deletions(-)<br>
> <br>
> diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass<br>
> index 2642a722e7..734cb7caae 100644<br>
> --- a/meta/classes/testimage.bbclass<br>
> +++ b/meta/classes/testimage.bbclass<br>
> @@ -194,12 +194,13 @@ def testimage_main(d):<br>
> machine = d.getVar("MACHINE")<br>
> <br>
> # Get rootfs<br>
> - fstypes = [fs for fs in d.getVar('IMAGE_FSTYPES').split(' ')<br>
> - if fs in supported_fstypes]<br>
> - if not fstypes:<br>
> - bb.fatal('Unsupported image type built. Add a comptible image to '<br>
> - 'IMAGE_FSTYPES. Supported types: %s' %<br>
> - ', '.join(supported_fstypes))<br>
> + fstypes = d.getVar('IMAGE_FSTYPES')<br>
> + if d.getVar("TEST_TARGET") == "qemu":<br>
> + fstypes = [fs for fs in fstypes if fs in supported_fstypes]<br>
> + if not fstypes:<br>
> + bb.fatal('Unsupported image type built. Add a comptible image to '<br>
> + 'IMAGE_FSTYPES. Supported types: %s' %<br>
> + ', '.join(supported_fstypes))<br>
> rootfs = '%s.%s' % (image_name, fstypes[0])<br>
> <br>
> # Get tmpdir (not really used, just for compatibility)<br>
<br>
This causes the autobuilder to break and there is a bug in the logic<br>
above:<br>
<br>
<a href="https://autobuilder.yoctoproject.org/typhoon/#/builders/32/builds/128/steps/7/logs/step1c" rel="noreferrer" target="_blank">https://autobuilder.yoctoproject.org/typhoon/#/builders/32/builds/128/steps/7/logs/step1c</a></blockquote><div><br></div><div>I'm not seeing this error, I executed testimage in qemuarm and qemux86, </div><div>I'm looking at the configuration but should not fail because I added only a conditional to filter only<br></div><div>when the target is qemu.</div><div><br></div><div>Regards,</div><div>Anibal </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
(one of many failures as everything broke)<br>
<br>
Cheers,<br>
<br>
Richard<br>
<br>
<br>
</blockquote></div></div>