<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hello Huges,</p>
<p><br>
</p>
<div class="moz-cite-prefix">On 10/23/2018 12:12 AM, Hugues Kamba
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:VI1PR08MB3631EBC976E8E5A79335589698F40@VI1PR08MB3631.eurprd08.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper"
style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;"
dir="ltr">
<p style="margin-top:0;margin-bottom:0">Hi Alenjandro,</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">More information here: <a
href="https://www.python.org/dev/peps/pep-0405/#creating-virtual-environments"
class="OWAAutoLink" moz-do-not-send="true">https://www.python.org/dev/peps/pep-0405/#creating-virtual-environments</a></p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">What I am proposing is
also a good idea for when python 3.6 is available in Yocto. </p>
<p style="margin-top:0;margin-bottom:0">With Python 3.5 one can
create virtual environment by including python3-pyvenv
OR python3-venv+python3-runpy.</p>
<p style="margin-top:0;margin-bottom:0">With Python 3.6 one will
only be able to create virtual environments with
python3-venv+python3-runpy.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">I hope I made it a bit
clearer now.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
</div>
</blockquote>
<p><br>
</p>
<p>I do understand what you are saying, they are two different
things, and while the purpose of the manifest</p>
<p>is to provide more granularity on what goes or doesn't go on an
image, we still have to be careful on</p>
<p>how we package things, in this case I simply don't see any reason
why we would need two separate packages,</p>
<p>specially because nothing else RDEPENDS on venv , and I don't see
the point in creating a package that only</p>
<p>contains a single binary.</p>
<p><br>
</p>
<p>I believe it makes more sense to package them both together in a
single package, we are upgrading to python 3.7 soon,</p>
<p>and I believe having a single vnenv package should work for that
too.<br>
</p>
<p><br>
</p>
<p>Cheers,</p>
<p>Alejandro<br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:VI1PR08MB3631EBC976E8E5A79335589698F40@VI1PR08MB3631.eurprd08.prod.outlook.com">
<div id="divtagdefaultwrapper"
style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;"
dir="ltr">
<p style="margin-top:0;margin-bottom:0">Thanks!</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:
12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica,
sans-serif, EmojiFont, "Apple Color Emoji",
"Segoe UI Emoji", NotoColorEmoji, "Segoe UI
Symbol", "Android Emoji", EmojiSymbols;">
<p style="margin-top:0; margin-bottom:0"><br>
</p>
Hugues
<table style="color:rgb(33,33,33);
font-family:wf_segoe-ui_normal,"Segoe
UI","Segoe
WP",Tahoma,Arial,sans-serif,serif,EmojiFont;
font-size:15px; border-collapse:collapse;
margin-right:6.75pt; margin-left:6.75pt" cellspacing="0"
cellpadding="0" border="0" align="left">
<tbody>
</tbody>
</table>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt"
face="Calibri, sans-serif" color="#000000"><b>From:</b> Hugues
Kamba<br>
<b>Sent:</b> 22 October 2018 23:47:44<br>
<b>To:</b> Alejandro Hernandez;
<a class="moz-txt-link-abbreviated" href="mailto:openembedded-core@lists.openembedded.org">openembedded-core@lists.openembedded.org</a><br>
<b>Cc:</b> Diego Russo; Jeremy Johnson; <a class="moz-txt-link-abbreviated" href="mailto:aehs29@gmail.com">aehs29@gmail.com</a><br>
<b>Subject:</b> Re: [OE-core] PATCH: Fixing python3-pyvenv and
adding python3-venv</font>
<div> </div>
</div>
<meta content="text/html; charset=us-ascii">
<style type="text/css" style="display:none">
<!--
p
        {margin-top:0;
        margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr"
style="font-size:12pt; color:#000000;
font-family:Calibri,Helvetica,sans-serif">
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0">Hi Alejandro,<br>
<br>
I submitted the patch using git send-email since that email.</p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0">pyvenv and venv are
not the same. pyvenv depends on venv to run.<br>
</p>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="3" face="Calibri,sans-serif" color="black"><span
style="font-size:12pt">See the entire content of pyvenv:</span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="2" face="Calibri,sans-serif" color="black"><span
style="font-size:10pt"><i>---------------------------------------------------</i></span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="2" face="Calibri,sans-serif" color="black"><span
style="font-size:10pt"><i>#! /usr/bin/python3.5
</i></span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="2" face="Calibri,sans-serif" color="black"><span
style="font-size:10pt"><i>if __name__ == '__main__':
</i></span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="2" face="Calibri,sans-serif" color="black"><span
style="font-size:10pt"><i> import sys
</i></span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="2" face="Calibri,sans-serif" color="black"><span
style="font-size:10pt"><i> rc = 1
</i></span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="2" face="Calibri,sans-serif" color="black"><span
style="font-size:10pt"><i> try:
</i></span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="2" face="Calibri,sans-serif" color="black"><span
style="font-size:10pt"><i> import venv
</i></span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="2" face="Calibri,sans-serif" color="black"><span
style="font-size:10pt"><i> venv.main()
</i></span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="2" face="Calibri,sans-serif" color="black"><span
style="font-size:10pt"><i> rc = 0
</i></span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="2" face="Calibri,sans-serif" color="black"><span
style="font-size:10pt"><i> except Exception as e:
</i></span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="2" face="Calibri,sans-serif" color="black"><span
style="font-size:10pt"><i> print('Error: %s' % e,
file=sys.stderr) </i></span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="2" face="Calibri,sans-serif" color="black"><span
style="font-size:10pt"><i> sys.exit(rc) </i></span></font><font
size="3" face="Calibri,sans-serif" color="black"><span
style="font-size:12pt"> </span></font></div>
<div
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">
<font size="3" face="Calibri,sans-serif" color="black"><span
style="font-size:12pt">----------------------------------------------------</span></font></div>
As you can see, pyvenv depends on venv to run. <span
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">Because it is confusing to have both pyvenv
and venv; pyvenv has been deprecated in python 3.6.</span>
<p style="margin-top:0; margin-bottom:0"><span
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">They should be two seperate packages not a
single because they are different things. Read here for
more information: <a
href="https://docs.python.org/3/library/venv.html"
class="x_OWAAutoLink" moz-do-not-send="true">https://docs.python.org/3/library/venv.html</a></span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px"><br>
</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">I do not understand what you mean by the
cached files as I did not add it. After modifying the JSON
I ran create_manifest3.py which added that, the rdepends
content on venv was also added automatically after runny
that script. My changes are only adding pyvenv and venv in
the JSON.</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px"><br>
</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">I will submit another patch which removes
pyvenv in the python3 recipe.</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px"><br>
</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">Regards,</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px"><br>
</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px">Hugues</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px"><br>
</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols;
font-size:16px"><br>
</span></p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<div id="x_Signature">
<div id="x_divtagdefaultwrapper" dir="ltr"
style="font-size:12pt; color:rgb(0,0,0);
font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple
Color Emoji","Segoe UI
Emoji",NotoColorEmoji,"Segoe UI
Symbol","Android Emoji",EmojiSymbols">
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font style="font-size:11pt"
face="Calibri, sans-serif" color="#000000"><b>From:</b>
Alejandro Hernandez
<a class="moz-txt-link-rfc2396E" href="mailto:alejandro.enedino.hernandez-samaniego@xilinx.com"><alejandro.enedino.hernandez-samaniego@xilinx.com></a><br>
<b>Sent:</b> 22 October 2018 23:17:26<br>
<b>To:</b> Hugues Kamba;
<a class="moz-txt-link-abbreviated" href="mailto:openembedded-core@lists.openembedded.org">openembedded-core@lists.openembedded.org</a><br>
<b>Cc:</b> Diego Russo; Jeremy Johnson; <a class="moz-txt-link-abbreviated" href="mailto:aehs29@gmail.com">aehs29@gmail.com</a><br>
<b>Subject:</b> Re: [OE-core] PATCH: Fixing python3-pyvenv
and adding python3-venv</font>
<div> </div>
</div>
<meta content="text/html; charset=Windows-1252">
<div style="background-color:#FFFFFF">
<p>Hello Huges,</p>
<p><br>
</p>
<p>I cannot reply inline because you sent the patch as an
attachment, please send it using git send-email next time.</p>
<p><br>
</p>
<p>Also, something doesnt add up here:</p>
<p><br>
</p>
<p><br>
</p>
<pre class="x_x_moz-quote-pre">+ "pyvenv": {
+ "summary": "Allow you to create virtual environments so we can isolate our project dependencies. Deprecated in Python 3.6",
+ "rdepends": [
+ "core",
+ "venv"
This doesnt make sense, since you are saying that the python3-pyvenv package depends on python3-venv?, shouldnt they be the same package?
+ ],
+ "files": [
+ "${bindir}/pyvenv*"
Again, this should probably on one single package.
+ ],
+ "cached": []
+ },
"resource": {
"summary": "Python resource control interface",
"rdepends": [
@@ -1107,6 +1118,21 @@
"${libdir}/python${PYTHON_MAJMIN}/__pycache__/getpass.*.pyc"
]
This is wrong because, cached files shouldnt be on rdepends.
Everything from there to the bottom is probably ok.
},
+ "venv": {
+ "summary": "Provides support for creating lightweight virtual environments with their own site directories, optionally isolated from system site directories",
+ "rdepends": [
+ "compression",
+ "core",
+ "logging",
+ "shell",
+ "stringold",
+ "unixadmin"
+ ],
+ "files": [
+ "${libdir}/python${PYTHON_MAJMIN}/venv"
+ ],
+ "cached": []
+ },
"xml": {
"summary": "Python basic XML support",
"rdepends": [</pre>
<p><br>
</p>
<p><br>
</p>
<p><br>
</p>
<p>Also, this patch is missing the changes to the python3
recipe file where the python3-pyvenv package was being
previously created, if were now doing it through the
manifest, then we dont need it in the recipe.</p>
<p><br>
</p>
<p>Thanks!</p>
<p><br>
</p>
<p>Alejandro<br>
</p>
<p><br>
</p>
<p><br>
</p>
<p><br>
</p>
<div class="x_x_moz-cite-prefix">On 10/22/2018 11:48 AM,
Hugues Kamba wrote:<br>
</div>
<blockquote type="cite">
<style type="text/css" style="display:none">
<!--
p
        {margin-top:0;
        margin-bottom:0}
-->
</style>
<div id="x_x_divtagdefaultwrapper" dir="ltr" style="">
<p style="margin-top:0; margin-bottom:0">Dear All,</p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0">As it currently
is, python3-pyvenv is broken because it is missing the
venv module run-time dependency.</p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0">The patch I am
submitting is to add the venv module dependency to
python3-pyvenv. </p>
<p style="margin-top:0; margin-bottom:0">The dependency
has been <span style="font-size:12pt">added </span><span
style="font-size:12pt">using the newly added venv
package (python3-venv).</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-size:12pt">The python3-venv package has
been added for future proofing since pyvenv has been
deprecated in Python 3.6 and creation of virtual
environment is done using the venv module directly
(i.e python3 -m venv my_venv).</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-size:12pt"><br>
</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-size:12pt">Regards,</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-size:12pt"><br>
</span></p>
<p style="margin-top:0; margin-bottom:0"><span
style="font-size:12pt">Hugues Kamba</span></p>
<div id="x_x_Signature">
<div id="x_x_divtagdefaultwrapper" dir="ltr" style="">
</div>
</div>
</div>
IMPORTANT NOTICE: The contents of this email and any
attachments are confidential and may also be privileged. If
you are not the intended recipient, please notify the sender
immediately and do not disclose the contents to any other
person, use it for any purpose, or store or copy the
information in any medium. Thank you. <br>
<fieldset class="x_x_mimeAttachmentHeader"></fieldset>
</blockquote>
</div>
</div>
IMPORTANT NOTICE: The contents of this email and any attachments
are confidential and may also be privileged. If you are not the
intended recipient, please notify the sender immediately and do
not disclose the contents to any other person, use it for any
purpose, or store or copy the information in any medium. Thank
you.
</blockquote>
</body>
</html>