<div dir="ltr">Agreed with Andre, also the quotes in new version don't match, which makes me wonder how well this was actually tested.<div><br></div><div>Using apostrophes inside quoted string value would make it easier to see that there is extra " after the useless yes call.</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 30, 2018 at 6:31 PM Andre McCurdy <<a href="mailto:armccurdy@gmail.com">armccurdy@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Oct 30, 2018 at 10:17 AM Bruce Ashfield<br>
<<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>> wrote:<br>
><br>
> On 10/30/18 1:02 PM, Andre McCurdy wrote:<br>
> > On Mon, Oct 29, 2018 at 8:39 PM Bruce Ashfield<br>
> > <<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>> wrote:<br>
> >><br>
> >> As was warned by commit 312ee68752fa [kconfig: announce removal of<br>
> >> oldnoconfig if used], oldnoconfig has been removed from the 4.20 kernel.<br>
> >><br>
> >> So we switch our default mode to olddefconfig.<br>
> >><br>
> >> commit fb16d8912 [kconfig: replace 'oldnoconfig' with 'olddefconfig',<br>
> >> and keep the old name as an alias] introduced olddefconfig in the 3.10<br>
> >> kernel, we shuffle oldnoconfig to the fallback target.<br>
> >><br>
> >> The fallback mode allows kernels between 3.10 and the currently listed<br>
> >> oldest kernel of 3.2 to continue to configure.<br>
> >><br>
> >> Signed-off-by: Bruce Ashfield <<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>><br>
> >> ---<br>
> >><br>
> >> v2: Tweaked to add a fallback mode as suggested by Andre McCurdy<br>
> >><br>
> >> Not for the release, just wanted to get this in the queue for<br>
> >> when master reopens so we'll be ready for 4.20+ kernel versions<br>
> >><br>
> >> Bruce<br>
> >><br>
> >><br>
> >> meta/classes/kernel.bbclass | 2 +-<br>
> >> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> >><br>
> >> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass<br>
> >> index e04d2fe00434..8fe207165ae8 100644<br>
> >> --- a/meta/classes/kernel.bbclass<br>
> >> +++ b/meta/classes/kernel.bbclass<br>
> >> @@ -492,7 +492,7 @@ sysroot_stage_all () {<br>
> >> :<br>
> >> }<br>
> >><br>
> >> -KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} oldnoconfig"<br>
> >> +KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} olddefconfig || yes '' | oe_runmake -C ${S} O=${B} CC="${KERNEL_CC}" oldnoconfig"<br>
> ><br>
> > There's no "yes" needed with oldnoconfig. The new fallback should just<br>
> > be the existing default command.<br>
><br>
> *shrug*<br>
><br>
> I'll leave this as is, since it works as tested. Feel free to<br>
> send followups.<br>
<br>
"make oldnoconfig" without the "yes" has been well tested for the past<br>
few OE releases so it's just odd you decided to change it. Why did<br>
you?<br>
<br>
> >> python check_oldest_kernel() {<br>
> >> oldest_kernel = d.getVar('OLDEST_KERNEL')<br>
> >> --<br>
> >> 2.5.0<br>
> >><br>
> >> --<br>
> >> _______________________________________________<br>
> >> Openembedded-core mailing list<br>
> >> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> >> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
><br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>