<div dir="ltr">+KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} olddefconfig || yes '' | oe_runmake -C ${S} O=${B} CC="${KERNEL_CC}" oldnoconfig" <div><br></div><div>It's the 2 apostrophes after "yes", which look like double quotes in the font used in gmail, sorry.</div><div><div> <br></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 30, 2018 at 7:58 PM Bruce Ashfield <<a href="mailto:bruce.ashfield@windriver.com">bruce.ashfield@windriver.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 2018-10-30 2:51 PM, Martin Jansa wrote:<br>
Agreed with Andre, also the quotes in new version don't match, which<br>
> makes me wonder how well this was actually tested.<br>
<br>
Where are you seeing the non matching quotes ? The CC="" blocks<br>
have been there for a while, and haven't caused any issues.<br>
Other than that, I'm seeing matched "", '' and the entire command<br>
wrapped in "".<br>
<br>
It was tested by running configure, definitely worked here.<br>
<br>
The 'yes' in the pipeline is just in case there is some kernel<br>
somewhere with a patch, and the pipeline could stall. Since it<br>
is the last option in the compound statement, I definitely wanted<br>
it to complete.<br>
<br>
I can drop the yes, but I'm pretty sure the extra overhead wouldn't<br>
have harmed anyone.<br>
<br>
> <br>
> Using apostrophes inside quoted string value would make it easier to see <br>
> that there is extra " after the useless yes call.<br>
<br>
I'm still not seeing the extra quote.<br>
<br>
Bruce<br>
<br>
> <br>
> On Tue, Oct 30, 2018 at 6:31 PM Andre McCurdy <<a href="mailto:armccurdy@gmail.com" target="_blank">armccurdy@gmail.com</a> <br>
> <mailto:<a href="mailto:armccurdy@gmail.com" target="_blank">armccurdy@gmail.com</a>>> wrote:<br>
> <br>
> On Tue, Oct 30, 2018 at 10:17 AM Bruce Ashfield<br>
> <<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a> <mailto:<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>>><br>
> wrote:<br>
> ><br>
> > On 10/30/18 1:02 PM, Andre McCurdy wrote:<br>
> > > On Mon, Oct 29, 2018 at 8:39 PM Bruce Ashfield<br>
> > > <<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a><br>
> <mailto:<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>>> wrote:<br>
> > >><br>
> > >> As was warned by commit 312ee68752fa [kconfig: announce removal of<br>
> > >> oldnoconfig if used], oldnoconfig has been removed from the<br>
> 4.20 kernel.<br>
> > >><br>
> > >> So we switch our default mode to olddefconfig.<br>
> > >><br>
> > >> commit fb16d8912 [kconfig: replace 'oldnoconfig' with<br>
> 'olddefconfig',<br>
> > >> and keep the old name as an alias] introduced olddefconfig in<br>
> the 3.10<br>
> > >> kernel, we shuffle oldnoconfig to the fallback target.<br>
> > >><br>
> > >> The fallback mode allows kernels between 3.10 and the<br>
> currently listed<br>
> > >> oldest kernel of 3.2 to continue to configure.<br>
> > >><br>
> > >> Signed-off-by: Bruce Ashfield <<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a><br>
> <mailto:<a href="mailto:bruce.ashfield@windriver.com" target="_blank">bruce.ashfield@windriver.com</a>>><br>
> > >> ---<br>
> > >><br>
> > >> v2: Tweaked to add a fallback mode as suggested by Andre McCurdy<br>
> > >><br>
> > >> Not for the release, just wanted to get this in the queue for<br>
> > >> when master reopens so we'll be ready for 4.20+ kernel versions<br>
> > >><br>
> > >> Bruce<br>
> > >><br>
> > >><br>
> > >> meta/classes/kernel.bbclass | 2 +-<br>
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> > >><br>
> > >> diff --git a/meta/classes/kernel.bbclass<br>
> b/meta/classes/kernel.bbclass<br>
> > >> index e04d2fe00434..8fe207165ae8 100644<br>
> > >> --- a/meta/classes/kernel.bbclass<br>
> > >> +++ b/meta/classes/kernel.bbclass<br>
> > >> @@ -492,7 +492,7 @@ sysroot_stage_all () {<br>
> > >> :<br>
> > >> }<br>
> > >><br>
> > >> -KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S}<br>
> CC="${KERNEL_CC}" O=${B} oldnoconfig"<br>
> > >> +KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S}<br>
> CC="${KERNEL_CC}" O=${B} olddefconfig || yes '' | oe_runmake -C ${S}<br>
> O=${B} CC="${KERNEL_CC}" oldnoconfig"<br>
> > ><br>
> > > There's no "yes" needed with oldnoconfig. The new fallback<br>
> should just<br>
> > > be the existing default command.<br>
> ><br>
> > *shrug*<br>
> ><br>
> > I'll leave this as is, since it works as tested. Feel free to<br>
> > send followups.<br>
> <br>
> "make oldnoconfig" without the "yes" has been well tested for the past<br>
> few OE releases so it's just odd you decided to change it. Why did<br>
> you?<br>
> <br>
> > >> python check_oldest_kernel() {<br>
> > >> oldest_kernel = d.getVar('OLDEST_KERNEL')<br>
> > >> --<br>
> > >> 2.5.0<br>
> > >><br>
> > >> --<br>
> > >> _______________________________________________<br>
> > >> Openembedded-core mailing list<br>
> > >> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <mailto:<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a>><br>
> > >> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
> ><br>
> -- <br>
> _______________________________________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <mailto:<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a>><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
> <br>
<br>
</blockquote></div>