<div dir="ltr">This seems like it’d make a good general image qa check instead, rather than being part of do_image_tar.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Nov 29, 2018 at 7:29 AM <<a href="mailto:Mikko.Rapeli@bmw.de">Mikko.Rapeli@bmw.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, Nov 29, 2018 at 02:04:14PM +0000, Richard Purdie wrote:<br>
> On Thu, 2018-11-29 at 14:21 +0200, Mikko Rapeli wrote:<br>
> > If IMAGE_ROOTFS_SIZE_LIMIT is defined in image configuration, then<br>
> > build will fail if for tar image type the uncompressed tar ball size<br>
> > exceeds the value, as reported by 'du -ks'.<br>
> > <br>
> > This check could be extended to other image types as well.<br>
> > <br>
> > There already exists a check with IMAGE_ROOTFS_SIZE variable<br>
> > but I could not figure out how to actually use it. It does<br>
> > some quite complex overhead calculations which did not seem<br>
> > to work for me on sumo.<br>
> > <br>
> > When the image size is exceeded, build fails like this:<br>
> > <br>
> > ERROR: image-1.0-r0 do_image_tar: Image size 170712 of<br>
> > /home/builder/src/base/build/tmp/work/linux/image/1.0-r0/deploy-<br>
> > image-complete/image.rootfs.tar reported by 'du -ks' is larger than<br>
> > limit IMAGE_ROOTFS_SIZE_LIMIT 170000<br>
> <br>
> What about IMAGE_ROOTFS_MAXSIZE?<br>
><br>
> I think IMAGE_ROOTFS_SIZE is about adding extra space to the image, not<br>
> limiting its size...<br>
<br>
Yea, forgot to mention that I tried that too but got inconsisten results.<br>
I know it's bad but it was easier for me to add this new test than to figure<br>
out what's wrong with current yocto image size checks. Hence RFC.<br>
<br>
-Mikko<br>
<br>
> Cheers,<br>
> <br>
> Richard<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Christopher Larson<br>kergoth at gmail dot com<br>Founder - BitBake, OpenEmbedded, OpenZaurus<br>Senior Software Engineer, Mentor Graphics</div></div></div></div>