<div dir="ltr">> So I think that shell code can use either spaces or tabs as indentation.<div><br></div><div>True, that's why I used "I wish" and ":)" because as Christmas gift I always wanted consistency (not only between layers, but between shell and python code as well).<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Dec 6, 2018 at 3:55 AM Robert Yang <<a href="mailto:liezhi.yang@windriver.com">liezhi.yang@windriver.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Martin,<br>
<br>
On 12/5/18 10:40 PM, Martin Jansa wrote:<br>
> I wish we could have the same warning for shell code as well :).<br>
><br>
<br>
According to oe's Format Guidelines:<br>
<br>
<a href="https://www.openembedded.org/wiki/Styleguide#Format_Guidelines" rel="noreferrer" target="_blank">https://www.openembedded.org/wiki/Styleguide#Format_Guidelines</a><br>
<br>
- Python functions must be four space indented - no tabs.<br>
- Shell functions in OE-Core usually use tabs for indentation, but other layers <br>
usually use consistent indentation with 4 spaces (in shell functions, python <br>
functions and for indentation of multi-line variables)<br>
<br>
<br>
So I think that shell code can use either spaces or tabs as indentation.<br>
<br>
> Can you please take care of meta-gplv2 as well?<br>
> WARNING: meta-gplv2/recipes-core/coreutils/<a href="http://coreutils_6.9.bb" rel="noreferrer" target="_blank">coreutils_6.9.bb</a> <br>
> <<a href="http://coreutils_6.9.bb" rel="noreferrer" target="_blank">http://coreutils_6.9.bb</a>>: python should use 4 spaces indentation, but found <br>
> tabs in <a href="http://coreutils_6.9.bb" rel="noreferrer" target="_blank">coreutils_6.9.bb</a> <<a href="http://coreutils_6.9.bb" rel="noreferrer" target="_blank">http://coreutils_6.9.bb</a>>, line 95<br>
<br>
Thanks, I've sent a patch for it.<br>
<br>
// Robert<br>
<br>
> <br>
> I've sent patch for meta-oe issue:<br>
> <a href="http://lists.openembedded.org/pipermail/openembedded-devel/2018-December/197803.html" rel="noreferrer" target="_blank">http://lists.openembedded.org/pipermail/openembedded-devel/2018-December/197803.html</a><br>
> <br>
> <br>
> On Fri, Nov 23, 2018 at 11:51 AM Robert Yang <<a href="mailto:liezhi.yang@windriver.com" target="_blank">liezhi.yang@windriver.com</a> <br>
> <mailto:<a href="mailto:liezhi.yang@windriver.com" target="_blank">liezhi.yang@windriver.com</a>>> wrote:<br>
> <br>
> Use 4 spaces to replace a tab.<br>
> <br>
> Signed-off-by: Robert Yang <<a href="mailto:liezhi.yang@windriver.com" target="_blank">liezhi.yang@windriver.com</a><br>
> <mailto:<a href="mailto:liezhi.yang@windriver.com" target="_blank">liezhi.yang@windriver.com</a>>><br>
> ---<br>
> meta/classes/uboot-sign.bbclass | 16 ++++++++--------<br>
> 1 file changed, 8 insertions(+), 8 deletions(-)<br>
> <br>
> diff --git a/meta/classes/uboot-sign.bbclass b/meta/classes/uboot-sign.bbclass<br>
> index 0e5e1b1..03100b8 100644<br>
> --- a/meta/classes/uboot-sign.bbclass<br>
> +++ b/meta/classes/uboot-sign.bbclass<br>
> @@ -93,14 +93,14 @@ do_install_append() {<br>
> }<br>
> <br>
> python () {<br>
> - if d.getVar('UBOOT_SIGN_ENABLE') == '1' and d.getVar('PN') ==<br>
> d.getVar('UBOOT_PN'):<br>
> - kernel_pn = d.getVar('PREFERRED_PROVIDER_virtual/kernel')<br>
> + if d.getVar('UBOOT_SIGN_ENABLE') == '1' and d.getVar('PN') ==<br>
> d.getVar('UBOOT_PN'):<br>
> + kernel_pn = d.getVar('PREFERRED_PROVIDER_virtual/kernel')<br>
> <br>
> - # Make "bitbake u-boot -cdeploy" deploys the signed u-boot.dtb<br>
> - d.appendVarFlag('do_deploy', 'depends', ' %s:do_deploy' %<br>
> kernel_pn)<br>
> + # Make "bitbake u-boot -cdeploy" deploys the signed u-boot.dtb<br>
> + d.appendVarFlag('do_deploy', 'depends', ' %s:do_deploy' % kernel_pn)<br>
> <br>
> - # kernerl's do_deploy is a litle special, so we can't use<br>
> - # do_deploy_append, otherwise it would override<br>
> - # kernel_do_deploy.<br>
> - d.appendVarFlag('do_deploy', 'prefuncs', ' concat_dtb')<br>
> + # kernerl's do_deploy is a litle special, so we can't use<br>
> + # do_deploy_append, otherwise it would override<br>
> + # kernel_do_deploy.<br>
> + d.appendVarFlag('do_deploy', 'prefuncs', ' concat_dtb')<br>
> }<br>
> -- <br>
> 2.7.4<br>
> <br>
> -- <br>
> _______________________________________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <mailto:<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a>><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
> <br>
</blockquote></div>