<div dir="ltr">Hi, Khem:<div><br></div><div>Arha, I think you are right, I did not noticed its impact to incremental build, will send a V2 soon.</div><div><br></div><div>//Ming Liu</div></div><br><div class="gmail_quote"><div dir="ltr">Khem Raj &lt;<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>&gt; 於 2019年1月6日 週日 下午5:00寫道：<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
On 1/6/19 7:54 AM, <a href="mailto:liu.ming50@gmail.com" target="_blank">liu.ming50@gmail.com</a> wrote:<br>
&gt; From: Ming Liu &lt;<a href="mailto:liu.ming50@gmail.com" target="_blank">liu.ming50@gmail.com</a>&gt;<br>
&gt; <br>
&gt; I found a issue that sometimes there are leftovers in IMAGE_ROOTFS<br>
&gt; that are generated by the previous builds. I think this is caused by<br>
&gt; IMAGE_ROOTFS is not in do_rootfs[cleandirs], so add it in.<br>
&gt; <br>
&gt; IMGDEPLOYDIR could be added to do_rootfs[dirs] as well, hence some code<br>
&gt; in rootfs.py to generate the IMAGE_ROOTFS/IMGDEPLOYDIR directories<br>
&gt; could be removed.<br>
&gt; <br>
&gt; Signed-off-by: Ming Liu &lt;<a href="mailto:liu.ming50@gmail.com" target="_blank">liu.ming50@gmail.com</a>&gt;<br>
&gt; ---<br>
&gt;   meta/classes/image.bbclass | 4 ++--<br>
&gt;   meta/lib/oe/rootfs.py      | 5 -----<br>
&gt;   2 files changed, 2 insertions(+), 7 deletions(-)<br>
&gt; <br>
&gt; diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass<br>
&gt; index 11927f3..464cc5d 100644<br>
&gt; --- a/meta/classes/image.bbclass<br>
&gt; +++ b/meta/classes/image.bbclass<br>
&gt; @@ -251,8 +251,8 @@ fakeroot python do_rootfs () {<br>
&gt;   <br>
&gt;       progress_reporter.finish()<br>
&gt;   }<br>
&gt; -do_rootfs[dirs] = &quot;${TOPDIR}&quot;<br>
&gt; -do_rootfs[cleandirs] += &quot;${S} ${IMGDEPLOYDIR}&quot;<br>
&gt; +do_rootfs[dirs] = &quot;${IMAGE_ROOTFS} ${IMGDEPLOYDIR} ${TOPDIR}&quot;<br>
&gt; +do_rootfs[cleandirs] += &quot;${S} ${IMAGE_ROOTFS} ${IMGDEPLOYDIR}&quot;<br>
<br>
would it mean no incremental rootfs creation ? meaning it will generate <br>
full rootfs from scratch every time<br>
<br>
&gt;   do_rootfs[umask] = &quot;022&quot;<br>
&gt;   do_rootfs[file-checksums] += &quot;${POSTINST_INTERCEPT_CHECKSUMS}&quot;<br>
&gt;   addtask rootfs after do_prepare_recipe_sysroot<br>
&gt; diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py<br>
&gt; index 4273891..945c769 100644<br>
&gt; --- a/meta/lib/oe/rootfs.py<br>
&gt; +++ b/meta/lib/oe/rootfs.py<br>
&gt; @@ -19,7 +19,6 @@ class Rootfs(object, metaclass=ABCMeta):<br>
&gt;           self.d = d<br>
&gt;           <a href="http://self.pm" rel="noreferrer" target="_blank">self.pm</a> = None<br>
&gt;           self.image_rootfs = self.d.getVar(&#39;IMAGE_ROOTFS&#39;)<br>
&gt; -        self.deploydir = self.d.getVar(&#39;IMGDEPLOYDIR&#39;)<br>
&gt;           self.progress_reporter = progress_reporter<br>
&gt;           self.logcatcher = logcatcher<br>
&gt;   <br>
&gt; @@ -188,10 +187,6 @@ class Rootfs(object, metaclass=ABCMeta):<br>
&gt;           post_process_cmds = self.d.getVar(&quot;ROOTFS_POSTPROCESS_COMMAND&quot;)<br>
&gt;           rootfs_post_install_cmds = self.d.getVar(&#39;ROOTFS_POSTINSTALL_COMMAND&#39;)<br>
&gt;   <br>
&gt; -        bb.utils.mkdirhier(self.image_rootfs)<br>
&gt; -<br>
&gt; -        bb.utils.mkdirhier(self.deploydir)<br>
&gt; -<br>
&gt;           execute_pre_post_process(self.d, pre_process_cmds)<br>
&gt;   <br>
&gt;           if self.progress_reporter:<br>
&gt; <br>
</blockquote></div>