<div dir="ltr">I&#39;m wondering what the point of checking the output of mount is.  If we&#39;re just checking that the image booted then the grep is sufficient right?<div><br></div><div>Ross</div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, 11 Jan 2019 at 09:22, Kang Kai &lt;<a href="mailto:Kai.Kang@windriver.com">Kai.Kang@windriver.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On 2019/1/4 上午10:49, <a href="mailto:kai.kang@windriver.com" target="_blank">kai.kang@windriver.com</a> wrote:<br>
&gt; From: Kai Kang &lt;<a href="mailto:kai.kang@windriver.com" target="_blank">kai.kang@windriver.com</a>&gt;<br>
&gt;<br>
&gt; It checks output of mount in wic test case test_qemu. But the outputs are<br>
&gt; different between sysvinit and systemd. Add assertion for systemd.<br>
&gt;<br>
&gt; Signed-off-by: Kai Kang &lt;<a href="mailto:kai.kang@windriver.com" target="_blank">kai.kang@windriver.com</a>&gt;<br>
&gt; ---<br>
&gt;   meta/lib/oeqa/selftest/cases/wic.py | 5 ++++-<br>
&gt;   1 file changed, 4 insertions(+), 1 deletion(-)<br>
&gt;<br>
&gt; diff --git a/meta/lib/oeqa/selftest/cases/wic.py b/meta/lib/oeqa/selftest/cases/wic.py<br>
&gt; index 36ee5e5a14..a6bc566166 100644<br>
&gt; --- a/meta/lib/oeqa/selftest/cases/wic.py<br>
&gt; +++ b/meta/lib/oeqa/selftest/cases/wic.py<br>
&gt; @@ -627,7 +627,10 @@ class Wic2(WicTestCase):<br>
&gt;           with runqemu(&#39;wic-image-minimal&#39;, ssh=False) as qemu:<br>
&gt;               cmd = &quot;mount |grep &#39;^/dev/&#39; | cut -f1,3 -d &#39; &#39; | sort&quot;<br>
&gt;               status, output = qemu.run_serial(cmd)<br>
&gt; -            self.assertEqual(output, &#39;/dev/root /\r\n/dev/sda1 /boot\r\n/dev/sda3 /media\r\n/dev/sda4 /mnt&#39;)<br>
&gt; +            if &#39;sysvinit&#39; in get_bb_var(&#39;DISTRO_FEATURES&#39;):<br>
&gt; +                self.assertEqual(output, &#39;/dev/root /\r\n/dev/sda1 /boot\r\n/dev/sda3 /media\r\n/dev/sda4 /mnt&#39;)<br>
&gt; +            else:<br>
&gt; +                self.assertEqual(output, &#39;/dev/sda1 /boot\r\n/dev/sda2 /\r\n/dev/sda3 /media\r\n/dev/sda4 /mnt&#39;)<br>
&gt;               cmd = &quot;grep UUID= /etc/fstab&quot;<br>
&gt;               status, output = qemu.run_serial(cmd)<br>
&gt;               self.assertEqual(1, status, &#39;Failed to run command &quot;%s&quot;: %s&#39; % (cmd, output))<br>
<br>
<br>
Ping<br>
<br>
-- <br>
Kai Kang<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>