<div>Thanks!</div><div dir="auto"><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 14, 2019 at 11:53 AM Mittal, Anuj <<a href="mailto:anuj.mittal@intel.com">anuj.mittal@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, 2019-02-14 at 07:58 -0800, Khem Raj wrote:<br>
> On Wed, Feb 13, 2019 at 9:49 PM Anuj Mittal <<a href="mailto:anuj.mittal@intel.com" target="_blank">anuj.mittal@intel.com</a>><br>
> wrote:<br>
> > <br>
> > For changes, see:<br>
> > <br>
> > <br>
<a href="https://cgit.freedesktop.org/pixman/log/?qt=range&q=pixman-0.38.0...pixman-0.34.0" rel="noreferrer" target="_blank">https://cgit.freedesktop.org/pixman/log/?qt=range&q=pixman-0.38.0...pixman-0.34.0</a><br>
> > <br>
> > Signed-off-by: Anuj Mittal <<a href="mailto:anuj.mittal@intel.com" target="_blank">anuj.mittal@intel.com</a>><br>
> > ---<br>
> > .../xorg-lib/pixman/asm_include.patch | 29 -------------<br>
> > ------<br>
> > .../{<a href="http://pixman_0.34.0.bb" rel="noreferrer" target="_blank">pixman_0.34.0.bb</a> => <a href="http://pixman_0.38.0.bb" rel="noreferrer" target="_blank">pixman_0.38.0.bb</a>} | 5 ++--<br>
> > 2 files changed, 2 insertions(+), 32 deletions(-)<br>
> > delete mode 100644 meta/recipes-graphics/xorg-<br>
> > lib/pixman/asm_include.patch<br>
> > rename meta/recipes-graphics/xorg-lib/{<a href="http://pixman_0.34.0.bb" rel="noreferrer" target="_blank">pixman_0.34.0.bb</a> =><br>
> > <a href="http://pixman_0.38.0.bb" rel="noreferrer" target="_blank">pixman_0.38.0.bb</a>} (89%)<br>
> > <br>
> > diff --git a/meta/recipes-graphics/xorg-<br>
> > lib/pixman/asm_include.patch b/meta/recipes-graphics/xorg-<br>
> > lib/pixman/asm_include.patch<br>
> > deleted file mode 100644<br>
> > index b52a5707d6..0000000000<br>
> > --- a/meta/recipes-graphics/xorg-lib/pixman/asm_include.patch<br>
> > +++ /dev/null<br>
> > @@ -1,29 +0,0 @@<br>
> > -Fixes errors like<br>
> > -<br>
> > -Assembler messages:<br>
> > -Fatal error: can't create .libs/pixman-mips-dspr2-asm.o: No such<br>
> > file or directory<br>
> > -<br>
> > -it works with glibc because it uses gcc fixed-headers but thats<br>
> > not right.<br>
> > -<br>
> > -We move the include under C block<br>
> > -<br>
> > -Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br>
> > -Upstream-Status: Pending<br>
> > -Index: pixman-0.32.6/pixman/pixman-private.h<br>
> > -==================================================================<br>
> > =<br>
> > ---- pixman-0.32.6.orig/pixman/pixman-private.h<br>
> > -+++ pixman-0.32.6/pixman/pixman-private.h<br>
> > -@@ -1,4 +1,3 @@<br>
> > --#include <float.h><br>
> > -<br>
> > - #ifndef PIXMAN_PRIVATE_H<br>
> > - #define PIXMAN_PRIVATE_H<br>
> > -@@ -17,6 +16,8 @@<br>
> > -<br>
> > - #ifndef __ASSEMBLER__<br>
> > -<br>
> > -+#include <float.h><br>
> > -+<br>
> > - #ifndef PACKAGE<br>
> > - # error config.h must be included before pixman-private.h<br>
> > - #endif<br>
> > diff --git a/meta/recipes-graphics/xorg-lib/<a href="http://pixman_0.34.0.bb" rel="noreferrer" target="_blank">pixman_0.34.0.bb</a><br>
> > b/meta/recipes-graphics/xorg-lib/<a href="http://pixman_0.38.0.bb" rel="noreferrer" target="_blank">pixman_0.38.0.bb</a><br>
> > similarity index 89%<br>
> > rename from meta/recipes-graphics/xorg-lib/<a href="http://pixman_0.34.0.bb" rel="noreferrer" target="_blank">pixman_0.34.0.bb</a><br>
> > rename to meta/recipes-graphics/xorg-lib/<a href="http://pixman_0.38.0.bb" rel="noreferrer" target="_blank">pixman_0.38.0.bb</a><br>
> > index c290fa4614..49c3d62342 100644<br>
> > --- a/meta/recipes-graphics/xorg-lib/<a href="http://pixman_0.34.0.bb" rel="noreferrer" target="_blank">pixman_0.34.0.bb</a><br>
> > +++ b/meta/recipes-graphics/xorg-lib/<a href="http://pixman_0.38.0.bb" rel="noreferrer" target="_blank">pixman_0.38.0.bb</a><br>
> > @@ -31,11 +31,10 @@ EXTRA_OECONF_class-nativesdk = "--disable-gtk"<br>
> > <br>
> > SRC_URI += "\<br>
> > file://0001-ARM-qemu-related-workarounds-in-cpu-<br>
> > features-detecti.patch \<br>
> > - file://asm_include.patch \<br>
> <br>
> can you confirm you tested a build with musl/mips ?<br>
<br>
I tested with musl. The change is also present upstream now:<br>
<br>
<br>
<a href="https://cgit.freedesktop.org/pixman/commit/?id=7c6066b700c7cdd4aeb8be426b14b3a5f0de4b6c" rel="noreferrer" target="_blank">https://cgit.freedesktop.org/pixman/commit/?id=7c6066b700c7cdd4aeb8be426b14b3a5f0de4b6c</a><br>
</blockquote></div></div>