<div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 3, 2019 at 9:36 PM Nathan Rossi <<a href="mailto:nathan@nathanrossi.com">nathan@nathanrossi.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, 4 Apr 2019 at 13:48, Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>> wrote:<br>
><br>
> On Wed, Apr 3, 2019 at 8:28 PM Nathan Rossi <<a href="mailto:nathan@nathanrossi.com" target="_blank">nathan@nathanrossi.com</a>> wrote:<br>
> ><br>
> > On Thu, 4 Apr 2019 at 03:02, Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>> wrote:<br>
> > ><br>
> > > On Wed, Apr 3, 2019 at 2:26 AM Bach, Pascal <<a href="mailto:pascal.bach@siemens.com" target="_blank">pascal.bach@siemens.com</a>> wrote:<br>
> > > ><br>
> > > > ><br>
> > > > > Enable the building of the curses based ui for cmake. This depends on<br>
> > > > > ncurses.<br>
> > > ><br>
> > > > I think this is acceptable. It might also be useful for people wanting to use ccmake inside an SDK.<br>
> ><br>
> > Just to be clear, this change only affects cmake-native, the recipe<br>
> > for target/nativesdk is unchanged. Although interestingly the cmake<br>
> > (target/nativesdk) recipe already depends on ncurses (despite<br>
> > disabling ccmake).<br>
> ><br>
> > > ><br>
> > ><br>
> > > Adding dependencies do serialize builds and might have penalty on<br>
> > > build time, better is to turn this into a packageconfig<br>
> > > option and keep it disabled by default.<br>
> ><br>
> > I can rework this patch to make it a PACKAGECONFIG option. However the<br>
> > reason for enabling ccmake by default is due to the addition of the<br>
> > ccmake bbclass in this series, which relies on having ccmake available<br>
> > in the native sysroot. Having to override PACKAGECONFIG to use the<br>
> > ccmake class seemed broken (since it is not particularly a distro<br>
> > config).<br>
> ><br>
> > I could not find a good example of this sort of requirement for<br>
> > configuration for any other bbclass except for maybe<br>
> > gobject-introspection (which relies on qemu-native configured<br>
> > correctly to have linux-user for the target).<br>
> ><br>
> > Another approach I considered to have this working without requiring<br>
> > the user to setup PACKAGECONFIG would be to have a "ccmake-native"<br>
> > recipe which built the ccmake binary. But this seemed like it would be<br>
> > extra maintenance burden compared to this patch which has minimal<br>
> > build time overhead.<br>
> ><br>
><br>
> this seems fine, if the number of recipes needing this bbclass are far less than<br>
> one the needing cmake bbclass.<br>
<br>
Just to clarify, are you suggesting that making a ccmake-native recipe<br>
would be fine? Or that requiring the PACKAGECONFIG setup would be<br>
acceptable/preferred?</blockquote><div dir="auto"><br></div><div dir="auto">I don’t have enough of data to lean on either way</div><div dir="auto">Are we adding this to every cmake using recipes benefit or is it only a handful </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
Thanks,<br>
Nathan<br>
<br>
><br>
> > Regards,<br>
> > Nathan<br>
> ><br>
> > ><br>
> > > > > Signed-off-by: Nathan Rossi <<a href="mailto:nathan@nathanrossi.com" target="_blank">nathan@nathanrossi.com</a>><br>
> > > > > ---<br>
> > > > > This patch suggests enabling this in the cmake-native recipe, however this<br>
> > > > > might be undesirable for bootstrapping reasons. Whilst ccmake is not used<br>
> > > > > normally the added dependency on ncurses is likely required for other parts<br>
> > > > > of the build so impact on build ordering and time should be relatively<br>
> > > > > minimal.<br>
> > > > ><br>
> > > > > Changes in v2:<br>
> > > > > - None<br>
> > > > > ---<br>
> > > > > meta/recipes-devtools/cmake/<a href="http://cmake-native_3.14.0.bb" rel="noreferrer" target="_blank">cmake-native_3.14.0.bb</a> | 5 ++---<br>
> > > > > 1 file changed, 2 insertions(+), 3 deletions(-)<br>
> > > > ><br>
> > > > > diff --git a/meta/recipes-devtools/cmake/<a href="http://cmake-native_3.14.0.bb" rel="noreferrer" target="_blank">cmake-native_3.14.0.bb</a><br>
> > > > > b/meta/recipes-devtools/cmake/<a href="http://cmake-native_3.14.0.bb" rel="noreferrer" target="_blank">cmake-native_3.14.0.bb</a><br>
> > > > > index fedcf3d4bd..b2952ee5f5 100644<br>
> > > > > --- a/meta/recipes-devtools/cmake/<a href="http://cmake-native_3.14.0.bb" rel="noreferrer" target="_blank">cmake-native_3.14.0.bb</a><br>
> > > > > +++ b/meta/recipes-devtools/cmake/<a href="http://cmake-native_3.14.0.bb" rel="noreferrer" target="_blank">cmake-native_3.14.0.bb</a><br>
> > > > > @@ -1,7 +1,7 @@<br>
> > > > > require cmake.inc<br>
> > > > > inherit native<br>
> > > > ><br>
> > > > > -DEPENDS += "bzip2-replacement-native expat-native xz-native zlib-native<br>
> > > > > curl-native"<br>
> > > > > +DEPENDS += "bzip2-replacement-native expat-native xz-native zlib-native<br>
> > > > > curl-native ncurses-native"<br>
> > > > ><br>
> > > > > SRC_URI += "file://OEToolchainConfig.cmake \<br>
> > > > > file://<a href="http://environment.d-cmake.sh" rel="noreferrer" target="_blank">environment.d-cmake.sh</a> \ @@ -13,10 +13,9 @@ SRC_URI +=<br>
> > > > > "file://OEToolchainConfig.cmake \ B = "${WORKDIR}/build"<br>
> > > > > do_configure[cleandirs] = "${B}"<br>
> > > > ><br>
> > > > > -# Disable ccmake since we don't depend on ncurses CMAKE_EXTRACONF =<br>
> > > > > "\<br>
> > > > > -DCMAKE_LIBRARY_PATH=${STAGING_LIBDIR_NATIVE} \<br>
> > > > > - -DBUILD_CursesDialog=0 \<br>
> > > > > + -DBUILD_CursesDialog=1 \<br>
> > > > > -DCMAKE_USE_SYSTEM_LIBRARIES=1 \<br>
> > > > > -DCMAKE_USE_SYSTEM_LIBRARY_JSONCPP=0 \<br>
> > > > > -DCMAKE_USE_SYSTEM_LIBRARY_LIBARCHIVE=0 \<br>
> > > > > ---<br>
> > > > > 2.20.1<br>
> > > > > --<br>
> > > > > _______________________________________________<br>
> > > > > Openembedded-core mailing list<br>
> > > > > <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> > > > > <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
> > > > --<br>
> > > > _______________________________________________<br>
> > > > Openembedded-core mailing list<br>
> > > > <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> > > > <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div></div>