<div><div dir="auto">Can you test this on say rpi3 in 64bit mode and see all is ok ?</div></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 13, 2019 at 2:53 AM <<a href="mailto:kai.kang@windriver.com">kai.kang@windriver.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Kai Kang <<a href="mailto:kai.kang@windriver.com" target="_blank">kai.kang@windriver.com</a>><br>
<br>
It removes function JSC::AssemblerBuffer::data() for ARM64 in commit<br>
<a href="https://trac.webkit.org/changeset/236589/webkit" rel="noreferrer" target="_blank">https://trac.webkit.org/changeset/236589/webkit</a>. But the function is<br>
still required by Cortex A53 and fails to compile for arm64:<br>
<br>
| .../tmp/work/aarch64-poky-linux/webkitgtk/2.24.1-r0/webkitgtk-2.24.1/Source/JavaScriptCore/assembler/ARM64Assembler.h:3769:100: error: 'class JSC::AssemblerBuffer' has no member named 'data'<br>
| if (UNLIKELY((*reinterpret_cast_ptr<int32_t*>(reinterpret_cast_ptr<char*>(m_buffer.data()) + m_buffer.codeSize() - sizeof(int32_t)) & 0x0a000000) == 0x08000000))<br>
<br>
Not set WTF_CPU_ARM64_CORTEXA53 for arm64 to fix the failure.<br>
<br>
Signed-off-by: Kai Kang <<a href="mailto:kai.kang@windriver.com" target="_blank">kai.kang@windriver.com</a>><br>
---<br>
meta/recipes-sato/webkit/<a href="http://webkitgtk_2.24.1.bb" rel="noreferrer" target="_blank">webkitgtk_2.24.1.bb</a> | 2 --<br>
1 file changed, 2 deletions(-)<br>
<br>
diff --git a/meta/recipes-sato/webkit/<a href="http://webkitgtk_2.24.1.bb" rel="noreferrer" target="_blank">webkitgtk_2.24.1.bb</a> b/meta/recipes-sato/webkit/<a href="http://webkitgtk_2.24.1.bb" rel="noreferrer" target="_blank">webkitgtk_2.24.1.bb</a><br>
index 771a893a6b..a57a3c058c 100644<br>
--- a/meta/recipes-sato/webkit/<a href="http://webkitgtk_2.24.1.bb" rel="noreferrer" target="_blank">webkitgtk_2.24.1.bb</a><br>
+++ b/meta/recipes-sato/webkit/<a href="http://webkitgtk_2.24.1.bb" rel="noreferrer" target="_blank">webkitgtk_2.24.1.bb</a><br>
@@ -98,8 +98,6 @@ EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "<br>
EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF "<br>
EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF "<br>
<br>
-EXTRA_OECMAKE_append_aarch64 = " -DWTF_CPU_ARM64_CORTEXA53=ON"<br>
-<br>
# JIT not supported on MIPS either<br>
EXTRA_OECMAKE_append_mipsarch = " -DENABLE_JIT=OFF "<br>
<br>
-- <br>
2.20.0<br>
<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div></div>