<div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, May 19, 2019 at 2:58 AM Alexander Kanavin &lt;<a href="mailto:alex.kanavin@gmail.com">alex.kanavin@gmail.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Because the files are no longer included in bash-completion. They are provided only by util-linux now, previously they were provided by both.</blockquote><div dir="auto"><br></div><div dir="auto">Thanks for explaining it would be good to note in commit secondly the comment and variable i seems to be redundant as well so please remove them too </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
Alex<br>
<br>
&gt; On 19 May 2019, at 6.48, Khem Raj &lt;<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>&gt; wrote:<br>
&gt; <br>
&gt; <br>
&gt; <br>
&gt;&gt; On 5/17/19 11:11 AM, Alexander Kanavin wrote:<br>
&gt;&gt; Signed-off-by: Alexander Kanavin &lt;<a href="mailto:alex.kanavin@gmail.com" target="_blank">alex.kanavin@gmail.com</a>&gt;<br>
&gt;&gt; ---<br>
&gt;&gt;  .../{<a href="http://bash-completion_2.8.bb" rel="noreferrer" target="_blank">bash-completion_2.8.bb</a> =&gt; <a href="http://bash-completion_2.9.bb" rel="noreferrer" target="_blank">bash-completion_2.9.bb</a>}     | 7 ++-----<br>
&gt;&gt;  1 file changed, 2 insertions(+), 5 deletions(-)<br>
&gt;&gt;  rename meta/recipes-support/bash-completion/{<a href="http://bash-completion_2.8.bb" rel="noreferrer" target="_blank">bash-completion_2.8.bb</a> =&gt; <a href="http://bash-completion_2.9.bb" rel="noreferrer" target="_blank">bash-completion_2.9.bb</a>} (82%)<br>
&gt;&gt; diff --git a/meta/recipes-support/bash-completion/<a href="http://bash-completion_2.8.bb" rel="noreferrer" target="_blank">bash-completion_2.8.bb</a> b/meta/recipes-support/bash-completion/<a href="http://bash-completion_2.9.bb" rel="noreferrer" target="_blank">bash-completion_2.9.bb</a><br>
&gt;&gt; similarity index 82%<br>
&gt;&gt; rename from meta/recipes-support/bash-completion/<a href="http://bash-completion_2.8.bb" rel="noreferrer" target="_blank">bash-completion_2.8.bb</a><br>
&gt;&gt; rename to meta/recipes-support/bash-completion/<a href="http://bash-completion_2.9.bb" rel="noreferrer" target="_blank">bash-completion_2.9.bb</a><br>
&gt;&gt; index 85064343e30..ce66ba5a2a8 100644<br>
&gt;&gt; --- a/meta/recipes-support/bash-completion/<a href="http://bash-completion_2.8.bb" rel="noreferrer" target="_blank">bash-completion_2.8.bb</a><br>
&gt;&gt; +++ b/meta/recipes-support/bash-completion/<a href="http://bash-completion_2.9.bb" rel="noreferrer" target="_blank">bash-completion_2.9.bb</a><br>
&gt;&gt; @@ -9,8 +9,8 @@ SECTION = &quot;console/utils&quot;<br>
&gt;&gt;    SRC_URI = &quot;<a href="https://github.com/scop/bash-completion/releases/download/$%7BPV%7D/$%7BBPN%7D-$%7BPV%7D.tar.xz" rel="noreferrer" target="_blank">https://github.com/scop/bash-completion/releases/download/${PV}/${BPN}-${PV}.tar.xz</a>&quot;<br>
&gt;&gt;  -SRC_URI[md5sum] = &quot;201b6ae62f7d5fb5b1b25e34427db919&quot;<br>
&gt;&gt; -SRC_URI[sha256sum] = &quot;c01f5570f5698a0dda8dc9cfb2a83744daa1ec54758373a6e349bd903375f54d&quot;<br>
&gt;&gt; +SRC_URI[md5sum] = &quot;60139333b25c4d54ad40323b701be130&quot;<br>
&gt;&gt; +SRC_URI[sha256sum] = &quot;d48fe378e731062f479c5f8802ffa9d3c40a275a19e6e0f6f6cc4b90fa12b2f5&quot;<br>
&gt;&gt;  UPSTREAM_CHECK_REGEX = &quot;bash-completion-(?P&lt;pver&gt;(?!2008).+)\.tar&quot;<br>
&gt;&gt;  UPSTREAM_CHECK_URI = &quot;<a href="https://github.com/scop/bash-completion/releases" rel="noreferrer" target="_blank">https://github.com/scop/bash-completion/releases</a>&quot;<br>
&gt;&gt;  @@ -25,9 +25,6 @@ do_install_append() {<br>
&gt;&gt;        # Delete files already provided by util-linux<br>
&gt;&gt;      local i<br>
&gt;&gt; -    for i in mount umount; do<br>
&gt;&gt; -        rm ${D}${datadir}/${BPN}/completions/$i<br>
&gt;&gt; -    done<br>
&gt; <br>
&gt; why is this deleted ?<br>
&gt; <br>
&gt;&gt;  }<br>
&gt;&gt;    RDEPENDS_${PN} = &quot;bash&quot;<br>
</blockquote></div></div>