<div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 22, 2019 at 11:10 PM Adrian Bunk <<a href="mailto:bunk@stusta.de">bunk@stusta.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, May 22, 2019 at 04:29:33PM -0700, Khem Raj wrote:<br>
> On Tue, May 21, 2019 at 11:49 PM Adrian Bunk <<a href="mailto:bunk@stusta.de" target="_blank">bunk@stusta.de</a>> wrote:<br>
> ><br>
> > On Tue, May 21, 2019 at 06:32:28PM -0700, Khem Raj wrote:<br>
> > >...<br>
> > > PN and PN-binutils is not empty anymore on musl<br>
> > >...<br>
> > > ++#if !defined(FNM_EXTMATCH)<br>
> > > ++# define FNM_EXTMATCH (1 << 5) /* Use ksh-like extended matching. */<br>
> > > ++#endif<br>
> > >...<br>
> ><br>
> > This might fix the compilation, but it is horribly wrong.<br>
> ><br>
> > It passes a flag to a function that this function does not understand.<br>
> ><br>
> > In the best case the function returns with an error on unknown flags.<br>
> ><br>
> > In the worst case the function does silently something different from<br>
> > what the caller expects it to do.<br>
> ><br>
> <br>
> I forgot that the API is provided by libc here so mimic'ing the define<br>
> infact could<br>
> cause pain. I think its better to nullify it in this case where it is<br>
> being used in these<br>
> files.<br>
<br>
Just looking at the usage in src/elfcompress.c, my first impression is <br>
that this tool is mostly useless without a properly working FNM_EXTMATCH.<br>
<br>
Are the eu-* utils actually important in the cases where space is so <br>
limited that people are forced to use musl instead of glibc?<br>
<br>
</blockquote><div dir="auto"><br></div><div dir="auto">They are primarily needed for testing and now we have good auto testing infra it would be good to build them </div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">cu<br>
Adrian<br>
<br>
-- <br>
<br>
"Is there not promise of rain?" Ling Tan asked suddenly out<br>
of the darkness. There had been need of rain for many days.<br>
"Only a promise," Lao Er said.<br>
Pearl S. Buck - Dragon Seed<br>
<br>
</blockquote></div></div>