<div dir="ltr"><div>It's still nicer to have</div>SRC_URI_append_libc-musl = " ${SRC_URI_MUSL}"<br><div>if the intermediate SRC_URI_MUSL variable is useful.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 24, 2019 at 7:59 PM Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, May 24, 2019 at 10:31 AM Richard Purdie<br>
<<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>> wrote:<br>
><br>
> On Fri, 2019-05-24 at 10:17 +0800, Chen Qi wrote:<br>
> > systemd upstream only care about glibc. We made musl specific<br>
> > patches so that systemd could work. But currently these patches<br>
> > contain potential security issues.<br>
> ><br>
> > So apply these patches only when the libc is musl.<br>
> ><br>
> > Signed-off-by: Chen Qi <<a href="mailto:Qi.Chen@windriver.com" target="_blank">Qi.Chen@windriver.com</a>><br>
> > ---<br>
> > meta/recipes-core/systemd/<a href="http://systemd_242.bb" rel="noreferrer" target="_blank">systemd_242.bb</a> | 2 +-<br>
> > 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> ><br>
> > diff --git a/meta/recipes-core/systemd/<a href="http://systemd_242.bb" rel="noreferrer" target="_blank">systemd_242.bb</a> b/meta/recipes-<br>
> > core/systemd/<a href="http://systemd_242.bb" rel="noreferrer" target="_blank">systemd_242.bb</a><br>
> > index 2dda0d0..adb592f 100644<br>
> > --- a/meta/recipes-core/systemd/<a href="http://systemd_242.bb" rel="noreferrer" target="_blank">systemd_242.bb</a><br>
> > +++ b/meta/recipes-core/systemd/<a href="http://systemd_242.bb" rel="noreferrer" target="_blank">systemd_242.bb</a><br>
> > @@ -27,7 +27,7 @@ SRC_URI += "file://touchscreen.rules \<br>
> > "<br>
> ><br>
> > # patches needed by musl<br>
> > -SRC_URI += "${SRC_URI_MUSL}"<br>
> > +SRC_URI += "${@d.getVar('SRC_URI_MUSL') if d.getVar('TCLIBC') ==<br>
> > 'musl' else ''}"<br>
> > SRC_URI_MUSL = "file://0001-Use-getenv-when-secure-versions-are-not-<br>
> > available.patch \<br>
> > file://0002-don-t-use-glibc-specific-qsort_r.patch \<br>
> > file://0003-missing_type.h-add-__compare_fn_t-and-<br>
> > comparison_fn_.patch \<br>
><br>
> Doesn't the usual SRC_URI_append_libc-musl = "X" work?<br>
><br>
<br>
yes this should be better, SRC_URI_MUSL was introduced so someone<br>
could override it<br>
but if we make it optional then using override is better I think<br>
<br>
> Cheers,<br>
><br>
> Richard<br>
><br>
> --<br>
> _______________________________________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>