<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Hi Richard,</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Thanks for your comments. Sorry I missed the questions when I previously sent it. Resent due to the fact I missed the "Signed off by" in the patch last time around.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">I agree with you in general about the scope creep, however the license.bbclass code is heavily coupled with this class, as it just greps the runtime dir for all the 'lic_data' it deems appropriate. All that data appears
to be emitted here.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Might be nice if there was another bbclass which actually just emitted the 'data for licenses' rather than the 'lic_data' being a subset of this package data.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">I'd be happy to propose that class for review. However, just looking at this function it already seems we've been "heading down a path" here for a while anyway? The content of one extra variable doesn't seem like the
tipping point to me.<br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Richard Purdie <richard.purdie@linuxfoundation.org><br>
<b>Sent:</b> 30 May 2019 14:18:36<br>
<b>To:</b> Rob Walton; openembedded-core@lists.openembedded.org<br>
<b>Subject:</b> Re: [OE-core] [PATCH 2/2] package.bbclass: Emit HOMEPAGE pkgdata.</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Wed, 2019-05-22 at 12:44 +0000, Rob Walton wrote:<br>
> Emit the contents of HOMEPAGE in the extra pkgdata. This is useful<br>
> information to have when creating license manifests.<br>
> <br>
> Signed-off-by: Rob Walton <rob.walton@arm.com><br>
> ---<br>
> meta/classes/package.bbclass | 1 +<br>
> 1 file changed, 1 insertion(+)<br>
> <br>
> diff --git a/meta/classes/package.bbclass<br>
> b/meta/classes/package.bbclass<br>
> index 4c0a859..a08aefe 100644<br>
> --- a/meta/classes/package.bbclass<br>
> +++ b/meta/classes/package.bbclass<br>
> @@ -1458,6 +1458,7 @@ fi<br>
> write_if_exists(sf, pkg, 'PKGR')<br>
> write_if_exists(sf, pkg, 'LICENSE')<br>
> write_if_exists(sf, pkg, 'DESCRIPTION')<br>
> + write_if_exists(sf, pkg, 'HOMEPAGE')<br>
> write_if_exists(sf, pkg, 'SUMMARY')<br>
> write_if_exists(sf, pkg, 'RDEPENDS')<br>
> rprov = write_if_exists(sf, pkg, 'RPROVIDES')<br>
<br>
This isn't the first time this has been requested, back in 14/11/2017 a<br>
similar patch had the reply:<br>
<br>
"This was already proposed once and rejected as its using the interface<br>
for something it really wasn't designed for"<br>
<br>
You've also sent this patch once already and questions were raised<br>
then.<br>
<br>
I have to admit I don't like the license.bbclass code, its starting to<br>
look like anything every legal department could ask for, meaning it<br>
does no one thing well, just many things badly. I don't like that mess<br>
starting to creep into the packaging code which does have a clearly<br>
defined purpose and use.<br>
<br>
Put another way, which variables do we draw the line at?<br>
<br>
I worry about the path accepting this patch leads us down :(<br>
<br>
Cheers,<br>
<br>
Richard<br>
<br>
<br>
<br>
</div>
</span></font></div>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose,
or store or copy the information in any medium. Thank you.
</body>
</html>