<div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, 12 May 2019 at 10:18, Hongxu Jia <<a href="mailto:hongxu.jia@windriver.com">hongxu.jia@windriver.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The upstream git tag has a `upstream/' prefix, such as:<br>
>>> import re<br>
>>> pattern = "upstream/(?P<pver>\d+(\.\d+)+(\+\d+)*)"<br>
>>> string = "upstream/6.1+20181013"<br>
>>> result = re.match(pattern, string)<br>
>>> result['pver']<br>
'6.1+20181013'<br></blockquote><div><br></div><div>Have you checked with devtool that this actually works?</div><div><br></div><div> Before this commit:</div><div>alexander@alexander-box:~/development/poky$ devtool check-upgrade-status ncurses<br>INFO: ncurses 6.1 6.1+20181013 Hongxu Jia <<a href="mailto:hongxu.jia@windriver.com">hongxu.jia@windriver.com</a>> 7a97a7f937762ba342d5b2fd7cd090885a809835</div><div><br></div><div>After the commit:<br></div><div>alexander@alexander-box:~/development/poky$ devtool check-upgrade-status ncurses</div><div>INFO: ncurses 6.1 UNKNOWN_BROKEN Hongxu Jia <<a href="mailto:hongxu.jia@windriver.com">hongxu.jia@windriver.com</a>> <br></div><div><br></div><div>The code in bitbake/lib/bb/fetch2/git.py actually splits each tag with '/' as separator and takes only the last part for some reason, so those prefixes are never a part of the string that is matched against regex.<br></div><div>I'll send a revert in a moment.</div><div><br></div><div>Alex<br></div><div><br></div><div><br></div></div></div>