<div dir="ltr"><div>Thanks, this addresses the issue well :)</div><div><br></div><div>Alex<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 3 Jun 2019 at 10:49, Hongxu Jia <<a href="mailto:hongxu.jia@windriver.com">hongxu.jia@windriver.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">While pv contains char `+' (such as ncurses 6.1+20181013),<br>
it was incorrectly converted to `6.1'<br>
<br>
In this commit:<br>
- Convert [^\+]* to .*?<br>
Support pv to contain char `+' and not greedy match<br>
(Such as ncurses 6.1+20181013)<br>
<br>
- Add [^\+] to sfx match<br>
Support sfx contains extra chars between `+' and `git'<br>
(such as asciidoc "8.6.9+py3-gitAUTOINC+618f6e6f6b")<br>
<br>
- Make sfx and rev greedy match<br>
<br>
Run `devtool check-upgrade-status --all' in poky and compare results,<br>
only one difference on ncurses version:<br>
Without the commit:<br>
INFO: ncurses 6.1 6.1+20181013 Hongxu Jia <<a href="mailto:hongxu.jia@windriver.com" target="_blank">hongxu.jia@windriver.com</a>> 7a97a7f937762ba342d5b2fd7cd090885a809835<br>
<br>
With the commit:<br>
INFO: ncurses 6.1+20181013 MATCH Hongxu Jia <<a href="mailto:hongxu.jia@windriver.com" target="_blank">hongxu.jia@windriver.com</a>> 7a97a7f937762ba342d5b2fd7cd090885a809835<br>
<br>
Signed-off-by: Hongxu Jia <<a href="mailto:hongxu.jia@windriver.com" target="_blank">hongxu.jia@windriver.com</a>><br>
---<br>
meta/lib/oe/recipeutils.py | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/meta/lib/oe/recipeutils.py b/meta/lib/oe/recipeutils.py<br>
index 1e5b9a49f9..630ae967af 100644<br>
--- a/meta/lib/oe/recipeutils.py<br>
+++ b/meta/lib/oe/recipeutils.py<br>
@@ -934,7 +934,7 @@ def get_recipe_pv_without_srcpv(pv, uri_type):<br>
sfx = ''<br>
<br>
if uri_type == 'git':<br>
- git_regex = re.compile(r"(?P<pfx>v?)(?P<ver>[^\+]*)((?P<sfx>\+(git)?r?(AUTOINC\+))(?P<rev>.*))?")<br>
+ git_regex = re.compile(r"(?P<pfx>v?)(?P<ver>.*?)(?P<sfx>\+[^\+]*(git)?r?(AUTOINC\+))(?P<rev>.*)")<br>
m = git_regex.match(pv)<br>
<br>
if m:<br>
-- <br>
2.21.0<br>
<br>
</blockquote></div>