<div dir="ltr">Sure, follow-up patch is fine with me.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 13, 2019 at 8:38 PM Marco Felsch <<a href="mailto:m.felsch@pengutronix.de">m.felsch@pengutronix.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Martin,<br>
<br>
On 19-06-13 20:17, Martin Jansa wrote:<br>
> Looks like nice cleanup, but is someone still using llvm 3.2 or older?<br>
<br>
I don't know but I learned to avoid breaking changes.<br>
<br>
> With PACKAGECONFIG for almost each gallium driver it might be easier to get<br>
> rid<br>
> of GALLIUMDRIVERS_LLVM33, GALLIUMDRIVERS_LLVM33_ENABLED, GALLIUMDRIVERS_LLVM<br>
> variables and use just GALLIUMDRIVERS.<br>
<br>
Sure that will increase readability and drops unneeded variables :) But<br>
can we add a follow up patch to address this?<br>
<br>
> In worst case scenario people using llvm 3.2 or older will need to redefine<br>
> some of these PACKAGECONFIGs but that shouldn't be big issue considering<br>
> that they probably have different mesa recipe already.<br>
<br>
I'm not that deep inside LLVM just googled it and saw that the current<br>
version is 8.0.1 so maybe you are right.<br>
<br>
> People can then select right list of drivers with or without<br>
> using gallium-llvm as well.<br>
<br>
As I wrote above we should address this by a seperate patch to keep the<br>
diff as small as possible :)<br>
<br>
Regards,<br>
Marco<br>
<br>
> <br>
> <br>
> On Thu, Jun 13, 2019 at 7:54 PM Marco Felsch <<a href="mailto:m.felsch@pengutronix.de" target="_blank">m.felsch@pengutronix.de</a>><br>
> wrote:<br>
> <br>
> > Most of the time we are compiling for embedded targets which have<br>
> > dedicated hardware combinations. Enabling swrast by default isn't a good<br>
> > solution for such devices because if the hardware render node has an<br>
> > issue or doesn't support a special format/request Mesa will fallback to<br>
> > the software renderer. This will make it harder to debug performance<br>
> > issues.<br>
> ><br>
> > A better way is to let the user decide if a software renderer is<br>
> > needed e.g. if the system has no hardware renderer or to have such a<br>
> > fallback device. This way the user knows that the software renderer is<br>
> > enabled.<br>
> ><br>
> > Signed-off-by: Marco Felsch <<a href="mailto:m.felsch@pengutronix.de" target="_blank">m.felsch@pengutronix.de</a>><br>
> > ---<br>
> > v3<br>
> > - rebased on current master-next branch<br>
> ><br>
> > meta/recipes-graphics/mesa/mesa.inc | 22 +++++++++++++---------<br>
> > 1 file changed, 13 insertions(+), 9 deletions(-)<br>
> ><br>
> > diff --git a/meta/recipes-graphics/mesa/mesa.inc<br>
> > b/meta/recipes-graphics/mesa/mesa.inc<br>
> > index 3ecfb8506c..a6d36cf21c 100644<br>
> > --- a/meta/recipes-graphics/mesa/mesa.inc<br>
> > +++ b/meta/recipes-graphics/mesa/mesa.inc<br>
> > @@ -90,23 +90,27 @@ PACKAGECONFIG[egl] = "-Degl=true, -Degl=false"<br>
> ><br>
> > PACKAGECONFIG[etnaviv] = ""<br>
> > PACKAGECONFIG[kmsro] = ""<br>
> > +PACKAGECONFIG[swrast] = ""<br>
> ><br>
> > -GALLIUMDRIVERS = "swrast"<br>
> > -GALLIUMDRIVERS_append ="${@bb.utils.contains('PACKAGECONFIG', 'etnaviv',<br>
> > ',etnaviv', '', d)}"<br>
> > -GALLIUMDRIVERS_append ="${@bb.utils.contains('PACKAGECONFIG', 'kmsro',<br>
> > ',kmsro', '', d)}"<br>
> > +GALLIUMDRIVERS = ""<br>
> > +GALLIUMDRIVERS +="${@bb.utils.contains('PACKAGECONFIG', 'swrast',<br>
> > 'swrast', '', d)}"<br>
> > +GALLIUMDRIVERS +="${@bb.utils.contains('PACKAGECONFIG', 'etnaviv',<br>
> > 'etnaviv', '', d)}"<br>
> > +GALLIUMDRIVERS +="${@bb.utils.contains('PACKAGECONFIG', 'kmsro', 'kmsro',<br>
> > '', d)}"<br>
> ><br>
> > # radeonsi requires LLVM<br>
> > -GALLIUMDRIVERS_LLVM33 = "${@bb.utils.contains('PACKAGECONFIG', 'r600',<br>
> > ',radeonsi', '', d)}"<br>
> > +GALLIUMDRIVERS_LLVM33 = "${@bb.utils.contains('PACKAGECONFIG', 'r600',<br>
> > 'radeonsi', '', d)}"<br>
> > GALLIUMDRIVERS_LLVM33_ENABLED =<br>
> > "${@oe.utils.version_less_or_equal('MESA_LLVM_RELEASE', '3.2', False,<br>
> > len('${GALLIUMDRIVERS_LLVM33}') > 0, d)}"<br>
> > -GALLIUMDRIVERS_LLVM = "r300,svga,nouveau${@',${GALLIUMDRIVERS_LLVM33}' if<br>
> > ${GALLIUMDRIVERS_LLVM33_ENABLED} else ''}"<br>
> > +GALLIUMDRIVERS_LLVM = "r300 svga nouveau ${@'${GALLIUMDRIVERS_LLVM33}' if<br>
> > ${GALLIUMDRIVERS_LLVM33_ENABLED} else ''}"<br>
> ><br>
> > PACKAGECONFIG[r600] = ""<br>
> ><br>
> > -GALLIUMDRIVERS_append = "${@bb.utils.contains('PACKAGECONFIG',<br>
> > 'gallium-llvm', ',${GALLIUMDRIVERS_LLVM}', '', d)}"<br>
> > -GALLIUMDRIVERS_append = "${@bb.utils.contains('PACKAGECONFIG', 'r600',<br>
> > ',r600', '', d)}"<br>
> > -GALLIUMDRIVERS_append = ",virgl"<br>
> > +GALLIUMDRIVERS += "${@bb.utils.contains('PACKAGECONFIG', 'gallium-llvm',<br>
> > '${GALLIUMDRIVERS_LLVM}', '', d)}"<br>
> > +GALLIUMDRIVERS += "${@bb.utils.contains('PACKAGECONFIG', 'r600', 'r600',<br>
> > '', d)}"<br>
> > +GALLIUMDRIVERS += "virgl"<br>
> > +GALLIUMDRIVERS_MESON = "${@",".join("${GALLIUMDRIVERS}".split())}"<br>
> > +<br>
> > +PACKAGECONFIG[gallium] = "-Dgallium-drivers=${GALLIUMDRIVERS_MESON},<br>
> > -Dgallium-drivers=''"<br>
> ><br>
> > -PACKAGECONFIG[gallium] = "-Dgallium-drivers=${GALLIUMDRIVERS},<br>
> > -Dgallium-drivers=''"<br>
> > MESA_LLVM_RELEASE ?= "8.0.0"<br>
> > PACKAGECONFIG[gallium-llvm] = "-Dllvm=true -Dshared-llvm=true,<br>
> > -Dllvm=false, llvm${MESA_LLVM_RELEASE} llvm-native \<br>
> > ${@'elfutils' if<br>
> > ${GALLIUMDRIVERS_LLVM33_ENABLED} else ''}"<br>
> > --<br>
> > 2.20.1<br>
> ><br>
> > --<br>
> > _______________________________________________<br>
> > Openembedded-core mailing list<br>
> > <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> > <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
> ><br>
<br>
-- <br>
Pengutronix e.K. | |<br>
Industrial Linux Solutions | <a href="http://www.pengutronix.de/" rel="noreferrer" target="_blank">http://www.pengutronix.de/</a> |<br>
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |<br>
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |<br>
</blockquote></div>