<div dir="ltr"><div>Also if the patch is already submitted, the status should not be Pending.</div><div><br></div><div>Alex<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 13 Jun 2019 at 11:23, Burton, Ross <<a href="mailto:ross.burton@intel.com">ross.burton@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, 13 Jun 2019 at 09:48, Lei Maohui <<a href="mailto:leimaohui@cn.fujitsu.com" target="_blank">leimaohui@cn.fujitsu.com</a>> wrote:<br>
><br>
> From: Hong Liu <<a href="mailto:hongl.fnst@cn.fujitsu.com" target="_blank">hongl.fnst@cn.fujitsu.com</a>><br>
><br>
> Fix bug as following on aarch64BE:<br>
><br>
> Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'<br>
><br>
> Upstream-Status: Pending [<a href="https://github.com/openssl/openssl/pull/9151" rel="noreferrer" target="_blank">https://github.com/openssl/openssl/pull/9151</a>]<br>
<br>
This line ^^^<br>
<br>
> Signed-off-by: Lei Maohui <<a href="mailto:leimaohui@cn.fujitsu.com" target="_blank">leimaohui@cn.fujitsu.com</a>><br>
> ---<br>
> ...01-Fix-build-error-for-aarch64-big-endian.patch | 41 ++++++++++++++++++++++<br>
> .../recipes-connectivity/openssl/<a href="http://openssl_1.1.1c.bb" rel="noreferrer" target="_blank">openssl_1.1.1c.bb</a> | 1 +<br>
> 2 files changed, 42 insertions(+)<br>
> create mode 100644 meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch<br>
><br>
> diff --git a/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch<br>
> new file mode 100644<br>
> index 0000000..65ca02c<br>
> --- /dev/null<br>
> +++ b/meta/recipes-connectivity/openssl/openssl/0001-Fix-build-error-for-aarch64-big-endian.patch<br>
> @@ -0,0 +1,41 @@<br>
> +From 1f8c0f2feea5cdcae0bcd9dfc78198d9e2c4cf09 Mon Sep 17 00:00:00 2001<br>
> +From: Lei Maohui <<a href="mailto:leimaohui@cn.fujitsu.com" target="_blank">leimaohui@cn.fujitsu.com</a>><br>
> +Date: Thu, 13 Jun 2019 12:17:30 +0900<br>
> +Subject: [PATCH] Fix build error for aarch64 big endian.<br>
> +<br>
> +Modified rev to rev64, because rev only takes integer registers.<br>
> +<a href="https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90827" rel="noreferrer" target="_blank">https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90827</a><br>
> +Otherwise, the following error will occur.<br>
> +<br>
> +Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'<br>
> +<br>
<br>
^^ goes here.<br>
<br>
The upstream status is a property of the patch you're adding, not the<br>
commit message.<br>
<br>
> +Signed-off-by: Lei Maohui <<a href="mailto:leimaohui@cn.fujitsu.com" target="_blank">leimaohui@cn.fujitsu.com</a>><br>
> +---<br>
> + crypto/sha/asm/<a href="http://keccak1600-armv8.pl" rel="noreferrer" target="_blank">keccak1600-armv8.pl</a> | 4 ++--<br>
> + 1 file changed, 2 insertions(+), 2 deletions(-)<br>
> +<br>
> +diff --git a/crypto/sha/asm/<a href="http://keccak1600-armv8.pl" rel="noreferrer" target="_blank">keccak1600-armv8.pl</a> b/crypto/sha/asm/<a href="http://keccak1600-armv8.pl" rel="noreferrer" target="_blank">keccak1600-armv8.pl</a><br>
> +index dc72f18..6620690 100755<br>
> +--- a/crypto/sha/asm/<a href="http://keccak1600-armv8.pl" rel="noreferrer" target="_blank">keccak1600-armv8.pl</a><br>
> ++++ b/crypto/sha/asm/<a href="http://keccak1600-armv8.pl" rel="noreferrer" target="_blank">keccak1600-armv8.pl</a><br>
> +@@ -731,7 +731,7 @@ $code.=<<___;<br>
> + blo .Lprocess_block_ce<br>
> + ldr d31,[$inp],#8 // *inp++<br>
> + #ifdef __AARCH64EB__<br>
> +- rev v31.16b,v31.16b<br>
> ++ rev64 v31.16b,v31.16b<br>
> + #endif<br>
> + eor $A[$j/5][$j%5],$A[$j/5][$j%5],v31.16b<br>
> + beq .Lprocess_block_ce<br>
> +@@ -740,7 +740,7 @@ ___<br>
> + $code.=<<___;<br>
> + ldr d31,[$inp],#8 // *inp++<br>
> + #ifdef __AARCH64EB__<br>
> +- rev v31.16b,v31.16b<br>
> ++ rev64 v31.16b,v31.16b<br>
> + #endif<br>
> + eor $A[4][4],$A[4][4],v31.16b<br>
> +<br>
> +--<br>
> +2.7.4<br>
> +<br>
> diff --git a/meta/recipes-connectivity/openssl/<a href="http://openssl_1.1.1c.bb" rel="noreferrer" target="_blank">openssl_1.1.1c.bb</a> b/meta/recipes-connectivity/openssl/<a href="http://openssl_1.1.1c.bb" rel="noreferrer" target="_blank">openssl_1.1.1c.bb</a><br>
> index 669b1a1..ec85ccd 100644<br>
> --- a/meta/recipes-connectivity/openssl/<a href="http://openssl_1.1.1c.bb" rel="noreferrer" target="_blank">openssl_1.1.1c.bb</a><br>
> +++ b/meta/recipes-connectivity/openssl/<a href="http://openssl_1.1.1c.bb" rel="noreferrer" target="_blank">openssl_1.1.1c.bb</a><br>
> @@ -16,6 +16,7 @@ SRC_URI = "<a href="http://www.openssl.org/source/openssl-$%7BPV%7D.tar.gz" rel="noreferrer" target="_blank">http://www.openssl.org/source/openssl-${PV}.tar.gz</a> \<br>
> file://0001-skip-test_symbol_presence.patch \<br>
> file://0001-buildinfo-strip-sysroot-and-debug-prefix-map-from-co.patch \<br>
> file://afalg.patch \<br>
> + file://0001-Fix-build-error-for-aarch64-big-endian.patch \<br>
> "<br>
><br>
> SRC_URI_append_class-nativesdk = " \<br>
> --<br>
> 2.7.4<br>
><br>
><br>
><br>
> --<br>
> _______________________________________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>