<div dir="ltr">oe-core likes to mix them :)</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 18, 2019 at 9:14 PM Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Jun 18, 2019 at 12:09 PM Martin Jansa <<a href="mailto:martin.jansa@gmail.com" target="_blank">martin.jansa@gmail.com</a>> wrote:<br>
><br>
> * since 1522f09a4d serf: cleanup recipe<br>
> serf.do_install fails in builds with multilib enabled (with<br>
> libdir=/usr/lib64 on host where /usr/lib64 doesn't exist)<br>
><br>
> DEBUG: Executing shell function do_install<br>
> scons: Reading SConscript files ...<br>
> PermissionError: [Errno 13] Permission denied: '/usr/lib64':<br>
> File "TOPDIR/BUILD/work/qemux86-signage-linux/serf/1.3.9-r0/serf-1.3.9/SConstruct", line 158:<br>
> ENV = os.environ,<br>
> File "/TOPDIR/BUILD/work/qemux86-signage-linux/serf/1.3.9-r0/recipe-sysroot-native/usr/bin/../../usr/lib/python3.7/site-packages/SCons/Environment.py", line 965:<br>
> variables.Update(self)<br>
> File "/TOPDIR/BUILD/work/qemux86-signage-linux/serf/1.3.9-r0/recipe-sysroot-native/usr/bin/../../usr/lib/python3.7/site-packages/SCons/Variables/__init__.py", line 227:<br>
> option.validator(option.key, env.subst('${%s}'%option.key), env)<br>
> File "TOPDIR/BUILD/work/qemux86-signage-linux/serf/1.3.9-r0/serf-1.3.9/SConstruct", line 60:<br>
> return PathVariable.PathIsDirCreate(key, val, env)<br>
> File "/TOPDIR/BUILD/work/qemux86-signage-linux/serf/1.3.9-r0/recipe-sysroot-native/usr/bin/../../usr/lib/python3.7/site-packages/SCons/Variables/PathVariable.py", line 101:<br>
> os.makedirs(val)<br>
> File "TOPDIR/BUILD/work/qemux86-signage-linux/serf/1.3.9-r0/recipe-sysroot-native/usr/lib/python3.7/os.py", line 221:<br>
> mkdir(name, mode)<br>
> ERROR: scons install execution failed.<br>
><br>
> * I don't know how exactly --install-sandbox is supposed to work but<br>
> in this case it's trying to mkdir /usr/lib64 on the host rootfs<br>
> which is clearly wrong and if I set LIBDIR together with<br>
> --install-sandbox then the install paths are prefixed with $D twice<br>
> in some cases (not for includedir and empty libdir at the end).<br>
> So in the end I think it was an issue caused by the custom path<br>
> validator in serf's SConstruct, removing that stops touching host<br>
> and the installed paths (including the paths inside libserf*.pc)<br>
> look correct<br>
><br>
> Signed-off-by: Martin Jansa <<a href="mailto:Martin.Jansa@gmail.com" target="_blank">Martin.Jansa@gmail.com</a>><br>
> ---<br>
> ...ories.without.sandbox-install.prefix.patch | 34 +++++++++++++++++++<br>
> meta/recipes-support/serf/<a href="http://serf_1.3.9.bb" rel="noreferrer" target="_blank">serf_1.3.9.bb</a> | 1 +<br>
> 2 files changed, 35 insertions(+)<br>
> create mode 100644 meta/recipes-support/serf/serf/SConstruct.stop.creating.directories.without.sandbox-install.prefix.patch<br>
><br>
> diff --git a/meta/recipes-support/serf/serf/SConstruct.stop.creating.directories.without.sandbox-install.prefix.patch b/meta/recipes-support/serf/serf/SConstruct.stop.creating.directories.without.sandbox-install.prefix.patch<br>
> new file mode 100644<br>
> index 0000000000..bfb2f5a2aa<br>
> --- /dev/null<br>
> +++ b/meta/recipes-support/serf/serf/SConstruct.stop.creating.directories.without.sandbox-install.prefix.patch<br>
> @@ -0,0 +1,34 @@<br>
> +--- ../1.3.9-r0-bad-double/serf-1.3.9/SConstruct 2019-06-18 15:49:19.968961108 +0000<br>
> ++++ serf-1.3.9/SConstruct 2019-06-18 18:53:21.412337151 +0000<br>
> +@@ -51,17 +51,6 @@<br>
> + """<br>
> + return (key, '%s' % (help), default, None, lambda val: _converter(val))<br>
> +<br>
> +-# Custom path validator, creates directory when a specified option is set.<br>
> +-# To be used to ensure a PREFIX directory is only created when installing.<br>
> +-def createPathIsDirCreateWithTarget(target):<br>
> +- def my_validator(key, val, env):<br>
> +- build_targets = (map(str, BUILD_TARGETS))<br>
> +- if target in build_targets:<br>
> +- return PathVariable.PathIsDirCreate(key, val, env)<br>
> +- else:<br>
> +- return PathVariable.PathAccept(key, val, env)<br>
> +- return my_validator<br>
> +-<br>
> + # default directories<br>
> + if sys.platform == 'win32':<br>
> + default_incdir='..'<br>
> +@@ -77,11 +66,11 @@<br>
> + PathVariable('PREFIX',<br>
> + 'Directory to install under',<br>
> + default_prefix,<br>
> +- createPathIsDirCreateWithTarget('install')),<br>
> ++ PathVariable.PathAccept),<br>
> + PathVariable('LIBDIR',<br>
> + 'Directory to install architecture dependent libraries under',<br>
> + default_libdir,<br>
> +- createPathIsDirCreateWithTarget('install')),<br>
> ++ PathVariable.PathAccept),<br>
> + PathVariable('APR',<br>
> + "Path to apr-1-config, or to APR's install area",<br>
> + default_incdir,<br>
> diff --git a/meta/recipes-support/serf/<a href="http://serf_1.3.9.bb" rel="noreferrer" target="_blank">serf_1.3.9.bb</a> b/meta/recipes-support/serf/<a href="http://serf_1.3.9.bb" rel="noreferrer" target="_blank">serf_1.3.9.bb</a><br>
> index 92cd5ca061..25ccd79e00 100644<br>
> --- a/meta/recipes-support/serf/<a href="http://serf_1.3.9.bb" rel="noreferrer" target="_blank">serf_1.3.9.bb</a><br>
> +++ b/meta/recipes-support/serf/<a href="http://serf_1.3.9.bb" rel="noreferrer" target="_blank">serf_1.3.9.bb</a><br>
> @@ -6,6 +6,7 @@ SRC_URI = "${APACHE_MIRROR}/${BPN}/${BPN}-${PV}.tar.bz2 \<br>
> file://0002-SConstruct-Fix-path-quoting-for-.def-generator.patch \<br>
> file://0003-gen_def.patch \<br>
> file://0004-Follow-up-to-r1811083-fix-building-with-scons-3.0.0-.patch \<br>
> + file://SConstruct.stop.creating.directories.without.sandbox-install.prefix.patch \<br>
<br>
tabs or spaces mismatch I guess ?<br>
<br>
> "<br>
><br>
> SRC_URI[md5sum] = "370a6340ff20366ab088012cd13f2b57"<br>
> --<br>
> 2.17.1<br>
><br>
> --<br>
> _______________________________________________<br>
> Openembedded-core mailing list<br>
> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>