<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<div class="moz-cite-prefix">On 8/3/19 11:54 AM, Alexander Kanavin
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CANNYZj_Qp_c9ncMaAXKHaAjWHnqn3OG4YkNvvKHebh3viU5i=w@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">On Sat, 3 Aug 2019 at 20:36, Khem Raj <<a
href="mailto:raj.khem@gmail.com" moz-do-not-send="true">raj.khem@gmail.com</a>>
wrote:<br>
</div>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">diff --git
a/meta/recipes-devtools/llvm/<a href="http://llvm_git.bb"
rel="noreferrer" target="_blank" moz-do-not-send="true">llvm_git.bb</a>
b/meta/recipes-devtools/llvm/<a href="http://llvm_git.bb"
rel="noreferrer" target="_blank" moz-do-not-send="true">llvm_git.bb</a><br>
index 0067635c2b..35ad3ced37 100644<br>
--- a/meta/recipes-devtools/llvm/<a
href="http://llvm_git.bb" rel="noreferrer" target="_blank"
moz-do-not-send="true">llvm_git.bb</a><br>
+++ b/meta/recipes-devtools/llvm/<a
href="http://llvm_git.bb" rel="noreferrer" target="_blank"
moz-do-not-send="true">llvm_git.bb</a><br>
BRANCH = "release/${MAJOR_VERSION}.x"<br>
MAJOR_VERSION = "8"<br>
MINOR_VERSION = "0"<br>
-PATCH_VERSION = "0"<br>
+PATCH_VERSION = "1"<br>
SOLIBVER = "1"<br>
PV = "${MAJOR_VERSION}.${MINOR_VERSION}.${PATCH_VERSION}"<br>
SRC_URI = "git://<a
href="http://github.com/llvm/llvm-project.git;branch=$%7BBRANCH%7D"
rel="noreferrer" target="_blank" moz-do-not-send="true">github.com/llvm/llvm-project.git;branch=${BRANCH}</a>
\<br>
"-Dgallium-xa=true, -Dgallium-xa=false"<br>
</blockquote>
<div><br>
</div>
<div>Should this bit also use LLVMVERSION? It would be good
to define the llvm version in a single place, otherwise we
will continue to trip over partial mismatching updates.
MAJOR_VERSION can be easily determined via inline python.</div>
</div>
</div>
</blockquote>
<p>it will limit the option of having another llvm recipe which
could be provided by other layers for different reasons. so we
provide a fallback implementation if someone wants to override
they can.<br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:CANNYZj_Qp_c9ncMaAXKHaAjWHnqn3OG4YkNvvKHebh3viU5i=w@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div><br>
</div>
<div>Alex<br>
</div>
</div>
</div>
</blockquote>
</body>
</html>