<div dir="ltr"><div>For what it's worth I am firmly in the camp that finds the non-deletion of sources annoying. When I run 'devtool reset', there is never any unsaved work left in there, but I am in too much of a hurry to do the extra 'rm' on those sources, and so much later (sometimes months later) it has to be done just prior to starting work on something else entirely (but with the same upstream component).</div><div><br></div><div>Alex<br></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 8 Aug 2019 at 22:17, Manjukumar Harthikote Matha <<a href="mailto:MANJUKUM@xilinx.com">MANJUKUM@xilinx.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Paul,<br>
<br>
> -----Original Message-----<br>
> From: <a href="mailto:openembedded-core-bounces@lists.openembedded.org" target="_blank">openembedded-core-bounces@lists.openembedded.org</a><br>
> <<a href="mailto:openembedded-core-bounces@lists.openembedded.org" target="_blank">openembedded-core-bounces@lists.openembedded.org</a>> On Behalf Of<br>
> Manjukumar Harthikote Matha<br>
> Sent: Monday, March 4, 2019 3:27 PM<br>
> To: Paul Eggleton <<a href="mailto:paul.eggleton@linux.intel.com" target="_blank">paul.eggleton@linux.intel.com</a>>; openembedded-<br>
> <a href="mailto:core@lists.openembedded.org" target="_blank">core@lists.openembedded.org</a>; Chandana Kalluri <<a href="mailto:ckalluri@xilinx.com" target="_blank">ckalluri@xilinx.com</a>><br>
> Subject: Re: [OE-core] [OE-Core][master][PATCH] standard.py: Provide an<br>
> additional option for devtool reset<br>
> <br>
> Hi Paul,<br>
> <br>
> > -----Original Message-----<br>
> > From: <a href="mailto:openembedded-core-bounces@lists.openembedded.org" target="_blank">openembedded-core-bounces@lists.openembedded.org</a><br>
> > [mailto:<a href="mailto:openembedded-core-bounces@lists.openembedded.org" target="_blank">openembedded-core-bounces@lists.openembedded.org</a>] On Behalf Of<br>
> > Paul Eggleton<br>
> > Sent: Monday, March 04, 2019 12:17 PM<br>
> > To: <a href="mailto:openembedded-core@lists.openembedded.org" target="_blank">openembedded-core@lists.openembedded.org</a>; Chandana Kalluri<br>
> > <<a href="mailto:ckalluri@xilinx.com" target="_blank">ckalluri@xilinx.com</a>><br>
> > Subject: Re: [OE-core] [OE-Core][master][PATCH] standard.py: Provide<br>
> > an additional option for devtool reset<br>
> ><br>
> > On Friday, 8 February 2019 2:57:32 PM NZDT Sai Hari Chandana Kalluri wrote:<br>
> > > The devtool reset command cleans the sysroot for a recipe in workspace.<br>
> > > It also removes the append file but leaves the source code as in<br>
> > > workspace. The source is not cleaned intentionally and the user has<br>
> > > to manually remove it before calling devtool modify again.<br>
> > ><br>
> > > Provide the user with an option to remove the source code from<br>
> > > workspace by adding a flag to the devtool reset command. The<br>
> > > --rm-source option for the devtool reset command will also clean the<br>
> > > source code from the workspace along with the sysroot and the append file.<br>
> > > Ex: devtool reset --rm-source zip or devtool reset -r zip<br>
> ><br>
> > When I wrote this I made a conscious decision not to delete the<br>
> > source, in case the user has unsaved work in the source tree; at least<br>
> > then the user has to take an explicit step (an additional rm -rf) in<br>
> > order to delete it. You might argue that adding an option is the same<br>
> > as that explicit step, but I am still hesitant as you might for<br>
> > example pick a previously used command from your command history with<br>
> > -r in it and only realise after you've run it that you've just blown away a bunch<br>
> of your work.<br>
> ><br>
> > However, I have received the feedback from a number of people that<br>
> > they find it annoying that they have to delete the source themselves<br>
> > before being able to run devtool on the recipe again. I'd like to hear<br>
> > from the wider community on the following two questions:<br>
> ><br>
> > 1) Does the convenience of having this kind of option outweigh the<br>
> > potential danger of deleting unsaved work?<br>
> ><br>
> > 2) Are there issues that anyone is experiencing that force you to run<br>
> > devtool clean/finish and then re-run devtool modify (or add, or<br>
> > upgrade), making this kind of situation come up more frequently? Or is<br>
> > it mostly that the source directories end up being left around to stumble over<br>
> some time later?<br>
> <br>
> We have seen source directories end up being left around (taking more disk<br>
> space on certain projects), hence a solution to remove it might be optimal. If the<br>
> preference is not have "-r" option to avoid command history mistake, then a full<br>
> command like devtool reset --rm-source is acceptable as well<br>
> <br>
<br>
<br>
Any update on this? Is there a reason not to merge this feature?<br>
<br>
Thanks,<br>
Manju<br>
-- <br>
_______________________________________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
</blockquote></div>