<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 13, 2019 at 11:01 PM Hongzhi, Song <<a href="mailto:hongzhi.song@windriver.com">hongzhi.song@windriver.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
On 8/14/19 10:53 AM, Bruce Ashfield wrote:<br>
><br>
><br>
> On Tue, Aug 13, 2019 at 9:59 PM Hongzhi, Song <br>
> <<a href="mailto:hongzhi.song@windriver.com" target="_blank">hongzhi.song@windriver.com</a> <mailto:<a href="mailto:hongzhi.song@windriver.com" target="_blank">hongzhi.song@windriver.com</a>>> wrote:<br>
><br>
><br>
> On 8/13/19 8:27 PM, Bruce Ashfield wrote:<br>
> ><br>
> ><br>
> > On Tue, Aug 13, 2019 at 1:35 AM Hongzhi.Song<br>
> > <<a href="mailto:hongzhi.song@windriver.com" target="_blank">hongzhi.song@windriver.com</a> <mailto:<a href="mailto:hongzhi.song@windriver.com" target="_blank">hongzhi.song@windriver.com</a>><br>
> <mailto:<a href="mailto:hongzhi.song@windriver.com" target="_blank">hongzhi.song@windriver.com</a><br>
> <mailto:<a href="mailto:hongzhi.song@windriver.com" target="_blank">hongzhi.song@windriver.com</a>>>> wrote:<br>
> ><br>
> > A new patch let kernel source Documentation/Kconfig in top<br>
> Kconfig<br>
> > So kernel-devsrc should include Documentation/ too.<br>
> > Otherwise "make scripts" will fails.<br>
> ><br>
> > patch:<br>
> > commit b1663d7e3a7961fc45262fd68a89253f2803036c<br>
> > Author: Mauro Carvalho Chehab <<a href="mailto:mchehab%2Bsamsung@kernel.org" target="_blank">mchehab+samsung@kernel.org</a><br>
> <mailto:<a href="mailto:mchehab%252Bsamsung@kernel.org" target="_blank">mchehab%2Bsamsung@kernel.org</a>><br>
> > <mailto:<a href="mailto:mchehab%252Bsamsung@kernel.org" target="_blank">mchehab%2Bsamsung@kernel.org</a><br>
> <mailto:<a href="mailto:mchehab%25252Bsamsung@kernel.org" target="_blank">mchehab%252Bsamsung@kernel.org</a>>>><br>
> > Date: Tue Jun 4 09:26:27 2019 -0300<br>
> ><br>
> > docs: Kbuild/Makefile: allow check for missing docs at<br>
> build time<br>
> ><br>
> > While this doesn't make sense for production Kernels, in<br>
> order to<br>
> > avoid regressions when documents are touched, let's add a<br>
> > check target at the make file.<br>
> ><br>
> > Signed-off-by: Mauro Carvalho Chehab<br>
> > <<a href="mailto:mchehab%2Bsamsung@kernel.org" target="_blank">mchehab+samsung@kernel.org</a><br>
> <mailto:<a href="mailto:mchehab%252Bsamsung@kernel.org" target="_blank">mchehab%2Bsamsung@kernel.org</a>><br>
> <mailto:<a href="mailto:mchehab%252Bsamsung@kernel.org" target="_blank">mchehab%2Bsamsung@kernel.org</a><br>
> <mailto:<a href="mailto:mchehab%25252Bsamsung@kernel.org" target="_blank">mchehab%252Bsamsung@kernel.org</a>>>><br>
> > Signed-off-by: Jonathan Corbet <<a href="mailto:corbet@lwn.net" target="_blank">corbet@lwn.net</a><br>
> <mailto:<a href="mailto:corbet@lwn.net" target="_blank">corbet@lwn.net</a>><br>
> > <mailto:<a href="mailto:corbet@lwn.net" target="_blank">corbet@lwn.net</a> <mailto:<a href="mailto:corbet@lwn.net" target="_blank">corbet@lwn.net</a>>>><br>
> ><br>
> > Signed-off-by: Hongzhi.Song <<a href="mailto:hongzhi.song@windriver.com" target="_blank">hongzhi.song@windriver.com</a><br>
> <mailto:<a href="mailto:hongzhi.song@windriver.com" target="_blank">hongzhi.song@windriver.com</a>><br>
> > <mailto:<a href="mailto:hongzhi.song@windriver.com" target="_blank">hongzhi.song@windriver.com</a><br>
> <mailto:<a href="mailto:hongzhi.song@windriver.com" target="_blank">hongzhi.song@windriver.com</a>>>><br>
> > ---<br>
> > meta/recipes-kernel/linux/<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">kernel-devsrc.bb</a><br>
> <<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">http://kernel-devsrc.bb</a>><br>
> > <<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">http://kernel-devsrc.bb</a>> | 2 +-<br>
> > 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> ><br>
> > diff --git a/meta/recipes-kernel/linux/<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">kernel-devsrc.bb</a><br>
> <<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">http://kernel-devsrc.bb</a>><br>
> > <<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">http://kernel-devsrc.bb</a>><br>
> > b/meta/recipes-kernel/linux/<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">kernel-devsrc.bb</a><br>
> <<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">http://kernel-devsrc.bb</a>> <<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">http://kernel-devsrc.bb</a>><br>
> > index 5ec5929..a874e06 100644<br>
> > --- a/meta/recipes-kernel/linux/<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">kernel-devsrc.bb</a><br>
> <<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">http://kernel-devsrc.bb</a>><br>
> > <<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">http://kernel-devsrc.bb</a>><br>
> > +++ b/meta/recipes-kernel/linux/<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">kernel-devsrc.bb</a><br>
> <<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">http://kernel-devsrc.bb</a>><br>
> > <<a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">http://kernel-devsrc.bb</a>><br>
> > @@ -65,7 +65,7 @@ do_install() {<br>
> > )<br>
> ><br>
> > # then drop all but the needed Makefiles/Kconfig files<br>
> > - rm -rf $kerneldir/build/Documentation<br>
> > + #rm -rf $kerneldir/build/Documentation<br>
> ><br>
> ><br>
> > In the spirit of keeping kernel-devsrc as small as possible (I have<br>
> > another patch pending if you really want the full kernel<br>
> source), this<br>
> > should only keep the Documentation/ files that are required to pass<br>
> > the check, not keep all of Documentation.<br>
><br>
><br>
> If you have a better patch, I am pleasure to accept it.<br>
><br>
><br>
> ???<br>
><br>
> This is where you'd typically do a v2 of the patch after getting a <br>
> review of a change.<br>
><br>
> But if you are refusing the feedback, then yes, I'll do a version of <br>
> the patch myself rather than just blindly copying in all of the <br>
> documentation. I'll submit it myself.<br>
><br>
> RP/Ross, whoever is taking in patches, drop this version, and I'll do <br>
> my own.<br>
<br>
<br>
I am not very familiar with the <a href="http://kernel-devsrc.bb" rel="noreferrer" target="_blank">kernel-devsrc.bb</a>. I have no objection <br>
for your decision.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">At a minimum, we shouldn't leave the commented out #rm -rf $kerneldir/build/Documentation, so I can do that and tweak the commit message a bit as well. </div></div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Leave it with me, and I'll send it to the list (hopefully tomorrow) to be sure it still solves your problem.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Bruce</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Thanks,<br>
<br>
--Hongzhi<br>
<br>
<br>
><br>
> Cheers,<br>
><br>
> Bruce<br>
><br>
><br>
> Thanks,<br>
><br>
> --Hongzhi<br>
><br>
><br>
> > Bruce<br>
> ><br>
> > rm -rf $kerneldir/build/scripts<br>
> > rm -rf $kerneldir/build/include<br>
> ><br>
> > --<br>
> > 2.8.1<br>
> ><br>
> > --<br>
> > _______________________________________________<br>
> > Openembedded-core mailing list<br>
> > <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <mailto:<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a>><br>
> > <mailto:<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br>
> <mailto:<a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a>>><br>
> > <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > - Thou shalt not follow the NULL pointer, for chaos and madness<br>
> await<br>
> > thee at its end<br>
> > - "Use the force Harry" - Gandalf, Star Trek II<br>
> ><br>
><br>
><br>
><br>
> -- <br>
> - Thou shalt not follow the NULL pointer, for chaos and madness await <br>
> thee at its end<br>
> - "Use the force Harry" - Gandalf, Star Trek II<br>
><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature">- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end<br>- "Use the force Harry" - Gandalf, Star Trek II<br><br></div></div>