<div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Sep 6, 2019 at 7:23 AM <<a href="mailto:richard.purdie@linuxfoundation.org">richard.purdie@linuxfoundation.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, 2019-09-06 at 07:15 -0700, Khem Raj wrote:<br>
> <br>
> <br>
> On Fri, Sep 6, 2019 at 12:24 AM Richard Purdie <<br>
> <a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>> wrote:<br>
> > gcc's makefile can move files, replacing with the contents<br>
> > "timestamp". This<br>
> > corrupts the headers and breaks things like the gcc testsuite.<br>
> > <br>
> > Add in a fix to ensure the headers are not corrupted through their<br>
> > hardlink copies.<br>
> > <br>
> > Signed-off-by: Richard Purdie <<a href="mailto:richard.purdie@linuxfoundation.org" target="_blank">richard.purdie@linuxfoundation.org</a>><br>
> > ---<br>
> > meta/recipes-devtools/gcc/gcc-cross.inc | 3 +++<br>
> > 1 file changed, 3 insertions(+)<br>
> > <br>
> > diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc<br>
> > b/meta/recipes-devtools/gcc/gcc-cross.inc<br>
> > index e417b898734..95af6d89a9d 100644<br>
> > --- a/meta/recipes-devtools/gcc/gcc-cross.inc<br>
> > +++ b/meta/recipes-devtools/gcc/gcc-cross.inc<br>
> > @@ -212,6 +212,9 @@ do_gcc_stash_builddir[cleandirs] =<br>
> > "${BUILDDIRSTASH}"<br>
> > do_gcc_stash_builddir () {<br>
> > dest=${BUILDDIRSTASH}<br>
> > hardlinkdir . $dest<br>
> > + # Makefile does move-if-change which can end up with<br>
> > 'timestamp' as file contents so break links to those files<br>
> > + rm $dest/gcc/include/*.h<br>
> > + cp gcc/include/*.h $dest/gcc/include/<br>
> > }<br>
> <br>
> I think we moved them outside gcc dir isn’t it <br>
<br>
Not sure I follow? I think the patch is correct?<br>
</blockquote><div dir="auto"><br></div><div dir="auto">Yeah I think patch is fine since I was wondering about files from gcc-runtime which got move </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Cheers,<br>
<br>
Richard<br>
<br>
</blockquote></div></div>